Paths

Table of Contentst

Differential D5016

[services] Backup - Blob Get Client - Add terminate
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 11:09 AM.

Tags

None

Referenced Files

	F32558071: D5016.1767261320.diff
	Wed, Dec 31, 9:55 AM

Subscribers

Details

Reviewers

• jon
tomek
varun
• max

Commits

rCOMM440114cd315c: [services] Backup - Blob Get Client - Add terminate

Summary

Depends on D5015

Adding terminate function to the blob get client.

Test Plan

backup builds

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 11:09 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 11:09 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Sep 1 2022, 11:25 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun, • max.

• karol added a parent revision: D5015: [services] Backup - Blob Get Client - Add blocking read.

• karol added a child revision: D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.

Harbormaster completed remote builds in B11773: Diff 16176.Sep 1 2022, 11:28 AM

• karol requested review of this revision.Sep 1 2022, 11:28 AM

• karol planned changes to this revision.Sep 2 2022, 2:16 PM

update

Harbormaster completed remote builds in B11844: Diff 16249.Sep 2 2022, 2:27 PM

tomek accepted this revision.Sep 5 2022, 12:40 PM

This revision is now accepted and ready to land.Sep 5 2022, 12:40 PM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 11:10 AM

Closed by commit rCOMM440114cd315c: [services] Backup - Blob Get Client - Add terminate. · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM440114cd315c: [services] Backup - Blob Get Client - Add terminate.

Harbormaster completed remote builds in B11993: Diff 16448.Sep 8 2022, 11:18 AM

ashoat added inline comments.Sep 15 2022, 1:39 PM

services/backup/blob_client/src/get_client.rs
151–163 ↗	(On Diff #16475)	We could have reduced indentation here by simply reversing conditions. See here

• karol added inline comments.Sep 15 2022, 1:46 PM

services/backup/blob_client/src/get_client.rs
151–163 ↗	(On Diff #16475)	Are you sure this is possible when dealing with `if let`? How exactly can we do this? We need the unpacked values inside of the condition.

ashoat added inline comments.Sep 16 2022, 2:14 PM

services/backup/blob_client/src/get_client.rs
151–163 ↗	(On Diff #16475)	Ah, you may be right. Sorry, I'm not so familiar with Rust...

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

26 lines

Diff 16448

services/backup/blob_client/src/get_client.rs

Loading...