Added new action to send edit messages.
Details
Details
Checked if the app still works. Other tests are in later diffs.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/types/redux-types.js | ||
|---|---|---|
| 566–570 | Flow has an issue where it doesn't recognize that this is an invalid type. Here we are saying that the type is BOTH Error and an exact object type having only three keys: threadID, targetMessageID, and text. That should be impossible because the first type implies other keys should exist. We can maybe address this by making the second type "inexact" | |
| lib/types/redux-types.js | ||
|---|---|---|
| 567–569 | Why do we need these? Do we use them in the reducer? | |
Comment Actions
Change type to inexact
| lib/types/redux-types.js | ||
|---|---|---|
| 567–569 | We don't need it now. But in the future, when I add a state for editing mode on native & web, we will probably need that information to inform the user about editing failure. | |
| lib/types/redux-types.js | ||
|---|---|---|
| 567–569 | We need more detail than this. I don't understand why it's necessary. It's generally possible to inform users about editing failures without need things in Redux. We only do this for other message types when we need messageStore.local to get updated, but it's not clear to me that you need that. In general, you should understand 100% of the code you are submitting and why. If you aren't sure yet how this is going to be used, then you should not introduce it now. When you have the context to explain how / why it's going to be used, that's when you can introduce it. | |
| lib/types/message-types.js | ||
|---|---|---|
| 575 ↗ | (On Diff #24274) | Not sure we need this type alias, but I don't feel strongly |