Page MenuHomePhabricator
Differential D8896

[web][native] Rename usernamePrefix to textPrefix in TypeaheadMatchedStrings type
ClosedPublic
Actions

Authored by • patryk on Aug 22 2023, 1:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 3:45 PM
Unknown Object (File)
Wed, Mar 19, 2:20 PM
Unknown Object (File)
Mon, Mar 17, 3:35 AM
Unknown Object (File)
Mon, Mar 17, 3:35 AM
Unknown Object (File)
Mon, Mar 17, 3:35 AM
Unknown Object (File)
Mon, Mar 17, 3:35 AM
Unknown Object (File)
Mon, Mar 17, 3:32 AM
Unknown Object (File)
Thu, Mar 13, 12:15 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMM9ad8cc20c046: [web][native] Rename usernamePrefix to textPrefix in TypeaheadMatchedStrings…
Summary

This diff renames usernamePrefix to textPrefix in TypeaheadMatchedStrings type. Since we will show chats in mention typeahead tooltip, it is necessary to rename utilities to make code more generic.

Depends on D8853, D8849.

Test Plan

Check if TypeaheadTooltip works properly both on native and web.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Aug 22 2023, 1:55 AM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 1:55 AM
• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 2:10 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka.
Harbormaster completed remote builds in B21978: Diff 30180.Aug 22 2023, 2:12 AM
• patryk added a child revision: D8897: [native] Refactor TypeaheadTooltip component.Aug 22 2023, 2:29 AM
• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 3:45 AM
• patryk added parent revisions: D8853: [web] Add chat mention rule to text message rules, D8849: [native] Add chat mention rule to text message rules.
• patryk added a reviewer: rohan.Aug 22 2023, 5:37 AM
• patryk published this revision for review.Aug 22 2023, 8:37 AM
rohan accepted this revision.Aug 24 2023, 7:13 AM
This revision is now accepted and ready to land.Aug 24 2023, 7:13 AM
tomek requested changes to this revision.Sep 12 2023, 7:01 AM
tomek added inline comments.
lib/shared/mention-utils.js
18

This name might be confusing - it isn't clear what is text in this context, especially because this is different than in the other prop. Maybe query, match, mathPrefix, or something else would be less confusing?

This revision now requires changes to proceed.Sep 12 2023, 7:01 AM
• patryk updated this revision to Diff 31248.Sep 19 2023, 2:04 AM

Rename textPrefix to query

Harbormaster completed remote builds in B22712: Diff 31248.Sep 19 2023, 2:21 AM
tomek accepted this revision.Sep 19 2023, 9:04 AM
This revision is now accepted and ready to land.Sep 19 2023, 9:04 AM
Closed by commit rCOMM9ad8cc20c046: [web][native] Rename usernamePrefix to textPrefix in TypeaheadMatchedStrings… (authored by • patryk). · Explain WhySep 28 2023, 2:19 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM9ad8cc20c046: [web][native] Rename usernamePrefix to textPrefix in TypeaheadMatchedStrings….

Revision Contents
Changeset List

PathSize
lib/
shared/
2 lines
native/
chat/
4 lines
6 lines
web/
chat/
4 lines
6 lines
utils/
6 lines

Diff 30180

View Options

lib/shared/mention-utils.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };
View Options

native/chat/chat-input-bar.react.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };
View Options

native/chat/typeahead-tooltip.react.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };
View Options

web/chat/chat-input-bar.react.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };
View Options

web/chat/typeahead-tooltip.react.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };
View Options

web/utils/typeahead-utils.js

Loading...