Details
Details
- Reviewers
tomek inka rohan - Commits
- rCOMMa57f943a5679: [lib] Introduce SentencePrefixSearchIndex
Tested later in the stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
lib/shared/sentence-prefix-search-index.js | ||
---|---|---|
10 ↗ | (On Diff #30193) | new Tokenizer().words() removes punctuation from keywords, chat names can include them so we need to keep them. |
13–19 ↗ | (On Diff #30193) | How does this work? Rather than storing kewords, we store whole prefixes. Let's take "test chat" name as an example. SearchIndex would store only keywords prefixes:
Using this approach would eventually hide our typeahead tooltip when user would press the space and that's not what we want while typing chat name in input bar while mentioning. New SearchIndex entries look like this:
|