Paths

Table of Contentst

Differential D7756

[landing] introduce colors from design system
ClosedPublic
Actions

Authored by ginsu on May 9 2023, 5:40 AM.

Tags

None

Referenced Files

	F3409332: D7756.id26287.diff
	Wed, Dec 4, 3:48 PM

	F3409291: D7756.id29714.diff
	Wed, Dec 4, 3:36 PM

	F3409078: D7756.id29637.diff
	Wed, Dec 4, 2:53 PM

	F3408993: D7756.id26521.diff
	Wed, Dec 4, 2:41 PM

	F3407617: D7756.diff
	Wed, Dec 4, 7:01 AM

	Unknown Object (File)
	Sun, Nov 17, 2:19 AM

	Unknown Object (File)
	Sun, Nov 17, 1:37 AM

	Unknown Object (File)
	Sun, Nov 17, 1:37 AM

View All 90 Files

Subscribers

Details

Reviewers

atul
kamil

Commits

rCOMM51ba93506fa3: [landing] introduce colors from design system

Summary

This diff introduces all the colors in Ted's new color design system. For this diff I decided to just add the colors and leave the other variables in for now just so I don't cause any regressions I may be unaware about. As I keep working on the landing page, I will slowly phase out and get rid of any unused colors/variables. One thing to note is that this diff does not include black-95. I was instructed by Ted not to include this since this color is only used in the nav sidebar and Ted said that he just put it in here to record it, but will eventually figure out a better place for that color

Links to color design system:
https://www.figma.com/file/fwKJ6eNgfxlx8a7WxSyAZL/2023-Design-System?node-id=1-427&t=ds82zlYncjLEbFB9-4

Link to landing page specific colors:
https://www.figma.com/file/HAAQwcEIjM32gnEMy2d0k5/Comm-%2F-Landing?node-id=3263-41925&t=EVfPbbD9hMG9rkrB-4

Depends on D7755

Test Plan

Had ted double check this, and got his stamp of approval

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 9 2023, 5:40 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 9 2023, 5:40 AM

ginsu edited the summary of this revision. (Show Details)May 9 2023, 5:48 AM

ginsu added reviewers: atul, kamil.

ginsu edited the summary of this revision. (Show Details)May 9 2023, 5:58 AM

ginsu added a parent revision: D7755: [landing] introduce new typography design system.

ginsu added a child revision: D7757: [landing] remove star background.

Harbormaster completed remote builds in B19196: Diff 26287.May 9 2023, 5:58 AM

ginsu requested review of this revision.May 9 2023, 5:58 AM

atul accepted this revision.May 10 2023, 5:23 AM

This revision is now accepted and ready to land.May 10 2023, 5:23 AM

atul added inline comments.May 10 2023, 5:24 AM

landing/global.css
37	This name seems like it might be a little too general?

ginsu added inline comments.May 10 2023, 8:51 AM

landing/global.css
37	This should be an easy fix, I'll talk to Ted about this just so everyone is aware/aligned

address comments

ginsu added a subscriber: • ted.May 16 2023, 5:02 AM

ginsu added inline comments.

landing/global.css
37–38 ↗	(On Diff #26521)	@ted I updated these names in the figma too, so everything should be in sync

Harbormaster completed remote builds in B19386: Diff 26521.May 16 2023, 5:22 AM

rebase before landing

Harbormaster completed remote builds in B21597: Diff 29637.Aug 8 2023, 12:14 PM

Closed by commit rCOMM51ba93506fa3: [landing] introduce colors from design system (authored by ginsu). · Explain WhyAug 8 2023, 2:07 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM51ba93506fa3: [landing] introduce colors from design system.

Revision Contents
Changeset List

Path

Size

landing/

28 lines

Diff 26287

landing/global.css

Loading...