Page MenuHomePhabricator
Differential D7898

[landing] minor improvements to mobile nav ui
ClosedPublic
Actions

Authored by ginsu on May 21 2023, 1:44 AM.
Tags
None
Referenced Files
F3409030: D7898.id26725.diff
Wed, Dec 4, 2:47 PM
F3408944: D7898.id29726.diff
Wed, Dec 4, 2:32 PM
F3408902: D7898.id29649.diff
Wed, Dec 4, 2:22 PM
F3407394: D7898.diff
Wed, Dec 4, 5:57 AM
Unknown Object (File)
Sun, Nov 17, 2:19 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
View All 74 Files
Subscribers
ashoat
atul
• ted
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM051ae704241d: [landing] minor improvements to mobile nav ui
Summary

Earlier this week, I synced with @ted and we went over the whole header/mobile nav together, and we talked about some minor UI improvements we could make. This diff addresses those improvements. The improvements that were made were:

  1. Increase the horizontal padding in the MobileNav so it lined up better with the header
  2. When a user hovered over the tabs or icons in the MobileNav we should show a lighter white

Depends on D7871

Test Plan

Please watch the demo video below:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 21 2023, 1:44 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 21 2023, 1:44 AM
ginsu edited the summary of this revision. (Show Details)May 21 2023, 1:49 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F548647: Screen Recording 2023-05-21 at 11.48.58 AM.mov. (Show Details)
Harbormaster completed remote builds in B19544: Diff 26725.May 21 2023, 2:02 AM
ginsu requested review of this revision.May 21 2023, 2:02 AM
ginsu added a child revision: D7911: [landing] change text content on HeroContent component.May 22 2023, 6:49 AM
ginsu edited the summary of this revision. (Show Details)May 22 2023, 6:56 AM
ginsu added a parent revision: D7871: [landing] fix mobile nav bar peeking into screen when quickly resizing window.
atul accepted this revision.May 22 2023, 8:21 AM
This revision is now accepted and ready to land.May 22 2023, 8:21 AM
ginsu updated this revision to Diff 29649.Aug 8 2023, 12:09 PM
ginsu edited the summary of this revision. (Show Details)

rebase before landing

Harbormaster completed remote builds in B21609: Diff 29649.Aug 8 2023, 12:39 PM
Closed by commit rCOMM051ae704241d: [landing] minor improvements to mobile nav ui (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM051ae704241d: [landing] minor improvements to mobile nav ui.

Revision Contents
Changeset List

PathSize
landing/
6 lines

Diff 26725

View Options

landing/mobile-nav.css

Loading...