[landing] add faq section and request access section to keyserver page
ClosedPublic
Actions

Authored by ginsu on Jun 6 2023, 12:02 PM.

Details

Reviewers

atul
kamil

Commits

rCOMM0e96cab48995: [landing] add faq section and request access section to keyserver page

Summary

This diff adds all the necessary sections to match the design for the keyserver page. I still need to make a few cosmetic changes to the color/typography in the top section of the page, but a subsequent diff is going to handle this

Depends on D8128

Test Plan

Please see the demo video below:

Diff Detail

Repository

rCOMM Comm

Branch

eng-3423 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jun 6 2023, 12:02 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2023, 12:02 PM

ginsu edited the summary of this revision. (Show Details)Jun 6 2023, 12:04 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8128: [landing] add rotation animation to keyserver faq icon.

ginsu attached a referenced file: F574410: Screen Recording 2023-06-06 at 2.58.47 PM.mov. (Show Details)

ginsu published this revision for review.Jun 6 2023, 12:08 PM

Harbormaster completed remote builds in B20073: Diff 27504.Jun 6 2023, 12:20 PM

Accepting, but please take a look at the trailing space

landing/keyservers.react.js
124	Do we want this trailing space character?

This revision is now accepted and ready to land.Jun 7 2023, 12:33 PM

address comments

Harbormaster completed remote builds in B20146: Diff 27596.Jun 9 2023, 12:56 PM

ginsu added a child revision: D8165: [landing] redesign keyserver company section on keyserver page.Jun 9 2023, 1:15 PM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM

Closed by commit rCOMM0e96cab48995: [landing] add faq section and request access section to keyserver page (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM0e96cab48995: [landing] add faq section and request access section to keyserver page.

Harbormaster completed remote builds in B21649: Diff 29695.Aug 8 2023, 2:38 PM

Revision Contents
Changeset List

Path

Size

landing/

keyservers.react.js

136 lines

Diff 27504

View Options

landing/keyservers.react.js

[landing] add faq section and request access section to keyserver pageClosedPublicActions