Differential D8174

[landing] fix investor card description container height
ClosedPublic
Actions

Authored by ginsu on Jun 9 2023, 3:13 PM.

Tags

None

Referenced Files

	F3407143: D8174.id.diff
	Wed, Dec 4, 4:12 AM

	F3406610: D8174.id27625.diff
	Wed, Dec 4, 2:31 AM

	F3406609: D8174.id27624.diff
	Wed, Dec 4, 2:31 AM

	F3406608: D8174.diff
	Wed, Dec 4, 2:31 AM

	Unknown Object (File)
	Sun, Dec 1, 1:13 AM

	Unknown Object (File)
	Thu, Nov 28, 12:13 AM

	Unknown Object (File)
	Sun, Nov 17, 2:18 AM

	Unknown Object (File)
	Sun, Nov 17, 1:40 AM

Subscribers

Details

Reviewers

atul
kamil

Commits

rCOMM7a3c6bc035ac: [landing] fix investor card description container height

Summary

I actually did find a small bug with the investor card height. The height was still 56px, but when we decreased the font size/line height this 56px was too big. This diff fixes this bug by making the value of the height dynamically change as well based on the screen width. To determine these clamp values the same strategy from D8173 was used here.

Depends on D8173

Test Plan

Please see the before and after

Before:

Screenshot 2023-06-09 at 6.09.18 PM.png (898×942 px, 108 KB)

After:

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jun 9 2023, 3:13 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 9 2023, 3:13 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 9 2023, 3:16 PM

Harbormaster failed remote builds in B20165: Diff 27624!

ginsu edited the summary of this revision. (Show Details)Jun 9 2023, 3:17 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8173: [landing] make typography responsive.

ginsu attached a referenced file: F581457: Screen Recording 2023-06-09 at 6.16.37 PM.mov. (Show Details)

ginsu attached a referenced file: F581456: Screenshot 2023-06-09 at 6.09.18 PM.png. (Show Details)

fix comment

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 9 2023, 3:27 PM

Harbormaster failed remote builds in B20166: Diff 27625!

ginsu added a child revision: D8175: [landing] fix the scroll to top behavior and animation on keyserver page.Jun 9 2023, 3:27 PM

Harbormaster completed remote builds in B20166: Diff 27625.Jun 9 2023, 3:44 PM

ginsu requested review of this revision.Jun 9 2023, 3:44 PM

atul accepted this revision.Jun 12 2023, 7:38 AM

This revision is now accepted and ready to land.Jun 12 2023, 7:38 AM

Harbormaster completed remote builds in B20165: Diff 27624.Jun 12 2023, 9:33 AM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM

Closed by commit rCOMM7a3c6bc035ac: [landing] fix investor card description container height (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM7a3c6bc035ac: [landing] fix investor card description container height.

Harbormaster completed remote builds in B21660: Diff 29706.Aug 8 2023, 3:09 PM

Revision Contents
Changeset List

Path

Size

landing/

investor-profile.css

3 lines

Diff 27625

landing/investor-profile.css

Loading...