Page MenuHomePhabricator
Differential D8175

[landing] fix the scroll to top behavior and animation on keyserver page
ClosedPublic
Actions

Authored by ginsu on Jun 9 2023, 3:26 PM.
Tags
None
Referenced Files
F3407366: D8175.diff
Wed, Dec 4, 5:50 AM
F3406613: D8175.id27626.diff
Wed, Dec 4, 2:31 AM
F3406612: D8175.id.diff
Wed, Dec 4, 2:31 AM
F3406611: D8175.diff
Wed, Dec 4, 2:31 AM
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
Unknown Object (File)
Sun, Nov 17, 1:40 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM3b193a7511ab: [landing] fix the scroll to top behavior and animation on keyserver page
Summary

This diff fixes both the scroll to top behavior and the animations on the keyserver page. The overflow property here was causing issues with the scroll behavoir (which is why the scroll animation and the scroll to top was not working)

Depends on D8174

Test Plan

Please see the demo videos below to see that both things now work

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 9 2023, 3:26 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 9 2023, 3:26 PM
ginsu edited the summary of this revision. (Show Details)Jun 9 2023, 3:27 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a parent revision: D8174: [landing] fix investor card description container height.
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F581523: Screen Recording 2023-06-09 at 6.26.53 PM.mov. (Show Details)
ginsu mentioned this in D8176: [landing] fix size prop for icons in mobile nav.Jun 9 2023, 3:37 PM
ginsu added a child revision: D8176: [landing] fix size prop for icons in mobile nav.Jun 9 2023, 3:38 PM
Harbormaster completed remote builds in B20167: Diff 27626.Jun 9 2023, 3:43 PM
ginsu requested review of this revision.Jun 9 2023, 3:43 PM
atul accepted this revision.Jun 12 2023, 7:38 AM
This revision is now accepted and ready to land.Jun 12 2023, 7:38 AM
ginsu mentioned this in D8480: [landing] fix body scrolling when modal is active.Jul 11 2023, 3:52 PM
ginsu updated this revision to Diff 29708.Aug 8 2023, 12:55 PM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
Closed by commit rCOMM3b193a7511ab: [landing] fix the scroll to top behavior and animation on keyserver page (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM3b193a7511ab: [landing] fix the scroll to top behavior and animation on keyserver page.
ginsu mentioned this in rCOMMd1bdf88145aa: [landing] fix body scrolling when modal is active.
Harbormaster completed remote builds in B21662: Diff 29708.Aug 8 2023, 3:16 PM

Revision Contents
Changeset List

PathSize
landing/
4 lines

Diff 27626

View Options

landing/landing.css

Loading...