Page MenuHomePhabricator
Differential D8077

[landing] move hero section code into own component
ClosedPublic
Actions

Authored by ginsu on Jun 2 2023, 11:57 AM.
Tags
None
Referenced Files
F3407393: D8077.diff
Wed, Dec 4, 5:56 AM
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
Unknown Object (File)
Oct 18 2024, 11:41 PM
View All 83 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMb9ddbcc47370: [landing] move hero section code into own component
Summary

Simple move diff. All other sections in AppLanding will be put in their own component so I figured it would be good to have one for the hero as well.

Depends on D8076

Test Plan

Double checked that the hero section still looked and behaved as it did previously

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 2 2023, 11:57 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2023, 11:57 AM
ginsu edited the summary of this revision. (Show Details)Jun 2 2023, 12:00 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8076: [landing] introduce glow effect for hero image.
ginsu updated this revision to Diff 27413.Jun 2 2023, 12:03 PM

fix merge conflict I missed

Harbormaster failed remote builds in B19995: Diff 27412!Jun 2 2023, 12:11 PM
ginsu added a child revision: D8078: [landing] introduce new assetMetaData.Jun 2 2023, 12:14 PM
Harbormaster completed remote builds in B19996: Diff 27413.Jun 2 2023, 12:19 PM
ginsu requested review of this revision.Jun 2 2023, 12:19 PM
atul accepted this revision.Jun 2 2023, 12:22 PM

Looks like a straightforward move

This revision is now accepted and ready to land.Jun 2 2023, 12:22 PM
ginsu updated this revision to Diff 29683.Aug 8 2023, 12:32 PM

rebase before landing

Harbormaster completed remote builds in B21637: Diff 29683.Aug 8 2023, 2:01 PM
Closed by commit rCOMMb9ddbcc47370: [landing] move hero section code into own component (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb9ddbcc47370: [landing] move hero section code into own component.

Revision Contents
Changeset List

PathSize
landing/
14 lines
hero.css
landing.css
28 lines
30 lines
71 lines

Diff 29683

View Options

landing/app-landing.react.js

Loading...
View Options

landing/hero.css

Loading...
View Options

landing/hero.react.js

Loading...
View Options

landing/landing.css

Loading...