Page MenuHomePhabricator
Differential D8079

[landing] repurpose InfoBlock component
ClosedPublic
Actions

Authored by ginsu on Jun 2 2023, 12:44 PM.
Tags
None
Referenced Files
F3406279: D8079.diff
Wed, Dec 4, 1:17 AM
Unknown Object (File)
Mon, Dec 2, 10:28 PM
Unknown Object (File)
Sat, Nov 30, 10:57 AM
Unknown Object (File)
Sun, Nov 24, 11:28 AM
Unknown Object (File)
Sun, Nov 17, 2:18 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
Unknown Object (File)
Sun, Nov 17, 1:38 AM
View All 98 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMe917432ea51a: [landing] repurpose InfoBlock component
Summary

This diff repurposes the InfoBlock component to work for this landing page redesign. A big change with this InfoBlock component is that we no longer need an image, and all the content in the InfoBlock is centered. Here is a screenshot of the designs for extra context:

Screenshot 2023-06-02 at 3.47.19 PM.png (1×3 px, 1 MB)

Screenshot 2023-06-02 at 3.47.14 PM.png (1×3 px, 1 MB)

Depends on D8078

Test Plan

Please see the demo videos/screenshots below to see how the new InfoBlock component:

Desktop/Responsive:

Tablet:

Screenshot 2023-06-02 at 3.41.06 PM.png (2×3 px, 972 KB)

Mobile:

Screenshot 2023-06-02 at 3.40.59 PM.png (2×3 px, 971 KB)

Screenshot 2023-06-02 at 3.49.45 PM.png (2×3 px, 937 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 2 2023, 12:44 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2023, 12:44 PM
ginsu edited the summary of this revision. (Show Details)Jun 2 2023, 12:49 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8078: [landing] introduce new assetMetaData.
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F569832: Screenshot 2023-06-02 at 3.49.45 PM.png. (Show Details)
ginsu attached a referenced file: F569827: Screenshot 2023-06-02 at 3.40.59 PM.png. (Show Details)
ginsu attached a referenced file: F569826: Screenshot 2023-06-02 at 3.41.06 PM.png. (Show Details)
ginsu attached a referenced file: F569811: Screen Recording 2023-06-02 at 3.39.28 PM.mov. (Show Details)
ginsu attached a referenced file: F569824: Screenshot 2023-06-02 at 3.47.14 PM.png. (Show Details)
ginsu attached a referenced file: F569825: Screenshot 2023-06-02 at 3.47.19 PM.png. (Show Details)
Harbormaster completed remote builds in B19999: Diff 27416.Jun 2 2023, 1:03 PM
ginsu requested review of this revision.Jun 2 2023, 1:03 PM
ginsu added a child revision: D8080: [landing] introduce request access compoonent.Jun 2 2023, 1:07 PM
ginsu added inline comments.Jun 2 2023, 2:03 PM
landing/info-block.css
13–16 ↗(On Diff #27416)

We talked about using these styles already in D7911

atul accepted this revision.Jun 2 2023, 3:09 PM
This revision is now accepted and ready to land.Jun 2 2023, 3:09 PM
ginsu updated this revision to Diff 29599.Aug 7 2023, 1:36 PM

rebase

Harbormaster completed remote builds in B21575: Diff 29599.Aug 7 2023, 1:55 PM
ginsu updated this revision to Diff 29685.Aug 8 2023, 12:32 PM

rebase before landing

Harbormaster completed remote builds in B21639: Diff 29685.Aug 8 2023, 2:08 PM
Closed by commit rCOMMe917432ea51a: [landing] repurpose InfoBlock component (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe917432ea51a: [landing] repurpose InfoBlock component.

Revision Contents
Changeset List

PathSize
landing/
56 lines
68 lines

Diff 29685

View Options

landing/info-block.css

Loading...
View Options

landing/info-block.react.js

Loading...