Page MenuHomePhabricator
Differential D8165

[landing] redesign keyserver company section on keyserver page
ClosedPublic
Actions

Authored by ginsu on Jun 9 2023, 1:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 1:28 PM
Unknown Object (File)
Sat, Mar 22, 3:33 PM
Unknown Object (File)
Sun, Mar 16, 8:49 AM
Unknown Object (File)
Wed, Feb 26, 4:24 AM
Unknown Object (File)
Feb 25 2025, 4:31 AM
Unknown Object (File)
Feb 25 2025, 4:31 AM
Unknown Object (File)
Feb 23 2025, 12:39 AM
Unknown Object (File)
Feb 20 2025, 4:27 AM
View All 98 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM6678f515ba41: [landing] redesign keyserver company section on keyserver page
Summary

This diff updates the UI for the last section of the keyserver page to match the figma designs. Subsequent diffs will address the other sections. Here is the design for refernece:

Screenshot 2023-06-09 at 4.11.26 PM.png (1×3 px, 1 MB)

Depends on D8132

Test Plan

Please view the demo videos/screenshot

Desktop/Responsive:

Tablet:

Screenshot 2023-06-09 at 4.13.06 PM.png (2×3 px, 941 KB)

Mobile:

Screenshot 2023-06-09 at 4.13.12 PM.png (2×3 px, 957 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 9 2023, 1:07 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 9 2023, 1:07 PM
ginsu edited the summary of this revision. (Show Details)Jun 9 2023, 1:13 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F580568: Screenshot 2023-06-09 at 4.13.12 PM.png. (Show Details)
ginsu attached a referenced file: F580567: Screenshot 2023-06-09 at 4.13.06 PM.png. (Show Details)
ginsu attached a referenced file: F580560: Screen Recording 2023-06-09 at 4.12.08 PM.mov. (Show Details)
ginsu attached a referenced file: F580559: Screenshot 2023-06-09 at 4.11.26 PM.png. (Show Details)
ginsu added inline comments.
landing/keyservers.css
21–27 ↗(On Diff #27599)

These classes will be removed when all the sections have been updated

39–42 ↗(On Diff #27599)

We talked about using these styles already in D7911

ginsu published this revision for review.Jun 9 2023, 1:14 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D8132: [landing] add faq section and request access section to keyserver page.
ginsu added a child revision: D8166: [landing] redesign servers section on keyserver page.Jun 9 2023, 1:21 PM
Harbormaster completed remote builds in B20149: Diff 27599.Jun 9 2023, 1:27 PM
kamil accepted this revision.Jun 12 2023, 2:25 AM
kamil added inline comments.
landing/keyservers.css
38 ↗(On Diff #27599)

why do we still stick to snake case?

This revision is now accepted and ready to land.Jun 12 2023, 2:25 AM
kamil added inline comments.Jun 12 2023, 2:26 AM
landing/keyservers.css
38 ↗(On Diff #27599)

ahh sorry, I see D8168

ginsu updated this revision to Diff 29696.Aug 8 2023, 12:48 PM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM
Closed by commit rCOMM6678f515ba41: [landing] redesign keyserver company section on keyserver page (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6678f515ba41: [landing] redesign keyserver company section on keyserver page.
Harbormaster completed remote builds in B21650: Diff 29696.Aug 8 2023, 2:39 PM

Revision Contents
Changeset List

PathSize
landing/
86 lines
56 lines
4 lines

Diff 29696

View Options

landing/keyservers.css

// @flow // @flow
import type { Shape } from 'lib/types/core.js';
import type { ServerThreadInfo } from 'lib/types/thread-types.js'; import type { ServerThreadInfo } from 'lib/types/thread-types.js';
import { updateTypes } from 'lib/types/update-types-enum.js'; import { updateTypes } from 'lib/types/update-types-enum.js';
import { type UpdateData } from 'lib/types/update-types.js'; import { type UpdateData } from 'lib/types/update-types.js';
import { endScript } from './utils.js'; import { endScript } from './utils.js';
import { createUpdates } from '../creators/update-creator.js'; import { createUpdates } from '../creators/update-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
Show All 12 Lines try {
await mergeUsers('7147', '15972', { username: true, password: true }); await mergeUsers('7147', '15972', { username: true, password: true });
endScript(); endScript();
} catch (e) { } catch (e) {
endScript(); endScript();
console.warn(e); console.warn(e);
} }
} }
type ReplaceUserInfo = Shape<{ type ReplaceUserInfo = Partial<{
+username: boolean, +username: boolean,
+password: boolean, +password: boolean,
}>; }>;
async function mergeUsers( async function mergeUsers(
fromUserID: string, fromUserID: string,
toUserID: string, toUserID: string,
replaceUserInfo?: ReplaceUserInfo, replaceUserInfo?: ReplaceUserInfo,
) { ) {
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines
View Options

landing/keyservers.react.js

// @flow // @flow
import type { Shape } from 'lib/types/core.js';
import type { ServerThreadInfo } from 'lib/types/thread-types.js'; import type { ServerThreadInfo } from 'lib/types/thread-types.js';
import { updateTypes } from 'lib/types/update-types-enum.js'; import { updateTypes } from 'lib/types/update-types-enum.js';
import { type UpdateData } from 'lib/types/update-types.js'; import { type UpdateData } from 'lib/types/update-types.js';
import { endScript } from './utils.js'; import { endScript } from './utils.js';
import { createUpdates } from '../creators/update-creator.js'; import { createUpdates } from '../creators/update-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
Show All 12 Lines try {
await mergeUsers('7147', '15972', { username: true, password: true }); await mergeUsers('7147', '15972', { username: true, password: true });
endScript(); endScript();
} catch (e) { } catch (e) {
endScript(); endScript();
console.warn(e); console.warn(e);
} }
} }
type ReplaceUserInfo = Shape<{ type ReplaceUserInfo = Partial<{
+username: boolean, +username: boolean,
+password: boolean, +password: boolean,
}>; }>;
async function mergeUsers( async function mergeUsers(
fromUserID: string, fromUserID: string,
toUserID: string, toUserID: string,
replaceUserInfo?: ReplaceUserInfo, replaceUserInfo?: ReplaceUserInfo,
) { ) {
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines
View Options

landing/read-docs-btn.css

// @flow // @flow
import type { Shape } from 'lib/types/core.js';
import type { ServerThreadInfo } from 'lib/types/thread-types.js'; import type { ServerThreadInfo } from 'lib/types/thread-types.js';
import { updateTypes } from 'lib/types/update-types-enum.js'; import { updateTypes } from 'lib/types/update-types-enum.js';
import { type UpdateData } from 'lib/types/update-types.js'; import { type UpdateData } from 'lib/types/update-types.js';
import { endScript } from './utils.js'; import { endScript } from './utils.js';
import { createUpdates } from '../creators/update-creator.js'; import { createUpdates } from '../creators/update-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
Show All 12 Lines try {
await mergeUsers('7147', '15972', { username: true, password: true }); await mergeUsers('7147', '15972', { username: true, password: true });
endScript(); endScript();
} catch (e) { } catch (e) {
endScript(); endScript();
console.warn(e); console.warn(e);
} }
} }
type ReplaceUserInfo = Shape<{ type ReplaceUserInfo = Partial<{
+username: boolean, +username: boolean,
+password: boolean, +password: boolean,
}>; }>;
async function mergeUsers( async function mergeUsers(
fromUserID: string, fromUserID: string,
toUserID: string, toUserID: string,
replaceUserInfo?: ReplaceUserInfo, replaceUserInfo?: ReplaceUserInfo,
) { ) {
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines