Page MenuHomePhabricator
Differential D7757

[landing] remove star background
ClosedPublic
Actions

Authored by ginsu on May 9 2023, 5:55 AM.
Tags
None
Referenced Files
F3409303: D7757.id26289.diff
Wed, Dec 4, 3:39 PM
F3409276: D7757.id29715.diff
Wed, Dec 4, 3:30 PM
F3409089: D7757.id29638.diff
Wed, Dec 4, 2:55 PM
F3407612: D7757.diff
Wed, Dec 4, 6:58 AM
F3407257: D7757.diff
Wed, Dec 4, 5:12 AM
F3405385: D7757.id26289.diff
Tue, Dec 3, 8:42 PM
F3405384: D7757.id.diff
Tue, Dec 3, 8:42 PM
Unknown Object (File)
Sun, Nov 17, 2:19 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM934fbffbc364: [landing] remove star background
Summary

For the redesign of the landing page we are going to use a blackish background. The first step to achieve this is to remove the stars background which is what this diff does

Depends on D7756

Test Plan

The two pages with the stars background animation (app-landing and keyserver) now have just a static background:

Screenshot 2023-05-09 at 2.50.23 PM.png (2×3 px, 2 MB)

Screenshot 2023-05-09 at 2.50.30 PM.png (2×3 px, 2 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.May 9 2023, 5:55 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 9 2023, 5:55 AM
ginsu edited the test plan for this revision. (Show Details)May 9 2023, 5:56 AM
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F529902: Screenshot 2023-05-09 at 2.50.30 PM.png. (Show Details)
ginsu attached a referenced file: F529879: Screenshot 2023-05-09 at 2.50.23 PM.png. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu edited the summary of this revision. (Show Details)May 9 2023, 5:58 AM
ginsu added a parent revision: D7756: [landing] introduce colors from design system.
Harbormaster completed remote builds in B19198: Diff 26289.May 9 2023, 6:16 AM
ginsu requested review of this revision.May 9 2023, 6:16 AM
ginsu added a child revision: D7759: [landing] update landing background color.May 9 2023, 6:24 AM
atul accepted this revision.May 10 2023, 5:17 AM
This revision is now accepted and ready to land.May 10 2023, 5:17 AM
ginsu updated this revision to Diff 29638.Aug 8 2023, 11:57 AM

rebase before landing

Harbormaster completed remote builds in B21598: Diff 29638.Aug 8 2023, 12:17 PM
Closed by commit rCOMM934fbffbc364: [landing] remove star background (authored by ginsu). · Explain WhyAug 8 2023, 2:07 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM934fbffbc364: [landing] remove star background.

Revision Contents
Changeset List

Diff 29715

View Options

landing/app-landing.react.js

Loading...
View Options

landing/keyservers.react.js

Loading...
View Options

landing/star-background.css

Loading...
View Options

landing/star-background.react.js

Loading...