Page MenuHomePhabricator
Differential D7869

[landing] show close icon when mobile nav is active
ClosedPublic
Actions

Authored by ginsu on May 19 2023, 4:47 AM.
Tags
None
Referenced Files
F3408948: D7869.id29646.diff
Wed, Dec 4, 2:33 PM
F3408865: D7869.id29723.diff
Wed, Dec 4, 2:12 PM
F3407412: D7869.diff
Wed, Dec 4, 6:04 AM
Unknown Object (File)
Sun, Nov 17, 2:19 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Unknown Object (File)
Sat, Nov 16, 11:27 PM
View All 76 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMf4fd228b7c06: [landing] show close icon when mobile nav is active
Summary

This is the last diff that updates the header component. This diff changes the hamburger menu icon to a close icon depending if the mobile nav is active or not.

Depends on D7868

Test Plan

Please see the screenshots below:

When the mobile nav is not active:

Screenshot 2023-05-19 at 2.47.58 PM.png (2×1 px, 1 MB)

When the mobile nav is active:

Screenshot 2023-05-19 at 2.48.00 PM.png (2×1 px, 554 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.May 19 2023, 4:47 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 19 2023, 4:47 AM
ginsu edited the summary of this revision. (Show Details)May 19 2023, 4:50 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D7868: [landing] implement on click functions in header.
ginsu attached a referenced file: F545333: Screenshot 2023-05-19 at 2.48.00 PM.png. (Show Details)
ginsu attached a referenced file: F545332: Screenshot 2023-05-19 at 2.47.58 PM.png. (Show Details)
Harbormaster completed remote builds in B19501: Diff 26666.May 19 2023, 5:05 AM
ginsu requested review of this revision.May 19 2023, 5:05 AM
ginsu added a child revision: D7870: [landing] fix mobile nav still being shown when window resizes.May 19 2023, 5:09 AM
atul accepted this revision.May 19 2023, 10:50 AM
This revision is now accepted and ready to land.May 19 2023, 10:50 AM
ginsu updated this revision to Diff 29646.Aug 8 2023, 12:07 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

Harbormaster completed remote builds in B21606: Diff 29646.Aug 8 2023, 12:30 PM
Closed by commit rCOMMf4fd228b7c06: [landing] show close icon when mobile nav is active (authored by ginsu). · Explain WhyAug 8 2023, 2:07 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMf4fd228b7c06: [landing] show close icon when mobile nav is active.

Revision Contents
Changeset List

PathSize
landing/
12 lines

Diff 29723

View Options

landing/header.react.js

Loading...