Paths

Table of Contentst

-
landing/
-
footer.css
-
footer.react.js

[landing] redesign footer component
ClosedPublic
Actions

Authored by ginsu on Jun 2 2023, 1:55 PM.

Details

Reviewers

atul
kamil

Commits

rCOMM012eb7a550ce: [landing] redesign footer component

Summary

This is the second part to implmenenting the redesign for the footer component. This diff adds the new elments that are shown in the figma design (screenshot below) and arranges them to match the design

Screenshot 2023-06-02 at 5.02.20 PM.png (1×3 px, 2 MB)

Screenshot 2023-06-02 at 5.02.13 PM.png (1×3 px, 1 MB)

Depends on D8082

Test Plan

Please watch the demo video/see the screenshots below:

Desktop/Responsive:

Tablet:

Screenshot 2023-06-02 at 5.00.55 PM.png (2×3 px, 939 KB)

Mobile:

Screenshot 2023-06-02 at 5.01.01 PM.png (2×3 px, 900 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 2 2023, 1:55 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2023, 1:55 PM

ginsu edited the summary of this revision. (Show Details)Jun 2 2023, 2:05 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8082: [landing] remove subscription form from footer.

ginsu attached a referenced file: F570012: Screenshot 2023-06-02 at 5.01.01 PM.png. (Show Details)

ginsu attached a referenced file: F570011: Screenshot 2023-06-02 at 5.00.55 PM.png. (Show Details)

ginsu attached a referenced file: F570001: Screen Recording 2023-06-02 at 4.59.27 PM.mov. (Show Details)

ginsu attached a referenced file: F569999: Screenshot 2023-06-02 at 5.02.13 PM.png. (Show Details)

ginsu attached a referenced file: F570000: Screenshot 2023-06-02 at 5.02.20 PM.png. (Show Details)

Harbormaster completed remote builds in B20004: Diff 27421.Jun 2 2023, 2:15 PM

ginsu requested review of this revision.Jun 2 2023, 2:15 PM

ginsu added a child revision: D8092: [landing] introduce keyserver faq data.Jun 5 2023, 6:42 AM

kamil accepted this revision.Jun 6 2023, 4:05 AM

kamil added inline comments.

landing/footer.css
26 ↗	(On Diff #27421)	maybe that will make it more clear which icons it contains?
34 ↗	(On Diff #27421)	Isn't this value a bit too big? design vs demo
landing/footer.react.js
77 ↗	(On Diff #27421)	I am assuming that `arrow-up-right icon` is not available in the codebase to better match the design?
92–107 ↗	(On Diff #27421)	wondering, shouldn't those be opened in a new tab?

This revision is now accepted and ready to land.Jun 6 2023, 4:05 AM

kamil attached a referenced file: F573288: image.png. (Show Details)Jun 6 2023, 4:06 AM

kamil attached a referenced file: F573287: image.png. (Show Details)

address comments

ginsu added a subscriber: • ted.Jun 9 2023, 12:43 PM

ginsu added inline comments.

landing/footer.react.js
77 ↗	(On Diff #27421)	Yea we couldn't find a free icon that matched the design perfectly. @ted said this icon would suffice
92–107 ↗	(On Diff #27421)	This will be addressed in a subsequent diff (will link diff momentarily)

Harbormaster completed remote builds in B20147: Diff 27597.Jun 9 2023, 12:58 PM

ginsu mentioned this in D8172: [landing] make all external links open in a new tab.Jun 9 2023, 2:21 PM

ginsu added inline comments.Jun 9 2023, 2:24 PM

landing/footer.react.js
92–107 ↗	(On Diff #27421)	D8172

rebase before landing

This revision was landed with ongoing or failed builds.Aug 8 2023, 2:09 PM

Closed by commit rCOMM012eb7a550ce: [landing] redesign footer component (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM012eb7a550ce: [landing] redesign footer component.

ginsu mentioned this in rCOMM39447e4b8e94: [landing] make all external links open in a new tab.

Harbormaster completed remote builds in B21643: Diff 29689.Aug 8 2023, 2:19 PM

Revision Contents
Changeset List

Path

Size

landing/

footer.css

77 lines

footer.react.js

148 lines

Diff 29759

View Options

landing/footer.css

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 1,968 Lines • ▼ Show 20 Lines	dependencies:
"@expo/json-file" "8.2.34"		"@expo/json-file" "8.2.34"
debug "^4.3.1"		debug "^4.3.1"
expo-modules-autolinking "~0.5.1"		expo-modules-autolinking "~0.5.1"
fs-extra "^9.0.0"		fs-extra "^9.0.0"
resolve-from "^5.0.0"		resolve-from "^5.0.0"
semver "7.3.2"		semver "7.3.2"
xml2js "0.4.23"		xml2js "0.4.23"

		"@expo/react-native-action-sheet@^3.14.0":
		version "3.14.0"
		resolved "https://registry.yarnpkg.com/@expo/react-native-action-sheet/-/react-native-action-sheet-3.14.0.tgz#484781425fb31c2a76c4344cdfdbb3609509846e"
		integrity sha512-JvABIv68dyxbdXg965+K7OYDJdlJftHesqmaWGv1KF4bobbwKli4NK/zQKSltlfiI+cLxONwzBlvmx+AjlYGng==
		dependencies:
		"@types/hoist-non-react-statics" "^3.3.1"
		hoist-non-react-statics "^3.3.0"

"@expo/sdk-runtime-versions@^1.0.0":		"@expo/sdk-runtime-versions@^1.0.0":
version "1.0.0"		version "1.0.0"
resolved "https://registry.yarnpkg.com/@expo/sdk-runtime-versions/-/sdk-runtime-versions-1.0.0.tgz#d7ebd21b19f1c6b0395e50d78da4416941c57f7c"		resolved "https://registry.yarnpkg.com/@expo/sdk-runtime-versions/-/sdk-runtime-versions-1.0.0.tgz#d7ebd21b19f1c6b0395e50d78da4416941c57f7c"
integrity sha512-Doz2bfiPndXYFPMRwPyGa1k5QaKDVpY806UJj570epIiMzWaYyCtobasyfC++qfIXVb5Ocy7r3tP9d62hAQ7IQ==		integrity sha512-Doz2bfiPndXYFPMRwPyGa1k5QaKDVpY806UJj570epIiMzWaYyCtobasyfC++qfIXVb5Ocy7r3tP9d62hAQ7IQ==

"@expo/spawn-async@1.5.0":		"@expo/spawn-async@1.5.0":
version "1.5.0"		version "1.5.0"
resolved "https://registry.yarnpkg.com/@expo/spawn-async/-/spawn-async-1.5.0.tgz#799827edd8c10ef07eb1a2ff9dcfe081d596a395"		resolved "https://registry.yarnpkg.com/@expo/spawn-async/-/spawn-async-1.5.0.tgz#799827edd8c10ef07eb1a2ff9dcfe081d596a395"
▲ Show 20 Lines • Show All 18,274 Lines • Show Last 20 Lines