Page MenuHomePhabricator
Differential D8853

[web] Add chat mention rule to text message rules
ClosedPublic
Actions

Authored by • patryk on Aug 17 2023, 10:29 AM.
Tags
None
Referenced Files
F3390508: D8853.diff
Sat, Nov 30, 12:13 AM
Unknown Object (File)
Tue, Nov 26, 9:38 PM
Unknown Object (File)
Tue, Nov 26, 8:29 PM
Unknown Object (File)
Tue, Nov 26, 7:30 PM
Unknown Object (File)
Sat, Nov 9, 5:26 PM
Unknown Object (File)
Sat, Nov 9, 4:59 PM
Unknown Object (File)
Sat, Nov 9, 4:58 PM
Unknown Object (File)
Sat, Nov 9, 4:40 PM
View All 94 Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMM70c89fb76aaf: [web] Add chat mention rule to text message rules
Summary

This diff adds chat mention rule to markdown rules file. Raw chat mentions should be replaced with MarkdownChatMention component.

Depends on D8876.

Test Plan

Please see test plans in diffs listed below:

Diff Detail

Repository
rCOMM Comm
Branch
patryk/chat-mention-web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Aug 17 2023, 10:29 AM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 10:29 AM
Harbormaster completed remote builds in B21863: Diff 30037.Aug 17 2023, 11:03 AM
• patryk edited the summary of this revision. (Show Details)Aug 19 2023, 3:38 PM
• patryk added a parent revision: D8876: [web] Inherit colors on spoiler reveal animation.
• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 9:04 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka, rohan.
• patryk published this revision for review.Aug 20 2023, 11:15 PM
• patryk updated this revision to Diff 30178.Aug 22 2023, 1:22 AM
• patryk edited the test plan for this revision. (Show Details)

Use SimpleMarkdown.inlineRegex

Harbormaster completed remote builds in B21976: Diff 30178.Aug 22 2023, 1:39 AM
• patryk added a child revision: D8896: [web][native] Rename usernamePrefix to textPrefix in TypeaheadMatchedStrings type.Aug 22 2023, 3:45 AM
rohan accepted this revision.Aug 24 2023, 7:09 AM
This revision is now accepted and ready to land.Aug 24 2023, 7:09 AM
Closed by commit rCOMM70c89fb76aaf: [web] Add chat mention rule to text message rules (authored by • patryk). · Explain WhySep 28 2023, 2:12 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM70c89fb76aaf: [web] Add chat mention rule to text message rules.

Revision Contents
Changeset List

PathSize
web/
markdown/
20 lines

Diff 30037

View Options

web/markdown/rules.react.js

Loading...