Page MenuHomePhabricator
Differential D8908

[lib] Encode chat name in raw chat mention
ClosedPublic
Actions

Authored by • patryk on Aug 22 2023, 5:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 4:50 PM
Unknown Object (File)
Thu, Apr 24, 4:45 PM
Unknown Object (File)
Sun, Apr 20, 7:13 AM
Unknown Object (File)
Fri, Apr 18, 12:45 AM
Unknown Object (File)
Thu, Apr 17, 7:13 PM
Unknown Object (File)
Thu, Apr 17, 3:14 AM
Unknown Object (File)
Wed, Apr 9, 3:46 AM
Unknown Object (File)
Wed, Apr 9, 1:13 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMMeb793d116fd1: [lib] Encode chat name in raw chat mention
Summary

Solution for ENG-4554.

This diff introduces encodeChatMentionText function which replaces all ] char occurrences with \].

Depends on D8902.

Test Plan

Before testing, please apply entire native stack.

Test if chat names which include ] are encoded and rendered properly:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Aug 22 2023, 5:25 AM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 5:25 AM
• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:28 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka.
• patryk edited the summary of this revision. (Show Details)
• patryk added a parent revision: D8902: [web][native] Use userStoreMentionSearchIndex.
• patryk added a child revision: D8909: [native] Replace chat name with raw chat mention.Aug 22 2023, 5:32 AM
Harbormaster completed remote builds in B22005: Diff 30214.Aug 22 2023, 5:43 AM
• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:51 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added a reviewer: rohan.
• patryk edited the test plan for this revision. (Show Details)Aug 22 2023, 6:01 AM
• patryk attached a referenced file: F703249: testing weird chats.mp4. (Show Details)
• patryk published this revision for review.Aug 22 2023, 8:38 AM
• patryk updated this revision to Diff 30291.Aug 24 2023, 1:44 PM

Rebase

Harbormaster completed remote builds in B22067: Diff 30291.Aug 24 2023, 2:05 PM
• patryk added a child revision: D8943: [web] Refactor TypeaheadTooltip component.Aug 25 2023, 3:14 AM
inka accepted this revision.Aug 29 2023, 5:29 AM
This revision is now accepted and ready to land.Aug 29 2023, 5:29 AM
inka added a comment.Sep 6 2023, 1:27 AM

Can you add some tests please?

• patryk added a child revision: D9254: [lib] Add unit tests for mention utils.Sep 21 2023, 4:22 AM
• patryk added a comment.Sep 21 2023, 6:24 AM

D9254

Closed by commit rCOMMeb793d116fd1: [lib] Encode chat name in raw chat mention (authored by • patryk). · Explain WhySep 28 2023, 5:27 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMMeb793d116fd1: [lib] Encode chat name in raw chat mention.

Revision Contents
Changeset List

PathSize
lib/
shared/
5 lines

Diff 30214

View Options

lib/shared/mention-utils.js

Loading...