Page MenuHomePhabricator
Differential D8817

[Treewide] Rename onetime to one_time
ClosedPublic
Actions

Authored by • jon on Aug 15 2023, 10:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 10:53 AM
Unknown Object (File)
Tue, Mar 11, 3:56 PM
Unknown Object (File)
Tue, Mar 11, 3:12 PM
Unknown Object (File)
Thu, Mar 6, 10:25 PM
Unknown Object (File)
Wed, Mar 5, 8:09 AM
Unknown Object (File)
Wed, Mar 5, 5:44 AM
Unknown Object (File)
Tue, Mar 4, 7:39 PM
Unknown Object (File)
Tue, Mar 4, 7:34 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMMaf2aa087b832: [Treewide] Rename onetime to one_time
Summary

"oneTime" is the language used in the white paper. Make this
consistent between all call sites.

https://linear.app/comm/issue/ENG-4642

Depends on D8816

Test Plan

everything builds.
Run one time integration tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 15 2023, 10:02 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 10:02 AM
Harbormaster completed remote builds in B21760: Diff 29913.Aug 15 2023, 10:20 AM
• jon requested review of this revision.Aug 15 2023, 10:20 AM
• jon planned changes to this revision.Aug 15 2023, 10:48 AM

Missed some comments

services/identity/src/database.rs
388 ↗(On Diff #29913)
390 ↗(On Diff #29913)
404 ↗(On Diff #29913)
• jon updated this revision to Diff 29921.Aug 15 2023, 10:50 AM

Fix some missed comments

Harbormaster completed remote builds in B21768: Diff 29921.Aug 15 2023, 11:09 AM
bartek accepted this revision.Aug 16 2023, 5:22 AM
This revision is now accepted and ready to land.Aug 16 2023, 5:22 AM
• jon mentioned this in D8748: [Identity] Issue refresh_key_request to tunnelbroker.Aug 17 2023, 10:05 AM
• jon updated this revision to Diff 30025.Aug 17 2023, 10:10 AM

Rebase on changes to previous diffs

Harbormaster failed remote builds in B21851: Diff 30025!Aug 17 2023, 10:13 AM
• jon updated this revision to Diff 30036.Aug 17 2023, 10:28 AM

Apply rename to new code from previous diff feedback

Harbormaster completed remote builds in B21862: Diff 30036.Aug 17 2023, 10:57 AM
• jon added a child revision: D8878: [Identity] Show consumed capacity when running query.Aug 20 2023, 11:32 PM
• jon updated this revision to Diff 30272.Aug 23 2023, 10:27 AM

Rebase after conflict changes in previous diff

Harbormaster completed remote builds in B22052: Diff 30272.Aug 23 2023, 10:44 AM
• jon updated this revision to Diff 30340.Aug 25 2023, 4:52 PM

Rebase on top of master

Harbormaster completed remote builds in B22106: Diff 30340.Aug 25 2023, 5:11 PM
• jon updated this revision to Diff 30410.Aug 27 2023, 10:25 PM

Fixed miss rename

Harbormaster completed remote builds in B22151: Diff 30410.Aug 27 2023, 10:43 PM
Closed by commit rCOMMaf2aa087b832: [Treewide] Rename onetime to one_time (authored by • jon). · Explain WhyAug 27 2023, 11:59 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMaf2aa087b832: [Treewide] Rename onetime to one_time.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
4 lines
4 lines
native/
native_rust_library/
src/
8 lines
56 lines
services/
commtest/
src/
identity/
4 lines
tests/
8 lines
identity/
src/
36 lines
10 lines
32 lines
grpc_services/
4 lines
4 lines
shared/
protos/
4 lines
8 lines

Diff 30340

View Options

keyserver/addons/rust-node-addon/src/identity_client/login.rs

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/blob
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/blob # Install more recent version of protobuf, must be ran as root
WORKDIR /home/comm/app/blob COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN cargo init --bin RUN ../../scripts/install_protobuf.sh
ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
# Cache build dependencies in a new layer
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release && rm src/*.rs
# Copy actual application sources # Copy actual application sources
COPY services/blob . COPY services/comm-services-lib ../comm-services-lib
COPY services/blob ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm ./target/release/deps/blob*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Update dependencies, install ca-certificates which are required for TLS
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/blob /usr/local/bin/blob
WORKDIR /home/comm/app/blob
# Create a new user comm and use it to run subsequent commands # Create a new user comm and use it to run subsequent commands
RUN useradd -m comm RUN useradd -m comm
USER comm USER comm
# Only copy built binary from builder stage ENV RUST_LOG=info
WORKDIR /home/comm/app/blob
COPY --from=builder /home/comm/app/blob/target/release/blob .
ARG COMM_SERVICES_SANDBOX CMD ["blob"]
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}
CMD ["./blob"]
View Options

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/blob
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/blob # Install more recent version of protobuf, must be ran as root
WORKDIR /home/comm/app/blob COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN cargo init --bin RUN ../../scripts/install_protobuf.sh
ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
# Cache build dependencies in a new layer
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release && rm src/*.rs
# Copy actual application sources # Copy actual application sources
COPY services/blob . COPY services/comm-services-lib ../comm-services-lib
COPY services/blob ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm ./target/release/deps/blob*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Update dependencies, install ca-certificates which are required for TLS
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/blob /usr/local/bin/blob
WORKDIR /home/comm/app/blob
# Create a new user comm and use it to run subsequent commands # Create a new user comm and use it to run subsequent commands
RUN useradd -m comm RUN useradd -m comm
USER comm USER comm
# Only copy built binary from builder stage ENV RUST_LOG=info
WORKDIR /home/comm/app/blob
COPY --from=builder /home/comm/app/blob/target/release/blob .
ARG COMM_SERVICES_SANDBOX CMD ["blob"]
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}
CMD ["./blob"]
View Options

native/native_rust_library/src/identity_client.rs

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/blob
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/blob # Install more recent version of protobuf, must be ran as root
WORKDIR /home/comm/app/blob COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN cargo init --bin RUN ../../scripts/install_protobuf.sh
ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
# Cache build dependencies in a new layer
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release && rm src/*.rs
# Copy actual application sources # Copy actual application sources
COPY services/blob . COPY services/comm-services-lib ../comm-services-lib
COPY services/blob ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm ./target/release/deps/blob*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Update dependencies, install ca-certificates which are required for TLS
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/blob /usr/local/bin/blob
WORKDIR /home/comm/app/blob
# Create a new user comm and use it to run subsequent commands # Create a new user comm and use it to run subsequent commands
RUN useradd -m comm RUN useradd -m comm
USER comm USER comm
# Only copy built binary from builder stage ENV RUST_LOG=info
WORKDIR /home/comm/app/blob
COPY --from=builder /home/comm/app/blob/target/release/blob .
ARG COMM_SERVICES_SANDBOX CMD ["blob"]
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}
CMD ["./blob"]
View Options

native/native_rust_library/src/lib.rs

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/blob
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/blob # Install more recent version of protobuf, must be ran as root
WORKDIR /home/comm/app/blob COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN cargo init --bin RUN ../../scripts/install_protobuf.sh
ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
# Cache build dependencies in a new layer
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release && rm src/*.rs
# Copy actual application sources # Copy actual application sources
COPY services/blob . COPY services/comm-services-lib ../comm-services-lib
COPY services/blob ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm ./target/release/deps/blob*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Update dependencies, install ca-certificates which are required for TLS
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/blob /usr/local/bin/blob
WORKDIR /home/comm/app/blob
# Create a new user comm and use it to run subsequent commands # Create a new user comm and use it to run subsequent commands
RUN useradd -m comm RUN useradd -m comm
USER comm USER comm
# Only copy built binary from builder stage ENV RUST_LOG=info
WORKDIR /home/comm/app/blob
COPY --from=builder /home/comm/app/blob/target/release/blob .
ARG COMM_SERVICES_SANDBOX CMD ["blob"]
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}
CMD ["./blob"]
View Options

services/commtest/src/identity/device.rs

Loading...
View Options

services/commtest/tests/identity_keyserver_tests.rs

Loading...
View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

services/identity/src/tunnelbroker.rs

Loading...
View Options

shared/protos/identity_authenticated.proto

Loading...
View Options

shared/protos/identity_client.proto

Loading...