Page MenuHomePhabricator

[lib] Add unit tests for chat mention regex
ClosedPublic

Authored by patryk on Aug 31 2023, 2:06 PM.
Tags
None
Referenced Files
F3375354: D9056.id30680.diff
Tue, Nov 26, 7:47 PM
F3374951: D9056.diff
Tue, Nov 26, 5:31 PM
Unknown Object (File)
Fri, Nov 8, 8:53 AM
Unknown Object (File)
Fri, Nov 8, 5:44 AM
Unknown Object (File)
Fri, Nov 8, 4:21 AM
Unknown Object (File)
Tue, Nov 5, 7:33 PM
Unknown Object (File)
Sun, Nov 3, 11:35 PM
Unknown Object (File)
Oct 27 2024, 2:04 PM
Subscribers

Details

Summary

This diff adds chat mention regex unit tests to markdown.test.js.

Depends on D8834.

Test Plan

Run yarn test in lib folder and check if all tests pass.

Diff Detail

Repository
rCOMM Comm
Branch
patryk/chat-mentioning
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

patryk held this revision as a draft.
patryk edited the test plan for this revision. (Show Details)
patryk added reviewers: tomek, inka, rohan.
patryk edited the summary of this revision. (Show Details)

Thanks for doing this!! Tests look great. I think outside of this file the pattern is to typically use it('should...), but I don't think it's a big deal

lib/shared/markdown.test.js
120 ↗(On Diff #30689)
124 ↗(On Diff #30689)
This revision is now accepted and ready to land.Sep 1 2023, 7:24 AM