[web][native] Rename usernamePrefix to textPrefix in TypeaheadMatchedStrings type
ClosedPublic
Actions

Authored by • patryk on Aug 22 2023, 1:55 AM.

Details

Reviewers

tomek
inka
rohan

Commits

rCOMM9ad8cc20c046: [web][native] Rename usernamePrefix to textPrefix in TypeaheadMatchedStrings…

Summary

This diff renames usernamePrefix to textPrefix in TypeaheadMatchedStrings type. Since we will show chats in mention typeahead tooltip, it is necessary to rename utilities to make code more generic.

Depends on D8853, D8849.

Test Plan

Check if TypeaheadTooltip works properly both on native and web.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 22 2023, 1:55 AM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 1:55 AM

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 2:10 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added reviewers: tomek, inka.

Harbormaster completed remote builds in B21978: Diff 30180.Aug 22 2023, 2:12 AM

• patryk added a child revision: D8897: [native] Refactor TypeaheadTooltip component.Aug 22 2023, 2:29 AM

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 3:45 AM

• patryk added parent revisions: D8853: [web] Add chat mention rule to text message rules, D8849: [native] Add chat mention rule to text message rules.

• patryk added a reviewer: rohan.Aug 22 2023, 5:37 AM

• patryk published this revision for review.Aug 22 2023, 8:37 AM

rohan accepted this revision.Aug 24 2023, 7:13 AM

This revision is now accepted and ready to land.Aug 24 2023, 7:13 AM

tomek requested changes to this revision.Sep 12 2023, 7:01 AM

tomek added inline comments.

lib/shared/mention-utils.js
18 ↗	(On Diff #30180)	This name might be confusing - it isn't clear what is `text` in this context, especially because this is different than in the other prop. Maybe `query`, `match`, `mathPrefix`, or something else would be less confusing?