Page MenuHomePhabricator
Differential D9061

[lib][native][web] Move validChatNameRegex to validation-utils.js
ClosedPublic
Actions

Authored by • patryk on Sep 1 2023, 5:22 AM.
Tags
None
Referenced Files
F3390738: D9061.id31516.diff
Sat, Nov 30, 12:55 AM
F3390308: D9061.diff
Fri, Nov 29, 11:15 PM
Unknown Object (File)
Tue, Nov 26, 7:43 AM
Unknown Object (File)
Sat, Nov 9, 9:09 AM
Unknown Object (File)
Mon, Nov 4, 12:59 PM
Unknown Object (File)
Oct 30 2024, 3:47 PM
Unknown Object (File)
Oct 27 2024, 2:04 PM
Unknown Object (File)
Oct 12 2024, 10:06 AM
View All 66 Files
Subscribers
ashoat
rohan
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMM806657eae30c: [lib][native][web] Move validChatNameRegex to validation-utils.js
Summary

This diff resolves the ReferenceError issue on web, which was occurring after the introduction of D8834.

error2.png (409×511 px, 85 KB)

Depends on D8945.

Test Plan

Check if all files import validChatNameRegex, validChatNameRegexString, chatNameMaxLength from validation-utils.js

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• patryk created this revision.Sep 1 2023, 5:22 AM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 1 2023, 5:22 AM
• patryk edited the summary of this revision. (Show Details)Sep 1 2023, 5:28 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka.
• patryk attached a referenced file: F737992: error2.png. (Show Details)
Harbormaster completed remote builds in B22343: Diff 30695.Sep 1 2023, 5:40 AM
• patryk edited the summary of this revision. (Show Details)Sep 1 2023, 5:41 AM
• patryk edited the test plan for this revision. (Show Details)

Why moving this to validation-utils.js and not to other file?

validChatNameRegex has a word valid => validation => validation-utils.js

• patryk edited the summary of this revision. (Show Details)Sep 1 2023, 5:43 AM
• patryk added a parent revision: D9007: [keyserver] Render chat mention in notification text.
• patryk published this revision for review.Sep 1 2023, 5:46 AM
• patryk edited the summary of this revision. (Show Details)
• patryk added a parent revision: D8945: [web] Show chats in mention typeahead tooltip.
• patryk removed a parent revision: D9007: [keyserver] Render chat mention in notification text.
rohan accepted this revision.Sep 1 2023, 7:20 AM
rohan added a subscriber: rohan.

Didn't review this super closely, seems like just a move

This revision is now accepted and ready to land.Sep 1 2023, 7:20 AM
Closed by commit rCOMM806657eae30c: [lib][native][web] Move validChatNameRegex to validation-utils.js (authored by • patryk). · Explain WhySep 28 2023, 5:54 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM806657eae30c: [lib][native][web] Move validChatNameRegex to validation-utils.js.

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
2 lines
lib/
shared/
4 lines
9 lines
utils/
9 lines
native/
chat/
settings/
2 lines
utils/
2 lines
web/
modals/
threads/
settings/
6 lines
utils/
2 lines

Diff 31516

View Options

keyserver/src/updaters/thread-updaters.js

Loading...
View Options

lib/shared/mention-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/utils/validation-utils.js

Loading...
View Options

native/chat/settings/thread-settings-name.react.js

Loading...
View Options

native/utils/typeahead-utils.js

Loading...
View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

Loading...
View Options

web/utils/typeahead-utils.js

Loading...