[lib] Update `threadInfoFromRawThreadInfo` to return `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Dec 5 2023, 7:44 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM6089a9fcfd4b: [lib] Update `threadInfoFromRawThreadInfo` to return…

Summary

Update threadInfoFromRawThreadInfo to always return MinimallyEncodedThreadInfo and update eg baseCreatePendingSidebar to accomodate that. Now all newly created pending threads on the client will be MinimallyEncoded.. so "new threads" going into Redux will be MinimallyEncoded and we won't be creating legacyThreadInfos on the client.

Test Plan

CI/flow/etc.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 5 2023, 7:44 AM

atul added inline comments.Dec 5 2023, 7:44 AM

lib/shared/thread-utils.js
893 ↗	(On Diff #34282)	This will be updated as well to be more flexible.

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 5 2023, 7:46 AM

Harbormaster failed remote builds in B24807: Diff 34282!

Harbormaster completed remote builds in B24807: Diff 34282.Dec 5 2023, 8:22 AM

atul requested review of this revision.Dec 5 2023, 8:22 AM

rohan accepted this revision.Dec 5 2023, 8:26 AM

This revision is now accepted and ready to land.Dec 5 2023, 8:26 AM

atul added a child revision: D10197: [lib] Update `isThreadWatched` to handle `RawThreadInfo`.Dec 5 2023, 10:40 AM

Marking this as [DO NOT LAND] because this would break existing clients at this point.

final rebase pass

Harbormaster completed remote builds in B25037: Diff 34597.Dec 13 2023, 2:58 PM

atul retitled this revision from [DO NOT LAND][lib] Update `threadInfoFromRawThreadInfo` to return `MinimallyEncodedThreadInfo` to [lib] Update `threadInfoFromRawThreadInfo` to return `MinimallyEncodedThreadInfo`.Dec 14 2023, 1:00 PM

Closed by commit rCOMM6089a9fcfd4b: [lib] Update `threadInfoFromRawThreadInfo` to return… (authored by atul). · Explain WhyDec 14 2023, 1:03 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6089a9fcfd4b: [lib] Update `threadInfoFromRawThreadInfo` to return….