but I think it makes sense to remove them only on identity logout

Something I'm a bit confused about... here it seems like we're planning to keep using logOutActionTypes for logout. But in this diff, you seem to imply that there will be a new action added later for identity logout. Can you clarify the scenario where we'll want to use that identity logout action?

For user-initiated logout, I just proposed having a single set of logout actions to handle combined keyserver and identity logout here. If we take that approach, should we keep logOutActionTypes for that combined keyserver/identity logout? If we take that approach, this diff won't make sense.

PS – there are no reviewers here

PS – there are no reviewers here

Thank you

For user-initiated logout, I just proposed having a single set of logout actions to handle combined keyserver and identity logout here. If we take that approach, should we keep logOutActionTypes for that combined keyserver/identity logout? If we take that approach, this diff won't make sense.

My understanding from talking to @varun was that we will have a separate logout from identity action.
We started discussing this in many places, I propose to continue in ENG-6424.

This change would still make sense for deleteKeyserverAccountActionTypes though. When a user removes a keyserver from their keyserver list, we don't want to remove the policies store.

This change would still make sense for deleteKeyserverAccountActionTypes though. When a user removes a keyserver from their keyserver list, we don't want to remove the policies store.

I don't follow why we should be clearing the policies store on this action when !usingCommServicesAccessToken. It feels like the behavior of this single action is being overloaded to mean two completely different things depending on usingCommServicesAccessToken. This is very confusing... we should have two different actions here, I think.