Differential D12408

[web] remove ping component
ClosedPublic
Actions

Authored by varun on Wed, Jun 12, 12:29 PM.

Tags

None

Referenced Files

	F2147794: D12408.diff
	Sun, Jun 30, 2:54 AM

	Unknown Object (File)
	Mon, Jun 24, 7:35 AM

	Unknown Object (File)
	Thu, Jun 20, 11:09 PM

	Unknown Object (File)
	Thu, Jun 20, 12:16 AM

	Unknown Object (File)
	Tue, Jun 18, 7:20 PM

	Unknown Object (File)
	Tue, Jun 18, 1:20 PM

	Unknown Object (File)
	Tue, Jun 18, 1:20 PM

	Unknown Object (File)
	Tue, Jun 18, 1:18 PM

View All 11 Files

Subscribers

Details

Reviewers

Commits

rCOMMc6d5f53a58a5: [web] remove ping component

Summary

we are now calling the identity service from MinVersionHandler on web, so there's no need for this ping component anymore. the point was to make sure that the identity client is callable via gRPC-web on prod, which is achieved now in MinVersionHandler.

Depends on D12407

Test Plan

made sure there were no references to IdentityPing left in code

Diff Detail

Repository

Branch

webping (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Wed, Jun 12, 12:29 PM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Jun 12, 12:29 PM

varun mentioned this in D12405: [native][web][lib] add versionSupported method to IdentityServiceClient.Wed, Jun 12, 12:37 PM

Harbormaster completed remote builds in B29630: Diff 41251.Wed, Jun 12, 12:45 PM

varun requested review of this revision.Wed, Jun 12, 12:45 PM

ashoat accepted this revision.Wed, Jun 12, 12:50 PM

This revision is now accepted and ready to land.Wed, Jun 12, 12:50 PM

varun added a child revision: D12432: [identity] more tonic status conversions.Thu, Jun 13, 1:33 PM

Closed by commit rCOMMc6d5f53a58a5: [web] remove ping component (authored by varun). · Explain WhyMon, Jun 17, 9:47 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMc6d5f53a58a5: [web] remove ping component.

Revision Contents
Changeset List

Path

Size

web/

2 lines

components/

identity-ping.react.js

Diff 41251

web/app.react.js

Loading...

web/components/identity-ping.react.js

Loading...