Page MenuHomePhabricator
Differential D12496

[lib] Fix up client ThreadStore validation
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 10:45 AM
Unknown Object (File)
Feb 14 2025, 1:30 PM
Unknown Object (File)
Feb 1 2025, 5:35 AM
Unknown Object (File)
Feb 1 2025, 5:35 AM
Unknown Object (File)
Feb 1 2025, 5:34 AM
Unknown Object (File)
Jan 28 2025, 8:36 PM
Unknown Object (File)
Jan 28 2025, 5:54 PM
Unknown Object (File)
Jan 20 2025, 1:14 PM
View All 65 Files
Subscribers
tomek

Details

Reviewers
kamil
marcin
Commits
rCOMMf006ec332ed1: [lib] Fix up client ThreadStore validation
Summary

I noticed we use tcomb validators on the client side here, so I figured it would be good to fix them before we insert any ThickRawThreadInfos into SQLite.

Depends on D12495

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
permissions/
15 lines
utils/
6 lines

Diff 41532

View Options

lib/permissions/minimally-encoded-raw-thread-info-validators.js

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}
View Options

lib/utils/thread-ops-utils.js

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}