Page MenuHomePhabricator
Differential D12476

Move groupping device by platform details and notif info generation promise to utils in lib/push
ClosedPublic
Actions

Authored by marcin on Jun 19 2024, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 6:48 AM
Unknown Object (File)
Thu, Dec 19, 6:48 AM
Unknown Object (File)
Thu, Dec 19, 6:48 AM
Unknown Object (File)
Thu, Dec 19, 6:48 AM
Unknown Object (File)
Thu, Dec 19, 6:48 AM
Unknown Object (File)
Thu, Dec 19, 6:48 AM
Unknown Object (File)
Thu, Dec 19, 6:48 AM
Unknown Object (File)
Wed, Dec 4, 7:10 PM
View All Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM5447dc6182ef: Move groupping device by platform details and notif info generation promise to…
Summary

This differential moves a utility function that groups devices by platform details to lib since we will need it for client-sent notifs as well.

Test Plan

check that notifs work on the keyserver.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jun 19 2024, 1:17 PM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 19 2024, 1:17 PM
marcin added a parent revision: D12464: Implement notification texts generation on the client.Jun 19 2024, 1:18 PM
marcin added a child revision: D12477: Implement building encrypted notifications on the client.Jun 19 2024, 1:23 PM
Harbormaster completed remote builds in B29772: Diff 41494.Jun 19 2024, 1:33 PM
marcin requested review of this revision.Jun 19 2024, 1:33 PM
marcin updated this revision to Diff 41568.Jun 20 2024, 4:59 AM

Rebacr

marcin added a comment.Jun 20 2024, 5:00 AM

This diff is pure copy paste. No additional logic.

Harbormaster completed remote builds in B29833: Diff 41568.Jun 20 2024, 5:45 AM
kamil accepted this revision.Jun 27 2024, 5:03 AM
kamil added inline comments.
lib/push/utils.js
2 ↗(On Diff #41568)

add empty line here

5–6 ↗(On Diff #41568)

can be merged

86–94 ↗(On Diff #41568)

can you update this to be an object?

This revision is now accepted and ready to land.Jun 27 2024, 5:03 AM
ashoat added inline comments.Jul 1 2024, 12:09 PM
lib/push/utils.js
5–6 ↗(On Diff #41568)

These are actually different files

86–94 ↗(On Diff #41568)

+1, way too many functions with a huge number of parameters in this stack. We should max out around 4 params, unless multiple are booleans in which case it's more like 2-3

marcin updated this revision to Diff 41947.Jul 3 2024, 3:35 AM

Extract parameters to object

Harbormaster completed remote builds in B30083: Diff 41947.Jul 3 2024, 4:02 AM
marcin updated this revision to Diff 42019.Jul 4 2024, 5:39 AM

Rebase before landing

Harbormaster completed remote builds in B30142: Diff 42019.Jul 4 2024, 6:28 AM
Closed by commit rCOMM5447dc6182ef: Move groupping device by platform details and notif info generation promise to… (authored by marcin). · Explain WhyJul 4 2024, 7:19 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM5447dc6182ef: Move groupping device by platform details and notif info generation promise to….

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
7 lines
push/
87 lines
lib/
push/
96 lines
183 lines

Diff 42019

View Options

keyserver/src/creators/message-creator.js

Loading...
View Options

keyserver/src/push/send.js

Loading...
View Options

lib/push/send-utils.js

Loading...
View Options

lib/push/utils.js

Loading...