[CommCoreModule] remove capturing logs
ClosedPublic
Actions

Authored by kamil on Nov 14 2024, 8:34 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM31151871843e: [CommCoreModule] remove capturing logs

Summary

ENG-9656.

The decision explained in ENG-9663.

Created ENG-9921 to revert this in the future.

Depends on D13932

Test Plan

N/A - making sure this method is not called anywhere.

Diff Detail

Repository

rCOMM Comm

Branch

publish-client-backup

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Nov 14 2024, 8:34 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 14 2024, 8:34 AM

kamil edited the summary of this revision. (Show Details)Nov 14 2024, 8:37 AM

kamil added a child revision: D13934: [CommCoreModule] implement creating User Keys backup.Nov 14 2024, 8:50 AM

Harbormaster completed remote builds in B32665: Diff 45824.Nov 14 2024, 11:46 AM

kamil published this revision for review.Nov 15 2024, 2:25 AM

bartek accepted this revision.Nov 19 2024, 5:45 AM

This revision is now accepted and ready to land.Nov 19 2024, 5:45 AM

Closed by commit rCOMM31151871843e: [CommCoreModule] remove capturing logs (authored by kamil). · Explain WhyNov 25 2024, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM31151871843e: [CommCoreModule] remove capturing logs.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

1 line

PersistentStorageUtilities/

DataStores/

BaseDataStore.h

1 line

Diff 45824

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp