Page MenuHomePhabricator
Differential D13933

[CommCoreModule] remove capturing logs
ClosedPublic
Actions

Authored by kamil on Nov 14 2024, 8:34 AM.
Tags
None
Referenced Files
F6233363: D13933.diff
Thu, Apr 24, 11:59 AM
Unknown Object (File)
Mon, Apr 21, 11:20 AM
Unknown Object (File)
Sat, Apr 12, 7:54 PM
Unknown Object (File)
Thu, Apr 3, 3:08 AM
Unknown Object (File)
Wed, Apr 2, 10:13 PM
Unknown Object (File)
Wed, Apr 2, 7:37 PM
Unknown Object (File)
Wed, Apr 2, 12:12 AM
Unknown Object (File)
Mar 22 2025, 6:25 PM
View All 50 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM31151871843e: [CommCoreModule] remove capturing logs
Summary

ENG-9656.

The decision explained in ENG-9663.

Created ENG-9921 to revert this in the future.

Depends on D13932

Test Plan

N/A - making sure this method is not called anywhere.

Diff Detail

Repository
rCOMM Comm
Branch
publish-client-backup
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
PersistentStorageUtilities/
DataStores/
1 line

Diff 45824

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show All 17 Linesexport type MarkdownRules = {
+simpleMarkdownRules: SharedMarkdown.ParserRules, +simpleMarkdownRules: SharedMarkdown.ParserRules,
+emojiOnlyFactor: ?number, +emojiOnlyFactor: ?number,
// We need to use a Text container for Entry because it needs to match up // We need to use a Text container for Entry because it needs to match up
// exactly with TextInput. However, if we use a Text container, we can't // exactly with TextInput. However, if we use a Text container, we can't
// support styles for things like blockQuote, which rely on rendering as a // support styles for things like blockQuote, which rely on rendering as a
// View, and Views can't be nested inside Texts without explicit height and // View, and Views can't be nested inside Texts without explicit height and
// width // width
+container: 'View' | 'Text', +container: 'View' | 'Text',
+color?: string,
}; };
// Entry requires a seamless transition between Markdown and TextInput // Entry requires a seamless transition between Markdown and TextInput
// components, so we can't do anything that would change the position of text // components, so we can't do anything that would change the position of text
const inlineMarkdownRules: boolean => MarkdownRules = _memoize(useDarkStyle => { const inlineMarkdownRules: boolean => MarkdownRules = _memoize(useDarkStyle => {
const styles = getMarkdownStyles(useDarkStyle ? 'dark' : 'light'); const styles = getMarkdownStyles(useDarkStyle ? 'dark' : 'light');
const simpleMarkdownRules = { const simpleMarkdownRules = {
// Matches 'https://google.com' during parse phase and returns a 'link' node // Matches 'https://google.com' during parse phase and returns a 'link' node
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines blockQuote: {
content: parse(content, state), content: parse(content, state),
}; };
}, },
// eslint-disable-next-line react/display-name // eslint-disable-next-line react/display-name
react: ( react: (
node: SharedMarkdown.SingleASTNode, node: SharedMarkdown.SingleASTNode,
output: SharedMarkdown.Output<SharedMarkdown.ReactElement>, output: SharedMarkdown.Output<SharedMarkdown.ReactElement>,
state: SharedMarkdown.State, state: SharedMarkdown.State,
) => ( ) => {
<View key={state.key} style={styles.blockQuote}> return (
<View
key={state.key}
style={{ ...styles.blockQuote, backgroundColor: state.color }}
>
{output(node.content, state)} {output(node.content, state)}
</View> </View>
), );
},
}, },
codeBlock: { codeBlock: {
...SimpleMarkdown.defaultRules.codeBlock, ...SimpleMarkdown.defaultRules.codeBlock,
match: SimpleMarkdown.blockRegex( match: SimpleMarkdown.blockRegex(
SharedMarkdown.codeBlockStripTrailingNewlineRegex, SharedMarkdown.codeBlockStripTrailingNewlineRegex,
), ),
parse(capture: SharedMarkdown.Capture) { parse(capture: SharedMarkdown.Capture) {
return { return {
▲ Show 20 Lines • Show All 144 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/BaseDataStore.h

Show All 17 Linesexport type MarkdownRules = {
+simpleMarkdownRules: SharedMarkdown.ParserRules, +simpleMarkdownRules: SharedMarkdown.ParserRules,
+emojiOnlyFactor: ?number, +emojiOnlyFactor: ?number,
// We need to use a Text container for Entry because it needs to match up // We need to use a Text container for Entry because it needs to match up
// exactly with TextInput. However, if we use a Text container, we can't // exactly with TextInput. However, if we use a Text container, we can't
// support styles for things like blockQuote, which rely on rendering as a // support styles for things like blockQuote, which rely on rendering as a
// View, and Views can't be nested inside Texts without explicit height and // View, and Views can't be nested inside Texts without explicit height and
// width // width
+container: 'View' | 'Text', +container: 'View' | 'Text',
+color?: string,
}; };
// Entry requires a seamless transition between Markdown and TextInput // Entry requires a seamless transition between Markdown and TextInput
// components, so we can't do anything that would change the position of text // components, so we can't do anything that would change the position of text
const inlineMarkdownRules: boolean => MarkdownRules = _memoize(useDarkStyle => { const inlineMarkdownRules: boolean => MarkdownRules = _memoize(useDarkStyle => {
const styles = getMarkdownStyles(useDarkStyle ? 'dark' : 'light'); const styles = getMarkdownStyles(useDarkStyle ? 'dark' : 'light');
const simpleMarkdownRules = { const simpleMarkdownRules = {
// Matches 'https://google.com' during parse phase and returns a 'link' node // Matches 'https://google.com' during parse phase and returns a 'link' node
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines blockQuote: {
content: parse(content, state), content: parse(content, state),
}; };
}, },
// eslint-disable-next-line react/display-name // eslint-disable-next-line react/display-name
react: ( react: (
node: SharedMarkdown.SingleASTNode, node: SharedMarkdown.SingleASTNode,
output: SharedMarkdown.Output<SharedMarkdown.ReactElement>, output: SharedMarkdown.Output<SharedMarkdown.ReactElement>,
state: SharedMarkdown.State, state: SharedMarkdown.State,
) => ( ) => {
<View key={state.key} style={styles.blockQuote}> return (
<View
key={state.key}
style={{ ...styles.blockQuote, backgroundColor: state.color }}
>
{output(node.content, state)} {output(node.content, state)}
</View> </View>
), );
},
}, },
codeBlock: { codeBlock: {
...SimpleMarkdown.defaultRules.codeBlock, ...SimpleMarkdown.defaultRules.codeBlock,
match: SimpleMarkdown.blockRegex( match: SimpleMarkdown.blockRegex(
SharedMarkdown.codeBlockStripTrailingNewlineRegex, SharedMarkdown.codeBlockStripTrailingNewlineRegex,
), ),
parse(capture: SharedMarkdown.Capture) { parse(capture: SharedMarkdown.Capture) {
return { return {
▲ Show 20 Lines • Show All 144 Lines • Show Last 20 Lines