Page MenuHomePhabricator
Differential D13965

[native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess`
ClosedPublic
Actions

Authored by kamil on Nov 19 2024, 3:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 1:00 PM
Unknown Object (File)
Sun, Mar 23, 12:59 PM
Unknown Object (File)
Mon, Mar 3, 6:26 AM
Unknown Object (File)
Fri, Feb 28, 2:57 AM
Unknown Object (File)
Fri, Feb 28, 2:56 AM
Unknown Object (File)
Feb 18 2025, 1:56 PM
Unknown Object (File)
Feb 18 2025, 1:56 PM
Unknown Object (File)
Feb 14 2025, 8:53 PM
View All 55 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
varun
Commits
rCOMM4188d231937e: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess`
Summary

ENG-9905.

This diff merges types and moves retrieving keys to a different step.

This change is not backward compatible but this Flow hasn't been launched yet so we not breaking anything.

NOTE: It's not that easy to slice this into diffs, so it's possible that in the middle of the stack protocol is not working, it needs to be reviewed as a whole.

Depends on D13964

Test Plan

Tested later in the stack - D13968

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 19 2024, 3:06 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 19 2024, 3:06 AM
kamil edited the summary of this revision. (Show Details)Nov 19 2024, 3:08 AM
kamil added a child revision: D13966: [native][lib] remove `requestBackupKeys` from `SECONDARY_DEVICE_REGISTRATION_SUCCESS`.Nov 19 2024, 3:10 AM
kamil published this revision for review.Nov 19 2024, 4:12 AM
kamil added inline comments.
lib/types/tunnelbroker/qr-code-auth-message-types.js
8–13 ↗(On Diff #45874)
kamil edited the test plan for this revision. (Show Details)Nov 19 2024, 4:26 AM
Harbormaster completed remote builds in B32708: Diff 45874.Nov 19 2024, 5:07 AM
bartek accepted this revision.Nov 20 2024, 6:40 AM
This revision is now accepted and ready to land.Nov 20 2024, 6:40 AM
kamil updated this revision to Diff 45988.Nov 25 2024, 2:25 AM

fix comment typo

Harbormaster completed remote builds in B32801: Diff 45988.Nov 25 2024, 2:46 AM
Closed by commit rCOMM4188d231937e: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess` (authored by kamil). · Explain WhyNov 25 2024, 4:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM4188d231937e: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess`.

Revision Contents
Changeset List

PathSize
lib/
types/
tunnelbroker/
36 lines
native/
profile/
45 lines

Diff 45988

View Options

lib/types/tunnelbroker/qr-code-auth-message-types.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };