Page MenuHomePhabricator

[native] avoid showing SIWE backup message screen for non-primary devices
ClosedPublic

Authored by kamil on Tue, Nov 19, 4:23 AM.
Tags
None
Referenced Files
F3365930: D13968.id.diff
Mon, Nov 25, 8:31 AM
F3363234: D13968.diff
Mon, Nov 25, 12:59 AM
Unknown Object (File)
Sun, Nov 24, 9:56 AM
Unknown Object (File)
Wed, Nov 20, 1:18 AM
Unknown Object (File)
Wed, Nov 20, 1:18 AM
Unknown Object (File)
Wed, Nov 20, 1:18 AM
Unknown Object (File)
Tue, Nov 19, 11:09 PM
Unknown Object (File)
Tue, Nov 19, 10:27 PM
Subscribers

Details

Summary

ENG-9905.

This a fix for ENG-9917.

Depends on D13967

Test Plan

This is the final diff so testing this end-to-end.
I was scanning the QR code using my physical iOS device, secondary was the web and other iOS physical devices. I was testing this on both passwords and wallet users.
Things I checked:

  • Secondary logged in
  • Secondary received backup data (but ignored this for now)
  • On primary, the camera was dismissed and Secondary was added to the list
  • Tunnel broker connection (auth) created
  • Device list updates are sent

Things I didn't test (not sure if I should):

  • keyserver auth
  • scanning on Android (I don't have access to this device when creating this stack, I can do it later in the week)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Tue, Nov 19, 4:28 AM
This revision is now accepted and ready to land.Wed, Nov 20, 6:43 AM