Differential D13936

[CommCoreModule] cleanup methods for creating backup
ClosedPublic
Actions

Authored by kamil on Nov 14 2024, 8:58 AM.

Tags

None

Referenced Files

	F5120459: D13936.id46015.diff
	Thu, Apr 3, 8:00 AM

	F5120077: D13936.id45827.diff
	Thu, Apr 3, 6:17 AM

	Unknown Object (File)
	Thu, Apr 3, 2:42 AM

	Unknown Object (File)
	Wed, Apr 2, 1:20 AM

	Unknown Object (File)
	Fri, Mar 21, 2:38 AM

	Unknown Object (File)
	Sun, Mar 16, 1:06 PM

	Unknown Object (File)
	Mar 3 2025, 6:26 AM

	Unknown Object (File)
	Mar 3 2025, 6:26 AM

View All 39 Files

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMMf2be17bca4bd: [CommCoreModule] cleanup methods for creating backup

Summary

Cleaning old code to make it more straightforward, reducing code duplication.

Depends on D13935

Test Plan

Tested in D13937

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 14 2024, 8:58 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 14 2024, 8:58 AM

kamil added a child revision: D13937: [native_rust_library] update creating backup to return `backupID`.Nov 14 2024, 9:02 AM

kamil edited the test plan for this revision. (Show Details)Nov 14 2024, 9:04 AM

Harbormaster completed remote builds in B32668: Diff 45827.Nov 14 2024, 1:09 PM

kamil published this revision for review.Nov 15 2024, 2:26 AM

bartek accepted this revision.Nov 20 2024, 8:46 AM

This revision is now accepted and ready to land.Nov 20 2024, 8:46 AM

Closed by commit rCOMMf2be17bca4bd: [CommCoreModule] cleanup methods for creating backup (authored by kamil). · Explain WhyNov 25 2024, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMf2be17bca4bd: [CommCoreModule] cleanup methods for creating backup.

Revision Contents
Changeset List

Path

Size

native/

backup/

use-client-backup.js

30 lines

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

6 lines

CommCoreModule.cpp

84 lines

_generated/

commJSI-generated.cpp

profile/

backup-menu.react.js

13 lines

schema/

CommCoreModuleSchema.js

6 lines

Diff 46015

native/backup/use-client-backup.js

	Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines		:root {
	--app-list-icon-enabled-color: var(--success-primary);			--app-list-icon-enabled-color: var(--success-primary);
	--app-list-icon-disabled-color: var(--shades-white-80);			--app-list-icon-disabled-color: var(--shades-white-80);
	--account-settings-label: var(--shades-black-60);			--account-settings-label: var(--shades-black-60);
	--account-button-color: var(--violet-dark-100);			--account-button-color: var(--violet-dark-100);
	--chat-thread-list-menu-color: var(--shades-white-60);			--chat-thread-list-menu-color: var(--shades-white-60);
	--chat-thread-list-menu-bg: var(--shades-black-80);			--chat-thread-list-menu-bg: var(--shades-black-80);
	--chat-thread-list-menu-active-color: var(--shades-white-60);			--chat-thread-list-menu-active-color: var(--shades-white-60);
	--chat-thread-list-menu-active-bg: var(--shades-black-90);			--chat-thread-list-menu-active-bg: var(--shades-black-90);
				--search-clear-color: var(--shades-white-100);
				--search-clear-bg: var(--shades-black-70);
				--search-input-color: var(--shades-white-100);
				--search-input-placeholder: var(--shades-black-60);
				--search-icon-color: var(--shades-black-60);
	}			}

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

	Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines		:root {
	--app-list-icon-enabled-color: var(--success-primary);			--app-list-icon-enabled-color: var(--success-primary);
	--app-list-icon-disabled-color: var(--shades-white-80);			--app-list-icon-disabled-color: var(--shades-white-80);
	--account-settings-label: var(--shades-black-60);			--account-settings-label: var(--shades-black-60);
	--account-button-color: var(--violet-dark-100);			--account-button-color: var(--violet-dark-100);
	--chat-thread-list-menu-color: var(--shades-white-60);			--chat-thread-list-menu-color: var(--shades-white-60);
	--chat-thread-list-menu-bg: var(--shades-black-80);			--chat-thread-list-menu-bg: var(--shades-black-80);
	--chat-thread-list-menu-active-color: var(--shades-white-60);			--chat-thread-list-menu-active-color: var(--shades-white-60);
	--chat-thread-list-menu-active-bg: var(--shades-black-90);			--chat-thread-list-menu-active-bg: var(--shades-black-90);
				--search-clear-color: var(--shades-white-100);
				--search-clear-bg: var(--shades-black-70);
				--search-input-color: var(--shades-white-100);
				--search-input-placeholder: var(--shades-black-60);
				--search-icon-color: var(--shades-black-60);
	}			}

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

	Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines		:root {
	--app-list-icon-enabled-color: var(--success-primary);			--app-list-icon-enabled-color: var(--success-primary);
	--app-list-icon-disabled-color: var(--shades-white-80);			--app-list-icon-disabled-color: var(--shades-white-80);
	--account-settings-label: var(--shades-black-60);			--account-settings-label: var(--shades-black-60);
	--account-button-color: var(--violet-dark-100);			--account-button-color: var(--violet-dark-100);
	--chat-thread-list-menu-color: var(--shades-white-60);			--chat-thread-list-menu-color: var(--shades-white-60);
	--chat-thread-list-menu-bg: var(--shades-black-80);			--chat-thread-list-menu-bg: var(--shades-black-80);
	--chat-thread-list-menu-active-color: var(--shades-white-60);			--chat-thread-list-menu-active-color: var(--shades-white-60);
	--chat-thread-list-menu-active-bg: var(--shades-black-90);			--chat-thread-list-menu-active-bg: var(--shades-black-90);
				--search-clear-color: var(--shades-white-100);
				--search-clear-bg: var(--shades-black-70);
				--search-input-color: var(--shades-white-100);
				--search-input-placeholder: var(--shades-black-60);
				--search-icon-color: var(--shades-black-60);
	}			}

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

	Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines		:root {
	--app-list-icon-enabled-color: var(--success-primary);			--app-list-icon-enabled-color: var(--success-primary);
	--app-list-icon-disabled-color: var(--shades-white-80);			--app-list-icon-disabled-color: var(--shades-white-80);
	--account-settings-label: var(--shades-black-60);			--account-settings-label: var(--shades-black-60);
	--account-button-color: var(--violet-dark-100);			--account-button-color: var(--violet-dark-100);
	--chat-thread-list-menu-color: var(--shades-white-60);			--chat-thread-list-menu-color: var(--shades-white-60);
	--chat-thread-list-menu-bg: var(--shades-black-80);			--chat-thread-list-menu-bg: var(--shades-black-80);
	--chat-thread-list-menu-active-color: var(--shades-white-60);			--chat-thread-list-menu-active-color: var(--shades-white-60);
	--chat-thread-list-menu-active-bg: var(--shades-black-90);			--chat-thread-list-menu-active-bg: var(--shades-black-90);
				--search-clear-color: var(--shades-white-100);
				--search-clear-bg: var(--shades-black-70);
				--search-input-color: var(--shades-white-100);
				--search-input-placeholder: var(--shades-black-60);
				--search-icon-color: var(--shades-black-60);
	}			}

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/profile/backup-menu.react.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...