I would like to avoid doing grpc/grpc_client and instead just have it under grpc/, after https://phab.comm.dev/D5045, only the client will remain in the folder

https://linear.app/comm/issue/ENG-1717/use-tracing-utilities-instead-of-println

Will address concerns in https://linear.app/comm/issue/ENG-1736/try-to-avoid-reassigning-when-modifying-the-field-of-a-global-struct

Created https://linear.app/comm/issue/ENG-1755/avoid-stringly-typed-values to address my string -> int -> bool concerns

I created https://linear.app/comm/issue/ENG-1754/remove-need-to-manage-client-handles for myself to investigate later.

I agree with @tomek, I would really like to see the diff not introduce things that need to be addressed, and then have a diff later address it.

https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client

If we get an error like provided holder already exists in the database, then what is the point of retrying? If we try again, it won't disappear magically I guess, will it?

Why do you keep blocking this?

indicate that it's pulling from nix store?

This should no longer be necessary after https://phab.comm.dev/D5077

Rebase on master

Rebase on master

Rebase on master

Rebase on master

Rebase on master

Rebase on master

Rebase on master

Rebase on master

Rebase on master

Rebase on master

Rebase on master

Rebase on master

landed to unblock other work where PATH was causing issues.

In file included from /Users/atul/comm/services/blob/build/protos/blob.pb.cc:4:
#error This file was generated by an older version of protoc which is/Users/atul/comm/services/blob/build/protos/blob.pb.h

We really need to get a test suite going, these test plans should just be a CI check

ran:

arc patch D5076
# remove /usr/bin line from `scripts/source_development_defaults.sh`
nix develop

Could you please address my comment? Thanks!

What do you mean exactly?

@atul did you remove the old build folder?

or a task on linear and add a reference here.

Rebase with corrosion fixes

Rebase on top of master

Update on top of latest master

Rebase on top of latest master

Rebase on top of native/cpp changes

adjusted my herald rules to hopefully not add me on lib/shared revisions

We should probably find where the build script is located, then resolve paths from there. CARGO_MANIFEST_DIR should be set to the location of the Cargo.toml https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts

Add new line, export cmake targets

wish herald had a "affected files starts with shared/" option :/