- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 27 2023
Will split this diff up even more too since I'm moving and adding code
rebase before landing
rebase before landing
Apr 26 2023
D7646 makes this diff obsolete
rebase
I think it would also be good to update uploadSelectedMedia's parameter type which is currently ?MediaLibrarySelection to just MediaLibrarySelection in this diff as well
rebase
fix feature flag
update
rebase
address comments
address comments
address comments
address comments
Apr 25 2023
fix import order
rebase before landing
rebase before landing
break down diff
Need to create a function to factor out code I commented above
D7624 makes this diff obsolete
address comments
Apr 24 2023
Not clear why this is being prioritized right now when avatars work is so very deeply behind.
rebase before landing
Apr 23 2023
Apr 21 2023
rebase before landing
address comments/rebase before landing
Apr 20 2023
Apr 19 2023
simplify return
update order of route name
rebase before landing
Thanks for helping out here @ashoat! Definitely would have taken me a ton of time to figure that out. As I was working with the [User/Thread]AvatarCameraModal I had the type as AppNavigationProp<'ChatCameraModal'> | AppNavigationProp<'UserAvatarCameraModal'> for a placeholder, and after reading your explanation this helped connect the dots.
rebase in atuls changes
If neither of those work, let me know and I'll try to patch locally and take a look.
lgtm good catch with that bug
D7546 makes this diff obsolete