Removed CORS middleware from commAppRouter and amended the test plan so it doesn't require it. Amended the test plan to test the removal of existing CORS settings for upload endpoints. Defined a function for checking docker environment for clarity.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 27 2023
I've talked about it with @kamil in the office, and we had a few ideas but nothing really better than this.
Oct 26 2023
Oct 25 2023
Oct 23 2023
Added check for null cookie (this should only happen if someone in modyfying cookies directly)
Oct 20 2023
Fixed remaining comment, thanks for catching that
Doc changes
Added a migration for the new files alongside the nix automatically creating them on nix develop. I don't think we need to remove the old files, they will be just ignored and if someone had some custom configuration in it we don't want to override it. The docs changes are in the next diff because this diff doesn't change the behaviour and only handles adding the new files.
Use getCommConfig for the cors domain. Added the migrations/nix setup for it because it's required for the media download (as we are removing the already existing upload-specific cors handling). Amend the test plan for generation and use of config file on dev environment.
Oct 19 2023
Rename routers
Oct 18 2023
Rebase
Default cors to https://web.comm.app
Oct 16 2023
Oct 13 2023
It might be worth to introduce something like
struct MessageID { timestamp: DateTime<Utc>, client_message_id: String, }
Oct 12 2023
- I've updated the notion doc
- Created tasks here: ENG-5235 (web), ENG-5234 (native) as children of "Migrate data to SQLite"
Oct 11 2023
(I think you are missing a stack for this diff)
Oct 10 2023
- Don't we need to update the command in the docker file?
- This way cargo run -- server --http-port 123 doesn't work, only cargo run -- --http-port 123 server works, which feels weird. We could potentially add global = true to all args but that also has it's problems
If I understand correctly this will try to remove S3 blobs that might not exist (for holders can exist without having a blob uploaded and the logic will run for them too). Is this expected?
LGTM, potentially we could add these optimisations:
- Return impl Iterator<> instead of Vec
- Return &'self str in blobs_to_find_holders
but I haven't analysed it very thoroughly so there might be lifetime/ergonomics issues
Oct 9 2023
Rebase
Rebase
Rebase
Create a new function in spec that combines fetch and getServerInfosHash so flow doesn't complain
Fixed an issue where the integrity handler would run before the threads were fetched from db.
Oct 5 2023
Oct 4 2023
Change dependencies arrays, fix interval, clearTimeout as effect cleanup, fix array type.
Rebase
Comments
Update to new threadHashingStatus
Added comments and migrations. Extracted array chunking logic to utils. Fix issues with new action and types.
We've talked about this, but heads-up that in terms of sequencing, I'm thinking of that one as a sort of a "follow-up" to the multi-keyserver launch... we could launch with the expectation that users input keyserver URLs manually.
Oct 3 2023
Oct 2 2023
Sep 29 2023
Setting as "plan changes" so it's not landed by mistake
Rebase
This should probably be error! instead of debug! right?