[...] I guess its due to pt 4 - we cannot check if websocket is empty without hacky ways like timeouts

Update types and client_version_unsupported logic

Do we need to handle socket reconnection?

Should we implement some kind of timeout for the promises?

LGTM although I haven't been really working with react native code lately. Do the diffs for filling in the missing // TODO exist?

Rebase

Rebase migration

Rebase before landing

Setting as "plan changes" because it needs to be defered for a while to let web clients migrate (start using squadcal endpoints instead of web.comm.app).

Replaced by D9598

Nit: I would prefer to see the validators just below the corresponding type definition. IMO it makes it harder for people to forget to update validators when updating the types.

Fix formatting

Rebase

Use genesis.id

Fixes

Thanks for noticing that, not sure how I missed it

This gist contains both a SELECT query based on the UPDATE query and an UPDATE query. Both of these queries show equivalent results under EXPLAIN so I think they should have the same performance. They are both set for my user (3033752 which I took from the table in ENG-5287) and the genesis thread (1).

(indentation fixes, I forgot to commit them)

Indentation and naming fixes

Updated the docs issues, amended the test plan for docker keyserver deploy.

Removed CORS middleware from commAppRouter and amended the test plan so it doesn't require it. Amended the test plan to test the removal of existing CORS settings for upload endpoints. Defined a function for checking docker environment for clarity.

I've talked about it with @kamil in the office, and we had a few ideas but nothing really better than this.

Added check for null cookie (this should only happen if someone in modyfying cookies directly)

Fixed remaining comment, thanks for catching that

Doc changes

Added a migration for the new files alongside the nix automatically creating them on nix develop. I don't think we need to remove the old files, they will be just ignored and if someone had some custom configuration in it we don't want to override it. The docs changes are in the next diff because this diff doesn't change the behaviour and only handles adding the new files.

Use getCommConfig for the cors domain. Added the migrations/nix setup for it because it's required for the media download (as we are removing the already existing upload-specific cors handling). Amend the test plan for generation and use of config file on dev environment.

Rename routers

Rebase

Default cors to https://web.comm.app

Nice

It might be worth to introduce something like

struct MessageID {
  timestamp: DateTime<Utc>,
  client_message_id: String,
}

1. I've updated the notion doc
2. Created tasks here: ENG-5235 (web), ENG-5234 (native) as children of "Migrate data to SQLite"

(I think you are missing a stack for this diff)

Makes sense

1. Don't we need to update the command in the docker file?
2. This way cargo run -- server --http-port 123 doesn't work, only cargo run -- --http-port 123 server works, which feels weird. We could potentially add global = true to all args but that also has it's problems