- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 29 2024
Mar 29 2024
[GH Actions] Fix pip issue
Mar 28 2024
Mar 28 2024
atul requested review of D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.
atul published D11458: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts` for review.
atul published D11443: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship` for review.
atul committed rCOMM190b098d2697: [CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP` (authored by atul).
[CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP`
atul updated the diff for D11383: [CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP`.
land
Some notes inline
Mar 26 2024
Mar 26 2024
atul committed rCOMMc469b8386036: [CI] Include "Save NEYNAR_API_KEY to file" step in `[ios/android]_release`… (authored by atul).
[CI] Include "Save NEYNAR_API_KEY to file" step in `[ios/android]_release`…
atul updated the diff for D11381: [CI] Include "Save NEYNAR_API_KEY to file" step in `[ios/android]_release` workflows.
rebase and land
atul committed rCOMM91b21c0873ea: [lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...` (authored by atul).
[lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...`
atul updated the diff for D11382: [lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...`.
rebase and land
atul committed rCOMMbbaa364113d8: [native] Export `neynarKey` so it's accessible from `native` (authored by atul).
[native] Export `neynarKey` so it's accessible from `native`
address feedback
Mar 25 2024
Mar 25 2024
atul requested review of D11383: [CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP`.
atul requested review of D11382: [lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...`.
Mar 24 2024
Mar 24 2024
Mar 21 2024
Mar 21 2024
rename databaseModule -> sharedWorker
JK, literally a rename in https://phab.comm.dev/D11236
Looks like eg await databaseModule.isDatabaseSupported(); are no longer available, so this migration will need to be updated.
Mar 20 2024
Mar 20 2024
land
atul committed rCOMM50d6fe1ddfaf: [native] Redux migration to patch in `specialRole` field (authored by atul).
[native] Redux migration to patch in `specialRole` field
Safe to land, persist.version will get bumped when flip the switch lands.
land
atul committed rCOMM4a6e82ed9bb5: [native][web] Update `ChatInputBar` to pass `communityThreadInfo` to… (authored by atul).
[native][web] Update `ChatInputBar` to pass `communityThreadInfo` to…
atul updated the diff for D11308: [native][web] Update `ChatInputBar` to pass `communityThreadInfo` to `threadFrozenDueToViewerBlock`.
land
atul committed rCOMMf4f87f5e87e0: [lib] Remove usage of `memberHasAdminPowers` in `useThreadSearchIndex` (authored by atul).
[lib] Remove usage of `memberHasAdminPowers` in `useThreadSearchIndex`
atul updated the diff for D11276: [lib] Remove usage of `memberHasAdminPowers` in `useThreadSearchIndex`.
land
atul committed rCOMMcb303c6ea6b6: [lib] Omit `isDefault` field in `rawThreadInfoFromServerThreadInfo` (authored by atul).
[lib] Omit `isDefault` field in `rawThreadInfoFromServerThreadInfo`
atul updated the diff for D11261: [lib] Omit `isDefault` field in `rawThreadInfoFromServerThreadInfo`.
land
atul committed rCOMM531b65b66af4: [lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole` (authored by atul).
[lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`
atul added inline comments to D11261: [lib] Omit `isDefault` field in `rawThreadInfoFromServerThreadInfo`.
atul updated the diff for D11254: [lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`.
land
Mar 19 2024
Mar 19 2024
atul committed rCOMM36ee6cd417ce: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string… (authored by atul).
[lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string…
atul updated the diff for D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.
rebase and land
atul committed rCOMM0f3def7e94b8: [lib] Remove `isDefault` field from `RoleInfo` (authored by atul).
[lib] Remove `isDefault` field from `RoleInfo`
rebase before landing
In D11253#325063, @tomek wrote:Do we have a task for the migration?
atul added a comment to D11254: [lib] Remove `isDefault` field from `RoleInfo` in `patchRoleInfoWithSpecialRole`.
In D11254#325066, @tomek wrote:This migration wasn't already applied, right?
atul committed rCOMMcd71e1fc65fe: [lib] Update `threadHasAdminRole` to consider `specialField` (authored by atul).
[lib] Update `threadHasAdminRole` to consider `specialField`
rebase around and land
Thanks for checking!
If leaveThread is the only place where we need to support the legacy approach, we can consider having the special logic only there. Overall, I'm looking for a solution where we can make this code a bit more maintainable, but not sure if it is worth it (maybe we can have two variants of this function with different types accepted?).
atul committed rCOMM49bcd23b617f: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is… (authored by atul).
[lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is…
atul updated the diff for D11208: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`.
rebase around and land
atul added a comment to D11208: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`.
This is safe to land because we will fall back to previous roleIsAdminRole and roleIsDefaultRole logic if specialRole field is missing (as it will on web when landed prior to "flipping the switch").
atul committed rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and… (authored by atul).
[lib] Constrain dep list of `useRoleMemberCountsForCommunity` and…
atul updated the diff for D11248: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and `useRoleUserSurfacedPermissions`.
rebase and land
atul committed rCOMM413c7b519700: [lib] Introduce `persistedRoleInfoValidator` and use in… (authored by atul).
[lib] Introduce `persistedRoleInfoValidator` and use in…
atul updated the diff for D11286: [lib] Introduce `persistedRoleInfoValidator` and use in `convertClientDBThreadInfoToRawThreadInfo`.
make things read-only
atul updated the diff for D11286: [lib] Introduce `persistedRoleInfoValidator` and use in `convertClientDBThreadInfoToRawThreadInfo`.
rebase around everything and land
atul committed rCOMM1c8fd0995bab: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu` (authored by atul).
[web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`
Mar 18 2024
Mar 18 2024
atul updated the diff for D11206: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`.
rebase around other diffs
atul committed rCOMM43137cdaa2c0: [lib] Remove usage of `memberHasAdminPowers` in `useKeyserverAdmin` (authored by atul).
[lib] Remove usage of `memberHasAdminPowers` in `useKeyserverAdmin`
atul updated the test plan for D11263: [lib] Remove usage of `memberHasAdminPowers` in `useKeyserverAdmin`.
atul updated the diff for D11263: [lib] Remove usage of `memberHasAdminPowers` in `useKeyserverAdmin`.
rebase before landing
atul added inline comments to D11263: [lib] Remove usage of `memberHasAdminPowers` in `useKeyserverAdmin`.
Mar 14 2024
Mar 14 2024
atul requested review of D11333: [lib] Split implementations of `[client/server]ThreadInfoFromRawThreadInfo`.
Mar 13 2024
Mar 13 2024
Mar 12 2024
Mar 12 2024
atul updated the diff for D11311: [lib] Separate `serverThreadFrozenDueToBlock` and `clientThreadFrozenDueToBlock`.
narrow type
Mar 11 2024
Mar 11 2024