In D12615#357420, @ashoat wrote:

Are any validator changes necessary here?

remove callback

Thanks, @bartek, update to rely on clap.

address review

rebase before landing

remove extra space

rebase before landing

rebase

rebase before landing

address nits

1. Could you address @ashoat comments about spreads?
2. For Tunnelbroker, I will need 3 things: deviceID, headers because those are specified when building HTTP2 request to APNs, and payload - stringified notif, built on the client and only passed to APNs by Tunnelbroker without modification, wondering if we shouldn't design types to avoid spreading headers along with other notif props, but you can also do it before calling Tunnelbroker, this is up to you.

One note here:
This code was allowing us to test backup also on prod, which helped us catch some bugs, and that's why we kept it even if identity-service-context-provider.react.js was capable of doing that - but since the backup is now authenticated I think we can remove this (D12508, cc. @bartek).

Why not isLoggedInToKeyserver selector?

Looks good but might be good to get a review from someone else

remove debug

In D12525#355420, @bartek wrote:

What about undelivered_messages? Are they considered a "device data" too?

Thanks @bartek, all comments are valid

address review

You forgot to address @ashoat's comments

Overall looks good but might be good to get a review from someone with more experience in Rust (cc. @varun)

What if a user is successfully registered/logged in to Identity but for some reason markPrekeysAsPublished fails? Wondering, if shouldn't catch and ignore errors here and make sure later PrekeysHandler re-uploads the same keys and marks as published (since marking as published is used only for rotation).