Move logic
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 27 2024
Update renderTabBarItem type to use spread
I need a separate ref for every tab, this doesn't work
Requesting review because the changes are significant
Update approach due to changes requested in D13082.
Use components from react-native-tab-view
Aug 23 2024
Moved the handler in D13085, the tip is not dismissed anymore
Remove unnecessary code
Address review, move handler (ENG-9085)
Aug 22 2024
Requesting review since both me and @tomek are a bit confused
Turns out that the tip being dismissed is only happening after this diff. Trying to figure out why
Add MutedTabTipRouteName to newReanimatedRoutes
Aug 21 2024
Open to building a separate mechanism here if it's necessary
Use apostrophe
Aug 20 2024
Thank you!
In D13080#369411, @ashoat wrote:Some visual requests, feel free to do this in a separate task / diff if you prefer:
- Can we add some margin around the tooltip?
- Can we reduce the font size somewhat?
- Can we reduce the bottom padding below the button?
- Can we make the button a little smaller?
Rename
Have to answer to the rest of the review
Rename
Aug 19 2024
Address review
Address review + fix translation y value (request from D13071)
Simplify
Address review
One thing we could do here is add a separate update type for unread status. This way the logic from D13059 that needs getUpdatedThreadInfo would not be needed, and so getUpdatedThreadInfo would not be needed. But this might be too much work.
We tested sidebar creation and replies count is incorrect - after creating a sidebar and adding one message to it, the count was 2 instead of 1
Rename