Page MenuHomePhabricator
Feed Advanced Search

Aug 27 2024

inka requested review of D13180: [native] Create intro tip.
Aug 27 2024, 10:33 AM
inka requested review of D13179: [native] Make possible to render tip not pointing to anything.
Aug 27 2024, 10:25 AM
inka requested review of D13178: [native] Move ChatTabBarButton.
Aug 27 2024, 9:18 AM
inka requested review of D13177: [native] Create home tab tip.
Aug 27 2024, 9:15 AM
inka requested review of D13082: [native] Create custom top tabs component.
Aug 27 2024, 8:49 AM
inka updated the diff for D13082: [native] Create custom top tabs component.

Move logic

Aug 27 2024, 8:49 AM
inka updated the diff for D13175: [native] Add renderTabBarItem to MaterialTopTabBarProps.

Update renderTabBarItem type to use spread

Aug 27 2024, 8:43 AM
inka planned changes to D13082: [native] Create custom top tabs component.

I need a separate ref for every tab, this doesn't work

Aug 27 2024, 7:53 AM
inka requested review of D13176: [native] Fix light mode highlighting.
Aug 27 2024, 6:52 AM
inka attached a referenced file: F2556800: Simulator Screen Recording - iPhone 15 Pro Max - 2024-08-27 at 15.34.28.mp4.
Aug 27 2024, 6:36 AM
inka added a comment to D13084: [native] Create muted tab tip.

New video:

Aug 27 2024, 6:35 AM
inka requested review of D13084: [native] Create muted tab tip.

Requesting review because the changes are significant

Aug 27 2024, 6:31 AM
inka requested review of D13175: [native] Add renderTabBarItem to MaterialTopTabBarProps.
Aug 27 2024, 6:08 AM
inka updated the diff for D13084: [native] Create muted tab tip.

Update approach due to changes requested in D13082.

Aug 27 2024, 6:02 AM
inka updated the diff for D13082: [native] Create custom top tabs component.

Use components from react-native-tab-view

Aug 27 2024, 5:55 AM

Aug 23 2024

inka added a comment to D13136: [native] Fix blinking overlay background.

Moved the handler in D13085, the tip is not dismissed anymore

Aug 23 2024, 5:10 AM
inka updated the diff for D13127: [native] Update styling.

Remove unnecessary code

Aug 23 2024, 4:44 AM
inka updated the diff for D13085: [native] Add nux handler.

Address review, move handler (ENG-9085)

Aug 23 2024, 4:40 AM
inka added inline comments to D13085: [native] Add nux handler.
Aug 23 2024, 4:39 AM

Aug 22 2024

inka requested review of D13085: [native] Add nux handler.

Requesting review since both me and @tomek are a bit confused

Aug 22 2024, 4:07 AM
inka added a comment to D13136: [native] Fix blinking overlay background.

Turns out that the tip being dismissed is only happening after this diff. Trying to figure out why

Aug 22 2024, 3:31 AM
inka requested review of D13136: [native] Fix blinking overlay background.
Aug 22 2024, 3:04 AM
inka updated the diff for D13084: [native] Create muted tab tip.

Add MutedTabTipRouteName to newReanimatedRoutes

Aug 22 2024, 2:46 AM

Aug 21 2024

inka closed D13081: [native] Extract community drawer button for nux tips, create community drawer tip.
Aug 21 2024, 12:44 AM
inka committed rCOMM72ea8a51a1cf: [native] Extract community drawer button for nux tips, create community drawer… (authored by inka).
[native] Extract community drawer button for nux tips, create community drawer…
Aug 21 2024, 12:44 AM
inka added a comment to D13085: [native] Add nux handler.

Open to building a separate mechanism here if it's necessary

Aug 21 2024, 12:40 AM
inka requested review of D13127: [native] Update styling.
Aug 21 2024, 12:40 AM
inka added a comment to D13084: [native] Create muted tab tip.

Here are screenshots with updated styles according to what we discussed in ENG-9058

image.png (2×1 px, 318 KB)

image.png (2×1 px, 327 KB)

Aug 21 2024, 12:19 AM
inka updated the diff for D13081: [native] Extract community drawer button for nux tips, create community drawer tip.

Use apostrophe

Aug 21 2024, 12:12 AM
inka closed D13080: [native] Add <next> button to nux tips.
Aug 21 2024, 12:07 AM
inka closed D13118: [native] Rename RegistrationButton.
Aug 21 2024, 12:07 AM
inka committed rCOMM30047630da0e: [native] Add <next> button to nux tips (authored by inka).
[native] Add <next> button to nux tips
Aug 21 2024, 12:07 AM
inka committed rCOMMb8e622562734: [native] Rename RegistrationButton (authored by inka).
[native] Rename RegistrationButton
Aug 21 2024, 12:07 AM
inka closed D13079: [native] Fetch coordinates from context in nux tips overlay.
Aug 21 2024, 12:07 AM
inka committed rCOMM3a3c6753b4ad: [native] Fetch coordinates from context in nux tips overlay (authored by inka).
[native] Fetch coordinates from context in nux tips overlay
Aug 21 2024, 12:07 AM

Aug 20 2024

inka accepted D13124: [native] Fix broken StyleProps type for react-native-reanimated libdef.

Thank you!

Aug 20 2024, 11:40 PM
inka accepted D13059: [lib] Update the replies count.
Aug 20 2024, 8:32 AM
inka requested review of D13120: [native] Make it impossible to skip tips.
Aug 20 2024, 6:16 AM
inka updated the test plan for D13085: [native] Add nux handler.
Aug 20 2024, 5:55 AM
inka updated the diff for D13085: [native] Add nux handler.

Address review

Aug 20 2024, 5:52 AM
inka added inline comments to D13085: [native] Add nux handler.
Aug 20 2024, 5:33 AM
inka updated the diff for D13080: [native] Add <next> button to nux tips.

Rebase

Aug 20 2024, 2:57 AM
inka updated the diff for D13118: [native] Rename RegistrationButton.

Rename

Aug 20 2024, 2:55 AM
inka added a comment to D13080: [native] Add <next> button to nux tips.

Some visual requests, feel free to do this in a separate task / diff if you prefer:

  1. Can we add some margin around the tooltip?
  2. Can we reduce the font size somewhat?
  3. Can we reduce the bottom padding below the button?
  4. Can we make the button a little smaller?
Aug 20 2024, 2:52 AM
inka added inline comments to D13081: [native] Extract community drawer button for nux tips, create community drawer tip.
Aug 20 2024, 2:05 AM
inka closed D13072: [native] Add possibility to display nux tip above an item.
Aug 20 2024, 2:00 AM
inka closed D13071: [native] Refactor nux tips overlay to reanimated 2.
Aug 20 2024, 2:00 AM
inka closed D13077: [native] Add mappaing from nux tips to button onPress params.
Aug 20 2024, 2:00 AM
inka committed rCOMMeafdf064867d: [native] Add possibility to display nux tip above an item (authored by inka).
[native] Add possibility to display nux tip above an item
Aug 20 2024, 2:00 AM
inka committed rCOMM4a8debda7133: [native] Add mappaing from nux tips to button onPress params (authored by inka).
[native] Add mappaing from nux tips to button onPress params
Aug 20 2024, 2:00 AM
inka closed D13070: [native] Update reaniamted flow types.
Aug 20 2024, 2:00 AM
inka committed rCOMM415d0eb2acd1: [native] Refactor nux tips overlay to reanimated 2 (authored by inka).
[native] Refactor nux tips overlay to reanimated 2
Aug 20 2024, 2:00 AM
inka committed rCOMM06168b83ec32: [native] Update reaniamted flow types (authored by inka).
[native] Update reaniamted flow types
Aug 20 2024, 2:00 AM
inka closed D13066: [native] Refactor background opacity to reanimated 2.
Aug 20 2024, 2:00 AM
inka closed D13069: [native] Extract normal style from animated style.
Aug 20 2024, 2:00 AM
inka committed rCOMMe74d6e4b5c84: [native] Extract normal style from animated style (authored by inka).
[native] Extract normal style from animated style
Aug 20 2024, 1:59 AM
inka committed rCOMMc8a78af3c8af: [native] Refactor background opacity to reanimated 2 (authored by inka).
[native] Refactor background opacity to reanimated 2
Aug 20 2024, 1:59 AM
inka closed D13064: [native] Modify overlay context to handle reanimated 2 components.
Aug 20 2024, 1:59 AM
inka closed D13065: [native] Simplify types.
Aug 20 2024, 1:59 AM
inka committed rCOMM5c1b9d97b69a: [native] Simplify types (authored by inka).
[native] Simplify types
Aug 20 2024, 1:59 AM
inka committed rCOMMfcb364eaee1a: [native] Modify overlay context to handle reanimated 2 components (authored by inka).
[native] Modify overlay context to handle reanimated 2 components
Aug 20 2024, 1:59 AM
inka closed D13063: [native] Simplify name.
Aug 20 2024, 1:59 AM
inka committed rCOMMd024104db519: [native] Simplify name (authored by inka).
[native] Simplify name
Aug 20 2024, 1:59 AM
inka updated the diff for D13084: [native] Create muted tab tip.

Rename

Aug 20 2024, 1:52 AM
inka added inline comments to D13081: [native] Extract community drawer button for nux tips, create community drawer tip.
Aug 20 2024, 12:55 AM
inka updated the diff for D13081: [native] Extract community drawer button for nux tips, create community drawer tip.

Rename

Aug 20 2024, 12:55 AM
inka requested review of D13118: [native] Rename RegistrationButton.
Aug 20 2024, 12:50 AM
inka added inline comments to D13084: [native] Create muted tab tip.
Aug 20 2024, 12:49 AM
inka planned changes to D13080: [native] Add <next> button to nux tips.

Have to answer to the rest of the review

Aug 20 2024, 12:40 AM
inka updated the diff for D13080: [native] Add <next> button to nux tips.

Rename

Aug 20 2024, 12:40 AM

Aug 19 2024

inka requested review of D13077: [native] Add mappaing from nux tips to button onPress params.
Aug 19 2024, 9:04 AM
inka updated the diff for D13079: [native] Fetch coordinates from context in nux tips overlay.

Address review

Aug 19 2024, 8:53 AM
inka updated the diff for D13072: [native] Add possibility to display nux tip above an item.

Address review + fix translation y value (request from D13071)

Aug 19 2024, 8:31 AM
inka added inline comments to D13072: [native] Add possibility to display nux tip above an item.
Aug 19 2024, 8:24 AM
inka added inline comments to D13071: [native] Refactor nux tips overlay to reanimated 2.
Aug 19 2024, 8:21 AM
inka updated the diff for D13071: [native] Refactor nux tips overlay to reanimated 2.

Simplify

Aug 19 2024, 8:21 AM
inka added inline comments to D13069: [native] Extract normal style from animated style.
Aug 19 2024, 7:31 AM
inka updated the diff for D13066: [native] Refactor background opacity to reanimated 2.

Address review

Aug 19 2024, 7:24 AM
inka added inline comments to D13066: [native] Refactor background opacity to reanimated 2.
Aug 19 2024, 7:19 AM
inka accepted D13052: [lib] Split add members spec.
Aug 19 2024, 7:11 AM
inka accepted D13057: [lib] Add function allowing extracting ThreadInfo from updates.
Aug 19 2024, 6:46 AM
inka added a comment to D13057: [lib] Add function allowing extracting ThreadInfo from updates.

One thing we could do here is add a separate update type for unread status. This way the logic from D13059 that needs getUpdatedThreadInfo would not be needed, and so getUpdatedThreadInfo would not be needed. But this might be too much work.

Aug 19 2024, 6:45 AM
inka accepted D13058: [lib] Delete old replies count logic.
Aug 19 2024, 6:20 AM
inka requested changes to D13059: [lib] Update the replies count.

We tested sidebar creation and replies count is incorrect - after creating a sidebar and adding one message to it, the count was 2 instead of 1

Aug 19 2024, 6:18 AM
inka accepted D13059: [lib] Update the replies count.
Aug 19 2024, 6:11 AM
inka accepted D13055: [lib] Allow sending messages to some users.
Aug 19 2024, 5:57 AM
inka accepted D13053: [lib] Split change thread settings spec.
Aug 19 2024, 5:56 AM
inka added inline comments to D13052: [lib] Split add members spec.
Aug 19 2024, 5:41 AM
inka updated the diff for D13064: [native] Modify overlay context to handle reanimated 2 components.

Rename

Aug 19 2024, 5:05 AM
inka updated the diff for D13063: [native] Simplify name.

Rebase

Aug 19 2024, 4:59 AM
inka added inline comments to D13064: [native] Modify overlay context to handle reanimated 2 components.
Aug 19 2024, 4:58 AM
inka closed D13062: [native] Turn MenuComponent into text.
Aug 19 2024, 1:59 AM
inka closed D12986: [native] Move render and constructor.
Aug 19 2024, 1:59 AM
inka committed rCOMM1d7de47034d9: [native] Move render and constructor (authored by inka).
[native] Move render and constructor
Aug 19 2024, 1:59 AM
inka committed rCOMMa59a69a40f8c: [native] Turn MenuComponent into text (authored by inka).
[native] Turn MenuComponent into text
Aug 19 2024, 1:59 AM
inka closed D12985: [native] Inline code in NUXTipsOverlay.
Aug 19 2024, 1:59 AM
inka closed D12984: [native] Remove unused variables.
Aug 19 2024, 1:59 AM
inka committed rCOMM74fd0eb50b19: [native] Remove unused variables (authored by inka).
[native] Remove unused variables
Aug 19 2024, 1:59 AM
inka committed rCOMM8ba14cd37616: [native] Inline code in NUXTipsOverlay (authored by inka).
[native] Inline code in NUXTipsOverlay
Aug 19 2024, 1:59 AM
inka closed D12983: [native] Move tipContainerStyle.
Aug 19 2024, 1:59 AM