Page MenuHomePhabricator
Feed Advanced Search

Sep 3 2024

bartek published D13227: [tunnelbroker] Close WS session when received special AMQP message for review.

I also considered using an enum

enum AMQPMessage {
  MessageToDevice(MessageToDevice),
  SessionClose
}

but again I had weird issues with serde when trying to make it backwards compatible with existing format.

Sep 3 2024, 12:11 AM
bartek published D13226: [identity] Implement RestoreUser RPCs for review.
Sep 3 2024, 12:09 AM
bartek published D13225: [identity] Add function to update social proof for review.
Sep 3 2024, 12:05 AM
bartek published D13224: [identity] Allow register_primary_device() to overwrite device list for review.
Sep 3 2024, 12:05 AM
bartek published D13223: [identity] Update SignedDeviceList::from_str to return tonic::Status for review.
Sep 3 2024, 12:05 AM
bartek published D13222: [identity] Verify lastPrimarySignature for singleton lists for review.
Sep 3 2024, 12:04 AM
bartek published D13221: [protos][identity] Add RestoreUser RPCs for review.
Sep 3 2024, 12:04 AM

Sep 1 2024

bartek accepted D13203: [terraform] add PITR to dynamodb tables.
Sep 1 2024, 11:34 PM

Aug 29 2024

bartek added a comment to D13203: [terraform] add PITR to dynamodb tables.

Generally seems okay to enable it for all these tables

Aug 29 2024, 1:59 AM
bartek accepted D13170: [terraform] create automated MariaDB backups.
Aug 29 2024, 1:56 AM

Aug 22 2024

bartek closed D13130: [identity] Query reserved usernames in concurrent batches.
Aug 22 2024, 4:04 AM
bartek committed rCOMMacd82b15dd8f: [identity] Query reserved usernames in concurrent batches (authored by bartek).
[identity] Query reserved usernames in concurrent batches
Aug 22 2024, 4:04 AM
bartek closed D13129: [comm-lib] Add util to split vec into n chunks.
Aug 22 2024, 4:04 AM
bartek committed rCOMMa317e958ca9e: [comm-lib] Add util to split vec into n chunks (authored by bartek).
[comm-lib] Add util to split vec into n chunks
Aug 22 2024, 4:04 AM

Aug 21 2024

bartek published D13130: [identity] Query reserved usernames in concurrent batches for review.
Aug 21 2024, 5:06 AM
bartek published D13129: [comm-lib] Add util to split vec into n chunks for review.
Aug 21 2024, 5:05 AM
bartek closed D13128: [terraform] Bump staging Backup to 0.4.2.
Aug 21 2024, 2:31 AM
bartek committed rCOMM67a4ab87ebf2: [terraform] Bump staging Backup to 0.4.2 (authored by bartek).
[terraform] Bump staging Backup to 0.4.2
Aug 21 2024, 2:31 AM
bartek published D13128: [terraform] Bump staging Backup to 0.4.2 for review.
Aug 21 2024, 1:33 AM

Aug 19 2024

bartek closed D13043: [lib] Fail signing device list if called by secondary device.
Aug 19 2024, 4:42 AM
bartek closed D13044: [native] Select logout flow basing on being primary device.
Aug 19 2024, 4:42 AM
bartek committed rCOMMd628ec7a8a59: [lib] Fail signing device list if called by secondary device (authored by bartek).
[lib] Fail signing device list if called by secondary device
Aug 19 2024, 4:42 AM
bartek committed rCOMM093bf14a19e2: [native] Select logout flow basing on being primary device (authored by bartek).
[native] Select logout flow basing on being primary device
Aug 19 2024, 4:42 AM
bartek closed D13042: [identity] Verify UpdateDeviceList RPC is called by primary device.
Aug 19 2024, 4:42 AM
bartek committed rCOMM3701921a7ea6: [identity] Verify UpdateDeviceList RPC is called by primary device (authored by bartek).
[identity] Verify UpdateDeviceList RPC is called by primary device
Aug 19 2024, 4:42 AM
bartek updated the diff for D13044: [native] Select logout flow basing on being primary device.

Address feedback

Aug 19 2024, 2:29 AM
bartek accepted D13103: [terraform] change to use variables for keyserver image version.
Aug 19 2024, 2:17 AM
bartek accepted D13049: [lib] process Inbound P2P messages on app start.
Aug 19 2024, 2:17 AM

Aug 13 2024

bartek accepted D13038: [lib] rename PrimaryDeviceLogout -> DeviceLogout.
Aug 13 2024, 1:47 AM
bartek accepted D13008: [native] Use MMKV locking utils to sync between main app and notifs code.

Makes sense to me

Aug 13 2024, 1:42 AM

Aug 12 2024

bartek published D13044: [native] Select logout flow basing on being primary device for review.
Aug 12 2024, 12:09 AM
bartek published D13043: [lib] Fail signing device list if called by secondary device for review.
Aug 12 2024, 12:08 AM
bartek published D13042: [identity] Verify UpdateDeviceList RPC is called by primary device for review.
Aug 12 2024, 12:08 AM

Aug 11 2024

bartek added a reviewer for D13038: [lib] rename PrimaryDeviceLogout -> DeviceLogout: kamil.
  1. Can you explain why we want to reuse this message for those two separate use cases, intead of having two separate ones?
Aug 11 2024, 1:47 AM
bartek accepted D13040: [native] Fix encrypted media upload on Android.
Aug 11 2024, 1:27 AM
bartek accepted D13039: [native] Fix VideoPlaybackModal for encrypted keyserver-hosted media.
Aug 11 2024, 1:24 AM
bartek accepted D12960: [terraform] configure personal ip address through script and not allowed_ips var.
Aug 11 2024, 1:24 AM

Aug 8 2024

bartek added a comment to D12962: [lib] Add action type to remove peer user.

In the initial revision (https://phab.comm.dev/D12962?id=43060) there were 3 places with relyingOnAuthoritativeKeyserver check:

  1. before action dispatch
  2. in AuxUserReducer
  3. in UserReducer
Aug 8 2024, 6:56 AM
bartek accepted D13020: [tunnelbroker] invalidate bad wns device tokens.
Aug 8 2024, 1:24 AM
bartek accepted D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain.
Aug 8 2024, 12:07 AM

Aug 6 2024

bartek accepted D12935: [Tunnelbroker] send push notifs to windows devices.

LGTM, letting @kamil take a look at the request format

Aug 6 2024, 10:57 PM
bartek accepted D12934: [Tunnelbroker] Implement client method to get WNS token.
Aug 6 2024, 10:53 PM
bartek accepted D13002: [terraform] resolve faulty ecs task stop alarm.
Aug 6 2024, 10:42 PM
bartek accepted D12998: [lib] render `PeerToPeerMessageHandler` in `PeerToPeerProvider`.

Thanks

Aug 6 2024, 5:57 AM
bartek closed D12997: [lib] Use the useBroadcastOlmMessage hook in logout actions.
Aug 6 2024, 5:18 AM
bartek closed D12996: [lib] Use the useBroadcastOlmMessage hook in account deletion.
Aug 6 2024, 5:18 AM
bartek committed rCOMMa3ff59879f59: [lib] Use the useBroadcastOlmMessage hook in logout actions (authored by bartek).
[lib] Use the useBroadcastOlmMessage hook in logout actions
Aug 6 2024, 5:18 AM
bartek committed rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion (authored by bartek).
[lib] Use the useBroadcastOlmMessage hook in account deletion
Aug 6 2024, 5:18 AM
bartek closed D12995: [lib] Add hook to broadcast Olm-encrypted messages.
Aug 6 2024, 5:18 AM
bartek committed rCOMM484a1c2b5690: [lib] Add hook to broadcast Olm-encrypted messages (authored by bartek).
[lib] Add hook to broadcast Olm-encrypted messages
Aug 6 2024, 5:18 AM
bartek closed D12994: [lib] Add selector to get peers user and device IDs.
Aug 6 2024, 5:18 AM
bartek committed rCOMM901f2f5f3fd5: [lib] Add selector to get peers user and device IDs (authored by bartek).
[lib] Add selector to get peers user and device IDs
Aug 6 2024, 5:18 AM
bartek updated the diff for D12997: [lib] Use the useBroadcastOlmMessage hook in logout actions.

Rebase on moved hook

Aug 6 2024, 4:30 AM
bartek updated the diff for D12996: [lib] Use the useBroadcastOlmMessage hook in account deletion.

Rebase on moved hook

Aug 6 2024, 4:30 AM
bartek updated the diff for D12995: [lib] Add hook to broadcast Olm-encrypted messages.

Move to PeerToPeerProvider, pass auth metadata, use Promise.all

Aug 6 2024, 4:29 AM
bartek updated the diff for D12994: [lib] Add selector to get peers user and device IDs.

Rename according to suggestion

Aug 6 2024, 4:29 AM
bartek published D12997: [lib] Use the useBroadcastOlmMessage hook in logout actions for review.
Aug 6 2024, 1:36 AM
bartek published D12996: [lib] Use the useBroadcastOlmMessage hook in account deletion for review.
Aug 6 2024, 1:36 AM
bartek published D12994: [lib] Add selector to get peers user and device IDs for review.
Aug 6 2024, 1:35 AM
bartek published D12995: [lib] Add hook to broadcast Olm-encrypted messages for review.
Aug 6 2024, 1:35 AM

Aug 5 2024

bartek closed D12989: [terraform] Deploy Identity 0.34 to production.
Aug 5 2024, 8:01 AM
bartek committed rCOMM9dedbbd620f4: [terraform] Deploy Identity 0.34 to production (authored by bartek).
[terraform] Deploy Identity 0.34 to production
Aug 5 2024, 8:01 AM
bartek published D12989: [terraform] Deploy Identity 0.34 to production for review.
Aug 5 2024, 7:47 AM
bartek closed D12974: [terraform] Add Backup to ECS Service Connect.
Aug 5 2024, 6:28 AM
bartek closed D12973: [identity] Delete Backup user data on account deletion.
Aug 5 2024, 6:28 AM
bartek committed rCOMM61dc78e5062b: [terraform] Add Backup to ECS Service Connect (authored by bartek).
[terraform] Add Backup to ECS Service Connect
Aug 5 2024, 6:28 AM
bartek committed rCOMM7d827184c069: [identity] Delete Backup user data on account deletion (authored by bartek).
[identity] Delete Backup user data on account deletion
Aug 5 2024, 6:28 AM
bartek closed D12972: [identity] Add config for Backup service URL.
Aug 5 2024, 6:28 AM
bartek closed D12971: [backup] Add endpoint to delete user data.
Aug 5 2024, 6:27 AM
bartek committed rCOMM2d7fe04ffc52: [identity] Add config for Backup service URL (authored by bartek).
[identity] Add config for Backup service URL
Aug 5 2024, 6:27 AM
bartek committed rCOMM9fc405d0fda4: [backup] Add endpoint to delete user data (authored by bartek).
[backup] Add endpoint to delete user data
Aug 5 2024, 6:27 AM
bartek closed D12970: [backup] Extract function to query DDB index.
Aug 5 2024, 6:27 AM
bartek committed rCOMM32dbc25d2be6: [backup] Extract function to query DDB index (authored by bartek).
[backup] Extract function to query DDB index
Aug 5 2024, 6:27 AM
bartek added inline comments to D12971: [backup] Add endpoint to delete user data.
Aug 5 2024, 5:56 AM
bartek closed D12962: [lib] Add action type to remove peer user.
Aug 5 2024, 5:54 AM
bartek committed rCOMM20970f6988a2: [lib] Add action type to remove peer user (authored by bartek).
[lib] Add action type to remove peer user
Aug 5 2024, 5:54 AM
bartek closed D12961: [lib] Delete auxUserStore users on authoritative keyserver request.
Aug 5 2024, 5:54 AM
bartek committed rCOMMdf0ead45ef88: [lib] Delete auxUserStore users on authoritative keyserver request (authored by bartek).
[lib] Delete auxUserStore users on authoritative keyserver request
Aug 5 2024, 5:54 AM
bartek closed D12945: [lib] Re-broadcast account deletion on own devices.
Aug 5 2024, 5:54 AM
bartek committed rCOMMe939fed93850: [lib] Re-broadcast account deletion on own devices (authored by bartek).
[lib] Re-broadcast account deletion on own devices
Aug 5 2024, 5:54 AM
bartek closed D12944: [lib] Broadcast account deletion message to peers.
Aug 5 2024, 5:54 AM
bartek committed rCOMM0e7b20072836: [lib] Broadcast account deletion message to peers (authored by bartek).
[lib] Broadcast account deletion message to peers
Aug 5 2024, 5:54 AM
bartek closed D12943: [lib] Add account deletion P2P message type.
Aug 5 2024, 5:54 AM
bartek committed rCOMMe29e859ce627: [lib] Add account deletion P2P message type (authored by bartek).
[lib] Add account deletion P2P message type
Aug 5 2024, 5:54 AM
bartek closed D12918: [identity] Ask Tunnelbroker to delete data on account deletion.
Aug 5 2024, 5:54 AM
bartek committed rCOMM119e9b84e7b7: [identity] Ask Tunnelbroker to delete data on account deletion (authored by bartek).
[identity] Ask Tunnelbroker to delete data on account deletion
Aug 5 2024, 5:54 AM
bartek added a comment to D12959: [terraform] Adds aws region export to aws-deploy.sh script.
In D12959#367023, @will wrote:

To clarify then, we should be exporting AWS_REGION then right? I can do a test

Aug 5 2024, 5:40 AM
bartek added inline comments to D12944: [lib] Broadcast account deletion message to peers.
Aug 5 2024, 5:36 AM
bartek published D12973: [identity] Delete Backup user data on account deletion for review.
Aug 5 2024, 5:35 AM
bartek updated the diff for D12962: [lib] Add action type to remove peer user.

Inline unnecessary variable

Aug 5 2024, 5:32 AM
bartek updated the diff for D12962: [lib] Add action type to remove peer user.

Return missing ops, remove conditions

Aug 5 2024, 5:30 AM
bartek updated the diff for D12961: [lib] Delete auxUserStore users on authoritative keyserver request.

Return missing ops

Aug 5 2024, 5:30 AM
bartek published D12974: [terraform] Add Backup to ECS Service Connect for review.
Aug 5 2024, 5:09 AM
bartek published D12972: [identity] Add config for Backup service URL for review.
Aug 5 2024, 5:09 AM
bartek published D12971: [backup] Add endpoint to delete user data for review.
Aug 5 2024, 5:08 AM
bartek published D12970: [backup] Extract function to query DDB index for review.
Aug 5 2024, 5:08 AM
bartek updated the summary of D12918: [identity] Ask Tunnelbroker to delete data on account deletion.
Aug 5 2024, 5:00 AM
bartek accepted D12968: [lib] rename `invalidateTunnelbrokerDeviceToken` -> `invalidateTunnelbrokerDeviceTokenActionType`.
Aug 5 2024, 4:17 AM
bartek added inline comments to D12944: [lib] Broadcast account deletion message to peers.
Aug 5 2024, 3:23 AM
bartek updated the diff for D12944: [lib] Broadcast account deletion message to peers.

Improvements to useBroadcastAccountDeletion hook

Aug 5 2024, 3:20 AM