I also considered using an enum
enum AMQPMessage { MessageToDevice(MessageToDevice), SessionClose }
but again I had weird issues with serde when trying to make it backwards compatible with existing format.
I also considered using an enum
enum AMQPMessage { MessageToDevice(MessageToDevice), SessionClose }
but again I had weird issues with serde when trying to make it backwards compatible with existing format.
Generally seems okay to enable it for all these tables
Address feedback
Makes sense to me
In D13038#368633, @ashoat wrote:
- Can you explain why we want to reuse this message for those two separate use cases, intead of having two separate ones?
In the initial revision (https://phab.comm.dev/D12962?id=43060) there were 3 places with relyingOnAuthoritativeKeyserver check:
LGTM, letting @kamil take a look at the request format
Thanks
Rebase on moved hook
Rebase on moved hook
Move to PeerToPeerProvider, pass auth metadata, use Promise.all
Rename according to suggestion
In D12959#367023, @will wrote:To clarify then, we should be exporting AWS_REGION then right? I can do a test
Inline unnecessary variable
Return missing ops, remove conditions
Return missing ops
Improvements to useBroadcastAccountDeletion hook