Page MenuHomePhorge
Feed Search

Feb 16 2025

ashoat committed rCOMM6b4925d09f79: Revert "[native] Temporary changes for staff release".
Feb 16 2025, 9:43 AM
ashoat added a reverting change for rCOMM57ccf6d3e2fb: [native] Temporary changes for staff release: rCOMM6b4925d09f79: Revert "[native] Temporary changes for staff release".
Feb 16 2025, 9:43 AM
ashoat committed rCOMMe74229594a65: [native] codeVersion -> 462.
Feb 16 2025, 9:43 AM
ashoat committed rCOMM57ccf6d3e2fb: [native] Temporary changes for staff release.
Feb 16 2025, 9:43 AM
ashoat committed rCOMM2b0ed600c9b1: [lib] Temporarily flip useIsRestoreFlowEnabled to true.
Feb 16 2025, 9:43 AM
ashoat committed rCOMMfb46841bc200: [native] codeVersion -> 461.
Feb 16 2025, 9:43 AM
ashoat committed rCOMMccecd2ce7527: [web][keyserver] codeVersion -> 153.
Feb 16 2025, 9:43 AM
ashoat added a comment to D14367: [identity] Forbid RestoreUser RPC for authoritative keyserver owner.

What RPC should the authoritative keyserver owner's primary device call instead? I suppose we should be calling a "v1" RPC instead of a v2 one, and the fact that the wrong one was called is a client issue?

Feb 16 2025, 9:23 AM
ashoat added inline comments to D14368: [web] Fix flashing QR code on QR code login screens.
Feb 16 2025, 9:22 AM

Feb 14 2025

ashoat closed D14361: [lib] Avoid creating Promises for showInMessagePreview if not needed.
Feb 14 2025, 10:18 AM
ashoat committed rCOMM520c6e5b9e91: [lib] Avoid creating Promises for showInMessagePreview if not needed.
Feb 14 2025, 10:18 AM
ashoat added inline comments to D14361: [lib] Avoid creating Promises for showInMessagePreview if not needed.
Feb 14 2025, 10:15 AM
ashoat added a comment to D14308: [native] Migrate fling functionality in FullScreenViewModal.

I'm not sure what the right diff to apply this feedback to is, but I noticed a difference in behavior while testing the changes on my iOS device.

Feb 14 2025, 8:57 AM
ashoat accepted D14303: [native] Migrate pinch gesture handling in FullScreenViewModal.
Feb 14 2025, 8:51 AM
ashoat accepted D14302: [native] Migrate pan gesture handling in FullScreenViewModal.
Feb 14 2025, 8:46 AM
ashoat accepted D14301: [native] Migrate buttons refs and measuring in FullScreenViewModal.
Feb 14 2025, 8:32 AM
ashoat added inline comments to D14300: [native] Migrate gestures to react-native-gesture-handler v2 API in FullScreenViewModal.
Feb 14 2025, 6:30 AM
ashoat added inline comments to D14298: [native] Migrate orientation logic in FullScreenViewModal to functional component.
Feb 14 2025, 6:24 AM
ashoat added inline comments to D14298: [native] Migrate orientation logic in FullScreenViewModal to functional component.
Feb 14 2025, 6:23 AM
ashoat requested review of D14361: [lib] Avoid creating Promises for showInMessagePreview if not needed.
Feb 14 2025, 1:11 AM

Feb 13 2025

ashoat committed rCOMMb52d65c1097d: [terraform] Bump keyserver image to 1.0.152.
Feb 13 2025, 6:56 AM

Feb 12 2025

ashoat committed rCOMM6050c5c657e5: Revert "[native] Temporary changes for staff release".
Feb 12 2025, 8:24 PM
ashoat added a reverting change for rCOMM55a95d6b7543: [native] Temporary changes for staff release: rCOMM6050c5c657e5: Revert "[native] Temporary changes for staff release".
Feb 12 2025, 8:24 PM
ashoat added a reverting change for rCOMMb180d1a51c63: [lib] Temporarily flip useIsRestoreFlowEnabled to true: rCOMM0a9667db7395: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true".
Feb 12 2025, 8:24 PM
ashoat committed rCOMM0a9667db7395: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true".
Feb 12 2025, 8:24 PM
ashoat committed rCOMMcb6117802930: [native] codeVersion -> 460.
Feb 12 2025, 8:24 PM
ashoat committed rCOMM55a95d6b7543: [native] Temporary changes for staff release.
Feb 12 2025, 8:24 PM
ashoat committed rCOMMb180d1a51c63: [lib] Temporarily flip useIsRestoreFlowEnabled to true.
Feb 12 2025, 8:24 PM
ashoat committed rCOMM4b73dd03a4fb: [native] codeVersion -> 459.
Feb 12 2025, 8:24 PM
ashoat committed rCOMM76f213158132: [web][keyserver] codeVersion -> 152.
Feb 12 2025, 8:24 PM
ashoat closed D14347: [lib] Use "your message" for reaction MessagePreview.
Feb 12 2025, 1:59 PM
ashoat closed D14346: [native] Introduce C++ MessageSpecs for membership robotext.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMd3204b9ecadf: [lib] Use "your message" for reaction MessagePreview.
Feb 12 2025, 1:59 PM
ashoat closed D14345: [lib] Don't set thread to unread for membership robotext in thin threads.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM6f8f04efbb7f: [native] Introduce C++ MessageSpecs for membership robotext.
Feb 12 2025, 1:59 PM
ashoat closed D14344: [lib] Don't set thread to unread for reactions to other user's messages.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM9e5875ab6a75: [lib] Don't set thread to unread for membership robotext in thin threads.
Feb 12 2025, 1:59 PM
ashoat closed D13919: [lib] Don't bump thin thread timestamp for membership robotext.
Feb 12 2025, 1:59 PM
ashoat closed D14338: [lib][web] Introduce threadIDIsThick.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMea97d13b0d77: [lib] Don't set thread to unread for reactions to other user's messages.
Feb 12 2025, 1:59 PM
ashoat closed D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMdaeca04ca44a: [lib][web] Introduce threadIDIsThick.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMed4a7ace58be: [lib] Don't bump thin thread timestamp for membership robotext.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM880d244d0286: [lib] Reactions only bump thread timestamps when reacting to viewer.
Feb 12 2025, 1:59 PM
ashoat closed D13829: [lib] Hide membership robotext from MessagePreview in thin threads.
Feb 12 2025, 1:59 PM
ashoat closed D13828: [lib] Only show reactions to viewer's messages in MessagePreview.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM66e1ed36f86f: [lib] Hide membership robotext from MessagePreview in thin threads.
Feb 12 2025, 1:59 PM
ashoat closed D14343: [lib] Only set DM threads to unread for certain message types.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM3206010f0102: [lib] Only set DM threads to unread for certain message types.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMff40159837e5: [lib] Only show reactions to viewer's messages in MessagePreview.
Feb 12 2025, 1:59 PM
ashoat closed D14342: [lib] Add messagesNotifyTypes to ProcessDMOpsPayload.
Feb 12 2025, 1:59 PM
ashoat closed D14340: [lib] Use notificationCollapseKey to dedup sidebarCreation notifs in multimediaMessageSpec.
Feb 12 2025, 1:59 PM
ashoat closed D14341: [lib] Don't pass MessageData to getMessageNotifyType.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM114ba23ad0f2: [lib] Add messagesNotifyTypes to ProcessDMOpsPayload.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM965ac1fc0b1b: [lib] Use notificationCollapseKey to dedup sidebarCreation notifs in….
Feb 12 2025, 1:59 PM
ashoat committed rCOMM6616b63237f1: [lib] Don't pass MessageData to getMessageNotifyType.
Feb 12 2025, 1:59 PM
ashoat closed D14339: [lib] Fix DM push notifs code to fetch message from SQLite instead of Redux.
Feb 12 2025, 1:59 PM
ashoat closed D14337: [keyserver] Only bump last_message_for_unread_check for certain message types.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM1c344b3d76e4: [keyserver] Only bump last_message_for_unread_check for certain message types.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM4415c8a4e056: [lib] Fix DM push notifs code to fetch message from SQLite instead of Redux.
Feb 12 2025, 1:59 PM
ashoat closed D14336: [keyserver] Refactor latest message determination logic.
Feb 12 2025, 1:59 PM
ashoat closed D14335: [keyserver][lib] Split generateNotifUserInfoPromise into two.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM049cd0929deb: [keyserver] Refactor latest message determination logic.
Feb 12 2025, 1:59 PM
ashoat closed D14334: [lib][keyserver][native] Renames to prepare for some robotext not setting thread to unread.
Feb 12 2025, 1:59 PM
ashoat closed D14333: [keyserver] Introduce latestMessageForUnreadCheck to LatestMessageInfo.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMb8c118d45e72: [lib][keyserver][native] Renames to prepare for some robotext not setting….
Feb 12 2025, 1:59 PM
ashoat committed rCOMMbadaf89528b0: [keyserver][lib] Split generateNotifUserInfoPromise into two.
Feb 12 2025, 1:59 PM
ashoat closed D14331: [keyserver] Unify LatestMessageInfo type.
Feb 12 2025, 1:59 PM
ashoat closed D14332: [keyserver] Consider all new messages in determineLatestMessagesPerThread.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMdc71c6a91a1a: [keyserver] Introduce latestMessageForUnreadCheck to LatestMessageInfo.
Feb 12 2025, 1:59 PM
ashoat committed rCOMM6774b11a11d1: [keyserver] Unify LatestMessageInfo type.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMb5ea24eb7798: [keyserver] Consider all new messages in determineLatestMessagesPerThread.
Feb 12 2025, 1:59 PM
ashoat closed D14330: [keyserver] Update unread checks to use new last_message_for_unread_check column.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMccd3413f075d: [keyserver] Update unread checks to use new last_message_for_unread_check column.
Feb 12 2025, 1:59 PM
ashoat closed D14329: [keyserver] Code for updating last_message_for_unread_check.
Feb 12 2025, 1:59 PM
ashoat committed rCOMMaf2ce3b4be78: [keyserver] Code for updating last_message_for_unread_check.
Feb 12 2025, 1:59 PM
ashoat closed D14328: [keyserver] Introduce new last_message_for_unread_check column.
Feb 12 2025, 1:58 PM
ashoat committed rCOMM13de3a20759a: [keyserver] Introduce new last_message_for_unread_check column.
Feb 12 2025, 1:58 PM
ashoat updated the diff for D14347: [lib] Use "your message" for reaction MessagePreview.

Rebase

Feb 12 2025, 1:39 PM
ashoat accepted D14354: [CryptoModule] handle not-existing prekeys in Olm account.
Feb 12 2025, 1:21 PM
ashoat added inline comments to D14053: [native] DisplayCommunityDirectoryPrompt.
Feb 12 2025, 5:30 AM
ashoat added inline comments to D14053: [native] DisplayCommunityDirectoryPrompt.
Feb 12 2025, 5:27 AM
ashoat added inline comments to D14204: [native] fix avatars in directory.
Feb 12 2025, 5:27 AM
ashoat added inline comments to D14204: [native] fix avatars in directory.
Feb 12 2025, 5:17 AM
ashoat added inline comments to D14204: [native] fix avatars in directory.
Feb 12 2025, 5:11 AM
ashoat requested changes to D14053: [native] DisplayCommunityDirectoryPrompt.
Feb 12 2025, 5:10 AM
ashoat added inline comments to D14204: [native] fix avatars in directory.
Feb 12 2025, 4:58 AM
ashoat accepted D14296: [native] Display a badge on the profile tab when there are some logs.

Looks good to me, I think the approach makes sense, and in general am not too worried about the staff-only features

Feb 12 2025, 12:22 AM

Feb 11 2025

ashoat updated the diff for D14334: [lib][keyserver][native] Renames to prepare for some robotext not setting thread to unread.

Fix typo

Feb 11 2025, 2:50 PM
ashoat added inline comments to D14348: [web][push-notif] free memory in `commonPeerDecrypt`.
Feb 11 2025, 2:43 PM
ashoat added inline comments to D14333: [keyserver] Introduce latestMessageForUnreadCheck to LatestMessageInfo.
Feb 11 2025, 1:57 PM
ashoat added inline comments to D14333: [keyserver] Introduce latestMessageForUnreadCheck to LatestMessageInfo.
Feb 11 2025, 1:55 PM
ashoat requested review of D14334: [lib][keyserver][native] Renames to prepare for some robotext not setting thread to unread.
Feb 11 2025, 1:25 PM
ashoat requested review of D14347: [lib] Use "your message" for reaction MessagePreview.
Feb 11 2025, 10:54 AM
ashoat requested review of D14346: [native] Introduce C++ MessageSpecs for membership robotext.
Feb 11 2025, 10:46 AM
ashoat requested review of D14345: [lib] Don't set thread to unread for membership robotext in thin threads.
Feb 11 2025, 10:36 AM
ashoat requested review of D14344: [lib] Don't set thread to unread for reactions to other user's messages.
Feb 11 2025, 10:27 AM
ashoat requested review of D14343: [lib] Only set DM threads to unread for certain message types.
Feb 11 2025, 10:18 AM
ashoat requested review of D14342: [lib] Add messagesNotifyTypes to ProcessDMOpsPayload.
Feb 11 2025, 10:09 AM
ashoat requested review of D14341: [lib] Don't pass MessageData to getMessageNotifyType.
Feb 11 2025, 9:59 AM