Rename types
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 20 2023
Mar 20 2023
rohan added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
rohan updated the diff for D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Wonder if there's a way to catch this sort of thing with CI
[lib] Fix `TUnion`/`TInterface` imports
atul committed rCOMMbcb8e9e4126e: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`… (authored by atul).
[lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`…
atul updated the diff for D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types.
rebase and land
Harbormaster failed remote builds in B17445: Diff 23900 for D7099: [native] add feature flag to avatars render work!
Harbormaster failed remote builds in B17444: Diff 23899 for D7069: [native] render the rest of the user avatars!
Harbormaster failed remote builds in B17443: Diff 23898 for D7057: [native] render avatar in profile screen!
atul committed rCOMMe927714acf3f: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding (authored by atul).
[keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding
rebase before landing
rebase before landing
rebase before landing
rebase before landing
atul updated the diff for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.
rebase and land
feedback
rebase before landing
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
implemented atuls quick suggestion
atul committed rCOMM4c6ac988e277: [lib] Introduce `updateUserAvatarRequestValidator` (authored by atul).
[lib] Introduce `updateUserAvatarRequestValidator`
rebase and land
ginsu added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
I'm not sure, but I think we should bump buildToolsVersion as well
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
fix gates
In D7060#210983, @ashoat wrote:{F436096}
Putting it in scripts/ sounds like a good idea to me!
atul requested changes to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
One last change
ginsu added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
added avatar client feature gate to fetcher
This diff seems to call getAPNsNotificationTopic with two parameters, but the version of that function in master only takes one parameter. Can you please update this diff's dependencies so I can see the rest of your stack? Please always set diff dependencies!
atul added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Almost there!
atul added 1 blocking reviewer(s) for D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types: ginsu.
atul published D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types for review.
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
improvements
Still need to fix chat bubble poking out (will timebox for 1-2hrs)
Looks good, but a couple notes in message-creator.js
looks good thanks for making the unit tests
ginsu added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Can you create a Linear task for handling this edge case and set it to Backlog?
Putting it in scripts/ sounds like a good idea to me!
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
address comments
atul updated the diff for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.
fix typo
rohan updated the diff for D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.
Update toggleMessagePinRequestInputValidator
Harbormaster failed remote builds in B17428: Diff 23881 for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding!
rohan updated the test plan for D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.
Update ToggleMessagePinRequest
[landing] remove abosh from the team page
atul published D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding for review.
rohan updated the summary of D6924: [keyserver] Introduce columns in messages table to support pinned messages.
rohan added inline comments to D6929: [keyserver] Add a function to toggle the pin status of a message.
marcin requested review of D7106: Native Java code to request notifications permissions from JS on Android 13.
rohan updated the summary of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
rohan updated the summary of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
rohan updated the summary of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
rohan updated the diff for D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Simplify the migration
rohan retitled D6924: [keyserver] Introduce columns in messages table to support pinned messages from [keyserver] Introduce a pinned_messages table to [keyserver] Introduce columns in messages table to support pinned messages.
rohan updated the diff for D6924: [keyserver] Introduce columns in messages table to support pinned messages.
Introduce two columns in messages
Address Feedback
I haven't seen all call sites yet (only the key generation diff is up) so I can't really tell but maybe it's worth revisiting the types and function arguments to have this as clean and consistent as possible.
rebase
update types
ginsu added a comment to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Sequencing this diff towards the end of the diff stack (need to put up a few more diffs up first) but will update the relational revisions when I have a better idea
ginsu updated the summary of D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
[Android] Reference Tools by CMake project