Page MenuHomePhabricator
Feed All Stories

Mar 20 2023

atul closed D7098: [keyserver] Add `avatar` column to `threads` table of serverDB.
Mar 20 2023, 7:37 AM
atul committed rCOMMc49378d39f63: [keyserver] Add `avatar` column to `threads` table of serverDB (authored by atul).
[keyserver] Add `avatar` column to `threads` table of serverDB
Mar 20 2023, 7:37 AM
atul updated the diff for D7098: [keyserver] Add `avatar` column to `threads` table of serverDB.

rebase and land

Mar 20 2023, 7:33 AM
varun requested changes to D7087: [Comm-opaque2] Add wasm build to client.
Mar 20 2023, 7:33 AM
atul closed D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 20 2023, 7:32 AM
atul committed rCOMM4fbb34a3f4cd: [lib] Introduce `*AvatarDBContent` types (authored by atul).
[lib] Introduce `*AvatarDBContent` types
Mar 20 2023, 7:32 AM
bartek closed D7025: [web] Add unit tests for AES functions.
Mar 20 2023, 7:30 AM
bartek committed rCOMM5a9b3ee3b8c3: [web] Add unit tests for AES functions (authored by bartek).
[web] Add unit tests for AES functions
Mar 20 2023, 7:30 AM
bartek closed D7024: [web] Implement AES encryption functions.
Mar 20 2023, 7:30 AM
bartek committed rCOMM0a9f3ff4fc9d: [web] Implement AES encryption functions (authored by bartek).
[web] Implement AES encryption functions
Mar 20 2023, 7:30 AM
ginsu requested review of D7099: [native] add feature flag to avatars render work.
Mar 20 2023, 7:21 AM
atul updated the diff for D7097: [lib] Introduce `*AvatarDBContent` types.

address feedback (and sneak in ENSAvatarDBContent)

Mar 20 2023, 7:21 AM
ginsu added a comment to D7067: [native] render user avatars in chat screen.

Changed the stack order so that this diff comes after D7099, so that we aren't blocked on this diff for landing the avatars work once D7099 (feature flag work) is accepted. I tested on my local stack each diff when changing the order and nothing was broken

Mar 20 2023, 7:19 AM
atul added inline comments to D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 20 2023, 7:18 AM
ginsu updated the summary of D7067: [native] render user avatars in chat screen.
Mar 20 2023, 7:17 AM
ginsu updated the diff for D7067: [native] render user avatars in chat screen.

rebase after changing up diff stack order

Mar 20 2023, 7:16 AM
bartek closed D7008: [native][AES] Implement decrypt function on Android.
Mar 20 2023, 7:15 AM
bartek closed D7007: [native][AES] Implement encrypt function on Android.
Mar 20 2023, 7:15 AM
bartek committed rCOMMfc7383f60b2e: [native][AES] Implement encrypt function on Android (authored by bartek).
[native][AES] Implement encrypt function on Android
Mar 20 2023, 7:15 AM
bartek closed D7006: [native][AES] Implement decrypt function on iOS.
Mar 20 2023, 7:15 AM
bartek committed rCOMM868e5fda92f6: [native][AES] Implement decrypt function on iOS (authored by bartek).
[native][AES] Implement decrypt function on iOS
Mar 20 2023, 7:15 AM
bartek committed rCOMMa0951b122781: [native][AES] Implement decrypt function on Android (authored by bartek).
[native][AES] Implement decrypt function on Android
Mar 20 2023, 7:15 AM
bartek closed D7005: [native][AES] Implement encrypt function on iOS.
Mar 20 2023, 7:15 AM
bartek closed D7004: [native][AES] Implement generateKey function.
Mar 20 2023, 7:15 AM
bartek closed D7002: [native] Create AESCrypto Expo module.
Mar 20 2023, 7:15 AM
bartek committed rCOMM46037bfe9b83: [native][AES] Implement generateKey function (authored by bartek).
[native][AES] Implement generateKey function
Mar 20 2023, 7:15 AM
bartek committed rCOMM5789ca85981d: [native][AES] Implement encrypt function on iOS (authored by bartek).
[native][AES] Implement encrypt function on iOS
Mar 20 2023, 7:15 AM
bartek committed rCOMM8735eb5f5924: [native] Create AESCrypto Expo module (authored by bartek).
[native] Create AESCrypto Expo module
Mar 20 2023, 7:15 AM
ginsu updated the summary of D7069: [native] render the rest of the user avatars.
Mar 20 2023, 7:15 AM
ginsu updated the diff for D7069: [native] render the rest of the user avatars.

rebase after switching up diff stack order

Mar 20 2023, 7:14 AM
ginsu updated the diff for D7057: [native] render avatar in profile screen.

rebase after switching up diff stack order

Mar 20 2023, 7:13 AM
ginsu updated the summary of D7055: [native] introduce Avatar component.
Mar 20 2023, 7:12 AM
ginsu updated the diff for D7055: [native] introduce Avatar component.

rebase after switching up diff stack order

Mar 20 2023, 7:12 AM
ginsu updated the diff for D7053: [lib] introduce getAvatarForUser in avatar-utils.

rebase

Mar 20 2023, 7:11 AM
atul accepted D7061: [lib] Introduce combined padding interface.
Mar 20 2023, 7:07 AM
bartek updated the diff for D7025: [web] Add unit tests for AES functions.

Rebase before landing

Mar 20 2023, 6:57 AM
bartek updated the diff for D7024: [web] Implement AES encryption functions.

Rebase before landing

Mar 20 2023, 6:57 AM
bartek updated the diff for D7008: [native][AES] Implement decrypt function on Android.

Rebase before landing

Mar 20 2023, 6:56 AM
bartek updated the diff for D7007: [native][AES] Implement encrypt function on Android.

Rebase before landing

Mar 20 2023, 6:56 AM
bartek updated the diff for D7006: [native][AES] Implement decrypt function on iOS.

Rebase before landing

Mar 20 2023, 6:55 AM
bartek updated the diff for D7005: [native][AES] Implement encrypt function on iOS.

Rebase before landing

Mar 20 2023, 6:55 AM
bartek updated the diff for D7004: [native][AES] Implement generateKey function.

Rebase before landing

Mar 20 2023, 6:55 AM
bartek updated the diff for D7002: [native] Create AESCrypto Expo module.

Rebase before landing

Mar 20 2023, 6:55 AM
michal updated the diff for D7094: [keyserver] Send updateBadgeCount notifs to macOS.

Remove unnecessary lines

Mar 20 2023, 5:43 AM
inka updated the diff for D7076: [keyserver] Add search table to the db.

Address review. Tested the new db creation (in prod mode, because I'm having weird problems with my setup. For more info see https://linear.app/comm/issue/ENG-3325/clean-database-migration-fail),
made sure the primary key is created.

Mar 20 2023, 4:14 AM
inka added inline comments to D7076: [keyserver] Add search table to the db.
Mar 20 2023, 4:10 AM
kamil closed D6993: [web-db] initialize SQLite database.
Mar 20 2023, 3:40 AM
kamil committed rCOMM2b354c58f0f6: [web-db] initialize SQLite database (authored by kamil).
[web-db] initialize SQLite database
Mar 20 2023, 3:40 AM
kamil closed D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 20 2023, 3:40 AM
kamil committed rCOMM88db3ac63232: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset (authored by kamil).
[web-db] Use unique filename for each prod `sql-wasm.wasm` asset
Mar 20 2023, 3:40 AM
kamil added a comment to D6993: [web-db] initialize SQLite database.
In D6993#209859, @tomek wrote:

Do we know how this diff corresponds to https://linear.app/comm/issue/ENG-3322/fix-stale-cache-error-for-olmwasm#comment-d1aabe3d? Maybe this will somehow improve the experience about the path's configuration?

Mar 20 2023, 3:38 AM
inka updated the diff for D7077: [keyserver] Process new messages for search.

Address review and add early return when there is nothing to insert

Mar 20 2023, 3:37 AM
kamil closed D6992: [web-db] implement proxy for promise-based connection with worker.
Mar 20 2023, 2:51 AM
kamil closed D6991: [web-db] implement basic app-worker connection types.
Mar 20 2023, 2:51 AM
kamil committed rCOMM3de89fd327d0: [web-db] implement proxy for promise-based connection with worker (authored by kamil).
[web-db] implement proxy for promise-based connection with worker
Mar 20 2023, 2:51 AM
kamil committed rCOMM661a2b6b9ccd: [web-db] implement basic app-worker connection types (authored by kamil).
[web-db] implement basic app-worker connection types
Mar 20 2023, 2:51 AM
kamil closed D6990: [web-db] add indexedDB config.
Mar 20 2023, 2:51 AM
kamil committed rCOMMe8645d4fe752: [web-db] add indexedDB config (authored by kamil).
[web-db] add indexedDB config
Mar 20 2023, 2:51 AM
kamil added inline comments to D6991: [web-db] implement basic app-worker connection types.
Mar 20 2023, 2:40 AM
michal added a comment to D7095: [desktop] Stop checking for a new version after download.

This code was supposed to handle an edge case where:

  1. Electron downloads an update, and we display the modal
  2. Before the user presses the modal to quit-and-install, we release a new version.

Without this, the user will have to update the app twice instead of once (in this rare case).

Mar 20 2023, 2:40 AM
kamil updated the test plan for D6991: [web-db] implement basic app-worker connection types.
Mar 20 2023, 2:24 AM
inka added inline comments to D7076: [keyserver] Add search table to the db.
Mar 20 2023, 1:57 AM

Mar 17 2023

jon closed D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 17 2023, 3:41 PM
jon committed rCOMM8751e77ed757: [comm-opaque] Create opaque 2.0 facade for usage in Comm (authored by jon).
[comm-opaque] Create opaque 2.0 facade for usage in Comm
Mar 17 2023, 3:41 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 17 2023, 3:38 PM
ginsu added inline comments to D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 17 2023, 3:21 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

rlib -> lib

Mar 17 2023, 2:38 PM
ginsu accepted D7098: [keyserver] Add `avatar` column to `threads` table of serverDB.
Mar 17 2023, 2:18 PM
ginsu accepted D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 17 2023, 2:16 PM
atul accepted D7060: [lib] Introduce superblock padding.

The Notion doc was super helpful for understanding what's going on. Thanks for taking the time to write that all out.

Mar 17 2023, 2:11 PM
ashoat added inline comments to D7059: [lib] Introduce PKCS#7 padding.
Mar 17 2023, 2:01 PM
atul added inline comments to D7059: [lib] Introduce PKCS#7 padding.
Mar 17 2023, 1:08 PM
atul accepted D7059: [lib] Introduce PKCS#7 padding.

Thanks for including unit tests!

Mar 17 2023, 1:01 PM
atul published D7098: [keyserver] Add `avatar` column to `threads` table of serverDB for review.
Mar 17 2023, 12:51 PM
atul accepted D7091: [native] Fork Olm.
Mar 17 2023, 12:49 PM
atul accepted D7089: [web][keyserver] Fork Olm.
Mar 17 2023, 12:48 PM
atul added inline comments to D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 17 2023, 12:20 PM
atul published D7097: [lib] Introduce `*AvatarDBContent` types for review.
Mar 17 2023, 12:19 PM
ashoat accepted D7096: [web/desktop] Update immediately on versions v1 and v2.
Mar 17 2023, 11:30 AM
michal requested review of D7096: [web/desktop] Update immediately on versions v1 and v2.
Mar 17 2023, 11:29 AM
ashoat added a comment to D7095: [desktop] Stop checking for a new version after download.

I'm confused – we're just deleting this? Can you provide more details on what it was supposed to do, and how that intent is handled now?

Mar 17 2023, 11:28 AM
michal requested review of D7095: [desktop] Stop checking for a new version after download.
Mar 17 2023, 11:24 AM
ashoat accepted D7094: [keyserver] Send updateBadgeCount notifs to macOS.
Mar 17 2023, 11:24 AM
ginsu accepted D7093: [native] Use a JSON blob for heightMeasurerKey.
Mar 17 2023, 11:12 AM
michal requested review of D7094: [keyserver] Send updateBadgeCount notifs to macOS.
Mar 17 2023, 11:11 AM
ashoat requested review of D7093: [native] Use a JSON blob for heightMeasurerKey.
Mar 17 2023, 9:44 AM
ashoat accepted D7087: [Comm-opaque2] Add wasm build to client.

Dependencies look good! No context on Rust unfortunately

Mar 17 2023, 8:29 AM
ginsu added a comment to D7067: [native] render user avatars in chat screen.

I'm thinking basically:

  1. In current master, figure out what % of total screen width a chat bubble can take
  2. Subtract the space necessary for the avatar from the total screen width
  3. Keep the % from 1 the same after adjusting for 2

Does that make sense?

Mar 17 2023, 8:21 AM
ashoat added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 8:20 AM
kamil added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 6:46 AM
ashoat added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 6:24 AM
ashoat added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 6:23 AM
InkaSokolowska closed D6999: [web] Fix compose subchannels modal for long names.
Mar 17 2023, 5:57 AM
InkaSokolowska committed rCOMM45da19523557: [web] Fix compose subchannels modal for long names (authored by InkaSokolowska).
[web] Fix compose subchannels modal for long names
Mar 17 2023, 5:57 AM
michal accepted D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 5:52 AM
tomek added a comment to D7059: [lib] Introduce PKCS#7 padding.
In D7059#210217, @atul wrote:

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Mar 17 2023, 4:53 AM
kamil published D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset for review.
Mar 17 2023, 4:29 AM
kamil added a comment to D6993: [web-db] initialize SQLite database.

Example usage is in the test plan, unfortunately, it can not be done as elegantly as in olm case - where both web and .wasm file is hosted from the same place.

Mar 17 2023, 4:23 AM
kamil updated the test plan for D6993: [web-db] initialize SQLite database.
Mar 17 2023, 4:19 AM
kamil updated the diff for D6993: [web-db] initialize SQLite database.

Reflect changes caused by D7092

Mar 17 2023, 4:18 AM