- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 20 2023
rebase and land
address feedback (and sneak in ENSAvatarDBContent)
rebase after changing up diff stack order
rebase after switching up diff stack order
rebase after switching up diff stack order
rebase after switching up diff stack order
rebase
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Remove unnecessary lines
Address review. Tested the new db creation (in prod mode, because I'm having weird problems with my setup. For more info see https://linear.app/comm/issue/ENG-3325/clean-database-migration-fail),
made sure the primary key is created.
In D6993#209859, @tomek wrote:Do we know how this diff corresponds to https://linear.app/comm/issue/ENG-3322/fix-stale-cache-error-for-olmwasm#comment-d1aabe3d? Maybe this will somehow improve the experience about the path's configuration?
Address review and add early return when there is nothing to insert
This code was supposed to handle an edge case where:
- Electron downloads an update, and we display the modal
- Before the user presses the modal to quit-and-install, we release a new version.
Without this, the user will have to update the app twice instead of once (in this rare case).
Mar 17 2023
rlib -> lib
The Notion doc was super helpful for understanding what's going on. Thanks for taking the time to write that all out.
Thanks for including unit tests!
I'm confused – we're just deleting this? Can you provide more details on what it was supposed to do, and how that intent is handled now?
Dependencies look good! No context on Rust unfortunately
In D7067#210469, @ashoat wrote:I'm thinking basically:
- In current master, figure out what % of total screen width a chat bubble can take
- Subtract the space necessary for the avatar from the total screen width
- Keep the % from 1 the same after adjusting for 2
Does that make sense?
In D7059#210217, @atul wrote:Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)
Example usage is in the test plan, unfortunately, it can not be done as elegantly as in olm case - where both web and .wasm file is hosted from the same place.
Reflect changes caused by D7092