Expand comment on Sender / Receiver RPCs

Use Sender / Receiver as X3DH roles

In D6924#211499, @tomek wrote:

How the pinning will be saved on client's side? Do we plan to have it included in a message info? If that's the case, do we plan to update all the message infos saved on all the clients?

Addressed @ginsu feedback from the web version of diff

The same comments as in: https://phab.comm.dev/D7017?id=23714#inline-46406

Addressed @ginsu comments

In D7017#210367, @ginsu wrote:

Also, I personally feel like the label for edited messages should be below the reactions/threads and not to the left/right of it. Could you link or send a screenshot of what the figma has?

Besides nits, some considerations about promise handling.

not very well versed in gradle, but please add me to cmake related stuff in the future :)

How the pinning will be saved on client's side? Do we plan to have it included in a message info? If that's the case, do we plan to update all the message infos saved on all the clients?

Rebase, fix exports

Rebase, fix exports

Rebase, fix exports

address tomeks comments

rebase after merge

Call parseMessageSQLResult instead of rawMessageInfoFromRows

Bump buildToolsVersion

rebase after merge

use new avatar types introduced by @atul

rebase after merge

use new avatar types introduced by @atul

Note to reviewers: this is addressing an Urgent issue, so would be great to prioritize!

(My comments are all repeats of my previous review)

I can change it either way, but we should decide whether we possibly want to use this table for calendar entires in the future. The benefit of using the same table for messages and entries is that if we fetch them by for example time, we will get them sorted correctly right away, and won't have to think about how many of each we should fetch

Can you clarify in what scenarios the id can be null? Usually we only see that for types that also have localID

Naming question

Mirror iOS behavior on Android 13

The test plan is D7114, but that diff failed the Android build. Can you fix it up so that the Android build is no longer breaking? I'm also curious how you were able to test the Android build... was it succeeding in your environment despite failing in CI?

pageSize is 1001 because I used the idea from https://mariadb.com/kb/en/pagination-optimization/ that is to fetch one more row than we intend to process.

fix typo

rename function to be more detailed

Rebase

Address review, rebase

I will change JS-visible interface of those methods.

Removed localID from the type

@inka fixed this in another diff.

Fix what information is being requested by whom