In D7147#211972, @bartek wrote:

How do you obtain the SHA-256 fingerprint? From what I understood from the diff description, it is copy-pasted from Play Console, right?

In D7146#211968, @bartek wrote:

The new ID looks correct

IIRC @ashoat did some linking long time ago so there are leftovers across the codebase (e.g. here)

How do you obtain the SHA-256 fingerprint? From what I understood from the diff description, it is copy-pasted from Play Console, right?

The new ID looks correct

Move prekey information to top-level message

In D6924#211756, @tomek wrote:

It seems like I wasn't clear enough in my comment, so let me explain it differently. Correct me in any place where I'm wrong. So on the client side we would want to display three things:

1. A robotext message in a thread telling that a message was pinned
2. A pin indicator next to a message
3. A list of pinned messages

As far as I understand, what you're describing handles only the 1st point. How do we plan to handle 2nd and 3rd?

update type

Task here: ENG-3377

update type

Revert the changes

Simplified condition

This diff seems to call getAPNsNotificationTopic with two parameters, but the version of that function in master only takes one parameter. Can you please update this diff's dependencies so I can see the rest of your stack? Please always set diff dependencies!

Added message type for error message

Remove the remaining // only for flow lines

id is no longer nullable

In D6961#211322, @ashoat wrote:

Can you clarify in what scenarios the id can be null? Usually we only see that for types that also have localID

Simplified text variable

I've left some inline comments about the types themselves. More general notes:

Added unique keys to the rendered components

Use compareAndSet sicne it is safer and cleaner

Use compareAndSet since it is safer and cleaner

In D6924#211575, @rohan wrote:

In D6924#211499, @tomek wrote:

How the pinning will be saved on client's side? Do we plan to have it included in a message info? If that's the case, do we plan to update all the message infos saved on all the clients?

I'm currently introducing a new message type and a message spec for pinned messages, so we'd have messageContentForClientDB. From my understanding, I can support both content for server and client, but feel free to correct me if I'm wrong.

Use getAndSet() sicne it is safer and cleaner

Reject promise if there is ongoing one already. Check for null promise to avoid NPE.

update prop types for thread settings avatar

removed some unnecssary checks

double checked android rendering

Discovered bug with the avatar generating new random avatar when creating a new chat or sub channel will update this when resolved