Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Apr 27 2023

ginsu closed D7627: [native] move setting ens avatar logic from avatar hooks to edit user avatar provider.

Apr 27 2023, 10:28 AM

ginsu committed rCOMMe256381ac6ad: [native] move setting ens avatar logic from avatar hooks to edit user avatar… (authored by ginsu).

[native] move setting ens avatar logic from avatar hooks to edit user avatar…

Apr 27 2023, 10:28 AM

ginsu closed D7626: [native] introduce edit user avatar provider scaffolding.

Apr 27 2023, 10:26 AM

ginsu committed rCOMMbeeb0016468e: [native] introduce edit user avatar provider scaffolding (authored by ginsu).

[native] introduce edit user avatar provider scaffolding

Apr 27 2023, 10:26 AM

ginsu planned changes to D7643: [native] have upload thread avatar processing/uploading loader only appear for thread being updated.

Will split this diff up even more too since I'm moving and adding code

Apr 27 2023, 10:22 AM

ginsu updated the diff for D7627: [native] move setting ens avatar logic from avatar hooks to edit user avatar provider.

rebase before landing

Apr 27 2023, 10:18 AM

ginsu updated the diff for D7626: [native] introduce edit user avatar provider scaffolding.

rebase before landing

Apr 27 2023, 10:16 AM

Apr 26 2023

ginsu requested review of D7646: [native] introduce thread avatar camera modal.

Apr 26 2023, 11:00 PM

ginsu requested review of D7645: [native] improve factoring out redundant logic for saving an image thread avatar.

Apr 26 2023, 10:58 PM

ginsu abandoned D7550: [native] introduce naive thread avatar camera modal.

D7646 makes this diff obsolete

Apr 26 2023, 10:48 PM

ginsu requested review of D7644: [native] move navigate to emoji thread avatar creation function to be within edit thread avatar.

Apr 26 2023, 10:24 PM

ginsu retitled D7628: [native] improve factoring out redundant logic for saving an image user avatar from [native] improve factoring out redundant logic for saving an image avatar to [native] improve factoring out redundant logic for saving an image user avatar.

Apr 26 2023, 10:16 PM

ginsu requested review of D7643: [native] have upload thread avatar processing/uploading loader only appear for thread being updated.

Apr 26 2023, 10:16 PM

ginsu attached a referenced file: F511613: Screen Recording 2023-04-27 at 12.44.11 AM.mov.

Apr 26 2023, 9:45 PM

ginsu updated the test plan for D7629: [native] introduce edit thread avatar provider.

Apr 26 2023, 9:45 PM

ginsu updated the diff for D7628: [native] improve factoring out redundant logic for saving an image user avatar.

rebase

Apr 26 2023, 9:31 PM

ginsu requested review of D7642: [native] improve user experience for remvoing an avatar.

Apr 26 2023, 5:47 PM

ginsu requested review of D7641: [native] hardcode avatar feature flag to true.

Apr 26 2023, 5:10 PM

ginsu requested review of D7640: [web] turn off dummy avatar feature flag.

Apr 26 2023, 4:49 PM

ginsu requested review of D7639: [web] fix image avatar image being stretched.

Apr 26 2023, 4:48 PM

ginsu requested changes to D7638: [native] Return without error if avatar image `selection` is empty.

I think it would also be good to update uploadSelectedMedia's parameter type which is currently ?MediaLibrarySelection to just MediaLibrarySelection in this diff as well

Apr 26 2023, 4:38 PM

ginsu requested review of D7629: [native] introduce edit thread avatar provider.

Apr 26 2023, 4:33 AM

ginsu updated the summary of D7624: [native] introduce user avatar camera modal.

Apr 26 2023, 4:16 AM

ginsu updated the diff for D7624: [native] introduce user avatar camera modal.

rebase

Apr 26 2023, 4:02 AM

ginsu updated the summary of D7628: [native] improve factoring out redundant logic for saving an image user avatar.

Apr 26 2023, 3:53 AM

ginsu updated the diff for D7628: [native] improve factoring out redundant logic for saving an image user avatar.

fix feature flag

Apr 26 2023, 3:52 AM

ginsu updated the diff for D7628: [native] improve factoring out redundant logic for saving an image user avatar.

update

Apr 26 2023, 3:51 AM

ginsu requested review of D7628: [native] improve factoring out redundant logic for saving an image user avatar.

Apr 26 2023, 3:43 AM

ginsu updated the diff for D7624: [native] introduce user avatar camera modal.

rebase

Apr 26 2023, 3:32 AM

ginsu updated the diff for D7622: [native] move navigate to emoji user avatar creation function to be within edit user avatar.

address comments

Apr 26 2023, 3:05 AM

ginsu updated the diff for D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.

address comments

Apr 26 2023, 3:04 AM

ginsu updated the diff for D7627: [native] move setting ens avatar logic from avatar hooks to edit user avatar provider.

address comments

Apr 26 2023, 3:00 AM

ginsu updated the diff for D7626: [native] introduce edit user avatar provider scaffolding.

address comments

Apr 26 2023, 2:59 AM

Apr 25 2023

ginsu closed D7573: [native] convert useSelectFromGallery to selectFromGallery.

Apr 25 2023, 3:22 PM

ginsu committed rCOMMb6685a707cbb: [native] convert useSelectFromGallery to selectFromGallery (authored by ginsu).

[native] convert useSelectFromGallery to selectFromGallery

Apr 25 2023, 3:22 PM

ginsu closed D7591: [native] add threadID to thread settings loading status selector custom keys.

Apr 25 2023, 3:21 PM

ginsu committed rCOMMaaf4aa50cb76: [native] add threadID to thread settings loading status selector custom keys (authored by ginsu).

[native] add threadID to thread settings loading status selector custom keys

Apr 25 2023, 3:21 PM

ginsu added inline comments to D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.

Apr 25 2023, 2:56 PM

ginsu updated the diff for D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.

fix import order

Apr 25 2023, 2:55 PM

ginsu updated the diff for D7573: [native] convert useSelectFromGallery to selectFromGallery.

rebase before landing

Apr 25 2023, 2:50 PM

ginsu updated the diff for D7591: [native] add threadID to thread settings loading status selector custom keys.

rebase before landing

Apr 25 2023, 2:50 PM

ginsu added inline comments to D7626: [native] introduce edit user avatar provider scaffolding.

Apr 25 2023, 2:43 PM

ginsu added inline comments to D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.

Apr 25 2023, 2:43 PM

ginsu requested review of D7627: [native] move setting ens avatar logic from avatar hooks to edit user avatar provider.

Apr 25 2023, 2:43 PM

ginsu retitled D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider from [native] introduce edit user avatar provider to [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.

Apr 25 2023, 2:41 PM

ginsu updated the diff for D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.

break down diff

Apr 25 2023, 2:39 PM

ginsu added inline comments to D7626: [native] introduce edit user avatar provider scaffolding.

Apr 25 2023, 2:28 PM

ginsu added reviewers for D7626: [native] introduce edit user avatar provider scaffolding: ashoat, atul.

Apr 25 2023, 2:23 PM

ginsu requested review of D7626: [native] introduce edit user avatar provider scaffolding.

Apr 25 2023, 2:16 PM

ginsu updated the summary of D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.

Apr 25 2023, 2:01 PM

ginsu requested review of D7622: [native] move navigate to emoji user avatar creation function to be within edit user avatar.

Apr 25 2023, 1:26 PM

ginsu planned changes to D7624: [native] introduce user avatar camera modal.

Need to create a function to factor out code I commented above

Apr 25 2023, 1:24 PM

ginsu published D7624: [native] introduce user avatar camera modal for review.

Apr 25 2023, 1:24 PM

ginsu abandoned D7549: [native] introduce naive user avatar camera modal.

D7624 makes this diff obsolete

Apr 25 2023, 1:23 PM

ginsu requested review of D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.

Apr 25 2023, 1:16 PM

ginsu added reviewers for D7573: [native] convert useSelectFromGallery to selectFromGallery: ashoat, atul.

Apr 25 2023, 12:59 PM

ginsu updated the diff for D7591: [native] add threadID to thread settings loading status selector custom keys.

address comments

Apr 25 2023, 12:54 PM

Apr 24 2023

ginsu added a comment to D7591: [native] add threadID to thread settings loading status selector custom keys.

Not clear why this is being prioritized right now when avatars work is so very deeply behind.

Apr 24 2023, 1:21 PM

ginsu requested review of D7591: [native] add threadID to thread settings loading status selector custom keys.

Apr 24 2023, 1:09 PM

ginsu closed D7589: [native] fix rendering of edit thread description setting button.

Apr 24 2023, 12:42 PM

ginsu committed rCOMM6cda5f727b1e: [native] fix rendering of edit thread description setting button (authored by ginsu).

[native] fix rendering of edit thread description setting button

Apr 24 2023, 12:42 PM

ginsu closed D7588: [native] fix rendering of edit thread name settings button.

Apr 24 2023, 12:42 PM

ginsu committed rCOMM6d920b17f034: [native] fix rendering of edit thread name settings button (authored by ginsu).

[native] fix rendering of edit thread name settings button

Apr 24 2023, 12:42 PM

ginsu requested review of D7589: [native] fix rendering of edit thread description setting button.

Apr 24 2023, 11:59 AM

ginsu requested review of D7588: [native] fix rendering of edit thread name settings button.

Apr 24 2023, 11:35 AM

ginsu closed D7582: [lib] extend defaultEmojiAvatars.

Apr 24 2023, 9:16 AM

ginsu committed rCOMMbc388f84a3a2: [lib] extend defaultEmojiAvatars (authored by ginsu).

[lib] extend defaultEmojiAvatars

Apr 24 2023, 9:16 AM

ginsu updated the diff for D7582: [lib] extend defaultEmojiAvatars.

rebase before landing

Apr 24 2023, 8:10 AM

Apr 23 2023

ginsu requested review of D7582: [lib] extend defaultEmojiAvatars.

Apr 23 2023, 9:09 PM

Apr 21 2023

ginsu requested review of D7573: [native] convert useSelectFromGallery to selectFromGallery.

Apr 21 2023, 12:48 PM

ginsu closed D7555: [native] remove async in saveENSUserAvatar callback.

Apr 21 2023, 11:59 AM

ginsu committed rCOMM5f1ae61d35dd: [native] remove async in saveENSUserAvatar callback (authored by ginsu).

[native] remove async in saveENSUserAvatar callback

Apr 21 2023, 11:59 AM

ginsu closed D7554: [native] introduce useUploadSelectedMedia hook.

Apr 21 2023, 11:58 AM

ginsu committed rCOMM9081f2d40dba: [native] introduce useUploadSelectedMedia hook (authored by ginsu).

[native] introduce useUploadSelectedMedia hook

Apr 21 2023, 11:58 AM

ginsu updated the diff for D7555: [native] remove async in saveENSUserAvatar callback.

rebase before landing

Apr 21 2023, 11:38 AM

ginsu updated the diff for D7554: [native] introduce useUploadSelectedMedia hook.

address comments/rebase before landing

Apr 21 2023, 11:36 AM

Apr 20 2023

ginsu requested review of D7555: [native] remove async in saveENSUserAvatar callback.

Apr 20 2023, 2:08 PM

ginsu added inline comments to D7554: [native] introduce useUploadSelectedMedia hook.

Apr 20 2023, 1:16 PM

ginsu requested review of D7554: [native] introduce useUploadSelectedMedia hook.

Apr 20 2023, 12:43 PM

ginsu added inline comments to D7549: [native] introduce naive user avatar camera modal.

Apr 20 2023, 10:36 AM

Apr 19 2023

ginsu published D7550: [native] introduce naive thread avatar camera modal for review.

Apr 19 2023, 8:59 PM

ginsu updated the diff for D7549: [native] introduce naive user avatar camera modal.

simplify return

Apr 19 2023, 8:46 PM

ginsu updated the diff for D7549: [native] introduce naive user avatar camera modal.

update order of route name

Apr 19 2023, 7:24 PM

ginsu closed D7548: [native] change type for useProcessSelectedMedia from MediaLibrarySelection to NativeMediaSelection.

Apr 19 2023, 7:17 PM

ginsu committed rCOMMeefebccc4b08: [native] change type for useProcessSelectedMedia from MediaLibrarySelection to… (authored by ginsu).

[native] change type for useProcessSelectedMedia from MediaLibrarySelection to…

Apr 19 2023, 7:17 PM

ginsu published D7549: [native] introduce naive user avatar camera modal for review.

Apr 19 2023, 7:15 PM

ginsu published D7548: [native] change type for useProcessSelectedMedia from MediaLibrarySelection to NativeMediaSelection for review.

Apr 19 2023, 6:48 PM

ginsu closed D7514: [native] introduce ChatCameraModal component.

Apr 19 2023, 6:27 PM

ginsu committed rCOMM0c35edd84354: [native] introduce ChatCameraModal component (authored by ginsu).

[native] introduce ChatCameraModal component

Apr 19 2023, 6:27 PM

ginsu updated the diff for D7514: [native] introduce ChatCameraModal component.

rebase before landing

Apr 19 2023, 6:26 PM

ginsu closed D7546: [native] introduce use ENS avatar to edit user avatar.

Apr 19 2023, 6:24 PM

ginsu committed rCOMM1d1b8b10d933: [native] introduce use ENS avatar to edit user avatar (authored by ginsu).

[native] introduce use ENS avatar to edit user avatar

Apr 19 2023, 6:24 PM

ginsu added a comment to D7514: [native] introduce ChatCameraModal component.

Thanks for helping out here @ashoat! Definitely would have taken me a ton of time to figure that out. As I was working with the [User/Thread]AvatarCameraModal I had the type as AppNavigationProp<'ChatCameraModal'> | AppNavigationProp<'UserAvatarCameraModal'> for a placeholder, and after reading your explanation this helped connect the dots.

Apr 19 2023, 6:22 PM

ginsu updated the diff for D7546: [native] introduce use ENS avatar to edit user avatar.

rebase in atuls changes

Apr 19 2023, 5:44 PM

ginsu attached a referenced file: F497543: Screenshot 2023-04-19 at 8.32.15 PM.png.

Apr 19 2023, 5:33 PM

ginsu attached a referenced file: F497545: Screenshot 2023-04-19 at 8.30.23 PM.png.

Apr 19 2023, 5:33 PM

ginsu added a comment to D7514: [native] introduce ChatCameraModal component.

If neither of those work, let me know and I'll try to patch locally and take a look.

Apr 19 2023, 5:33 PM

ginsu accepted D7543: [native] Alert user when `UPDATE_USER_AVATAR` call fails.

lgtm good catch with that bug

Apr 19 2023, 3:43 PM

ginsu requested review of D7546: [native] introduce use ENS avatar to edit user avatar.

Apr 19 2023, 3:40 PM

ginsu abandoned D7462: [native] introduce use ens avatar option to edit avatar.

D7546 makes this diff obsolete

Apr 19 2023, 3:16 PM