Looks good, small question inline about defaulting to light

fixed flow issues (ran yarn flow-all twice to be sure)

reopen before fixing

Apologies, landed this with flow issues that blocked CI for others (Eg @ginsu)

rebase and land

rebase and land

rip out membership permission

In D9549#280704, @ashoat wrote:

You can remove it from threadPermissions as well

Actually, running into the following when I remove that field

Here's a Linear issue: https://linear.app/comm/issue/ENG-5431/revert-bigint-related-fixmes

Can you figure out which version of React Native brings in that version of Flow? If you need pointers on that let me know. We'll need a Linear task either way, but hopefully we can make it a follow-up for the current upgrade task

So BigInt works on keyserver/web/native (there was a known issue with pow on native, but we're not using that), but flow support only shows up in 0.194.0.

Use BigInt instead of number.

retry

In rCOMM5ddc92900713a1bfc7ef972057213c9d2d312210#21240, @wyilio wrote:

build was failing commtest

Realize this is mostly a refactoring diff, but wonder if we should add some error handling or at least logging to useInitialNotificationsEncryptedMessage? Maybe as a follow-up or something

What happens if the API request fails (eg endpoint is unreachable)? We may end up in a state where not all eth addresses make it to the reserved usernames table.

Seems like straightforward move from native to lib

Good to land as is

Looks good, thanks for proactively including unit tests

Seems reasonable

Nice

Seems reasonable

In D9475#278685, @kamil wrote:

Looks good but also curious about answers to @ashoat's questions

In D9475#278548, @ashoat wrote:

In a meeting with @kamil today, he indicated that MessageStore.threads was in the process of being moved to SQLite.

It's already in SQLite, the only thing is that we have it in both SQLite and redux-persist to assert correctness. There is a task where we synced with @atul: ENG-3743.

address @ashoat's feedback (use threadstore instead of messagestore)

second invariant arg

In D9453#279330, @ashoat wrote:

@atul can you make a Linear task to track refactoring this to use the new update specs approach, and link the task here before landing?

rebase and land

Thanks for addressing feedback

Thanks for addressing feedback

Nice

include updated comm_query_executor.wasm

fix optional chaining