Page MenuHomePhorge
Feed Search

Nov 5 2023

atul accepted D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js.
Nov 5 2023, 7:33 PM
atul accepted D9712: [Flow202][lib][skip-ci] [20/23] Get rid of $FlowFixMes in lib/utils/objects.js.
Nov 5 2023, 7:33 PM
atul accepted D9710: [Flow202][lib][skip-ci] [18/23] Fix Flow issues in lib/socket.
Nov 5 2023, 7:04 PM
atul accepted D9707: [Flow202][lib][skip-ci] [15/23] Fix Flow issues in lib/reducers.
Nov 5 2023, 7:04 PM
atul accepted D9706: [Flow202][lib][skip-ci] [14/23] Fix Flow issues with types of variables that get mutated.
Nov 5 2023, 7:03 PM
atul accepted D9705: [Flow202][lib][skip-ci] [13/23] Fix Flow issues relating to lastPruned that was accidentally left in message-reducer.
Nov 5 2023, 7:00 PM
atul accepted D9702: [Flow202][lib][skip-ci] [10/23] Fix Flow issues with untyped let declarations in entry-reducer.
Nov 5 2023, 6:48 PM
atul accepted D9701: [Flow202][lib][skip-ci] [9/23] Get rid of BigInt $FlowIssues.

Thanks for clearing these

Nov 5 2023, 6:48 PM
atul accepted D9698: [Flow202][lib][skip-ci] [6/23] Fix Flow issues with computed properties.
Nov 5 2023, 6:47 PM
atul accepted D9696: [Flow202][lib][skip-ci] [4/23] Fix Flow issues with baseGetENSNames.bind.

Misclick

Nov 5 2023, 6:47 PM
atul requested changes to D9696: [Flow202][lib][skip-ci] [4/23] Fix Flow issues with baseGetENSNames.bind.
Nov 5 2023, 6:47 PM
atul accepted D9696: [Flow202][lib][skip-ci] [4/23] Fix Flow issues with baseGetENSNames.bind.
Nov 5 2023, 6:44 PM
atul accepted D9695: [Flow202][lib][skip-ci] [3/23] Fix Flow issues with types being underconstrained.
Nov 5 2023, 6:41 PM
atul accepted D9694: [Flow202][lib][skip-ci] [2/23] Fix Flow issues with useDispatch / useSelector being underconstrained.
Nov 5 2023, 6:29 PM
atul accepted D9693: [Flow202][lib][skip-ci] [1/23] Fix Flow issues with React hooks being underconstrained.
Nov 5 2023, 6:27 PM
atul accepted D9692: [Flow202][lib][skip-ci] [0/23] Fix Flow issues relating to unsealed objects.
Nov 5 2023, 6:26 PM
atul accepted D9691: [RN72][skip-ci] Update Flow to 0.202.1.
Nov 5 2023, 6:17 PM
atul accepted D9690: [RN72][skip-ci] Update React Native and React package versions.
Nov 5 2023, 6:16 PM

Nov 3 2023

atul accepted D9688: [web] introduce light mode to password change modal.

Looks good, didn't check the spreadsheet but trusting you've doubled checked that values are correct

Nov 3 2023, 8:49 PM
atul published D9689: [lib] Introduce `decodeThreadRolePermissionsBitmaskArray` for review.
Nov 3 2023, 7:49 PM
atul published D9687: [lib] Introduce `threadRolePermissionsBlobToBitmaskArray` for review.
Nov 3 2023, 7:22 PM
atul resigned from D9686: [lib] Prevent editing role permissions from adding unexpected permissions.

Resigning since I don't have a ton of context and adding @ashoat as blocking.

Nov 3 2023, 6:44 PM
atul accepted D9683: [native] stop persisting `messageStore.threads` via redux-persist.
Nov 3 2023, 6:33 PM
atul accepted D9682: [lib] remove asserting if `messageStore.threads` are equal.
Nov 3 2023, 6:30 PM
atul closed D9677: [lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })`.
Nov 3 2023, 1:21 AM
atul committed rCOMM0eb7a828a7d8: [lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })`.
Nov 3 2023, 1:21 AM
atul updated the diff for D9677: [lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })`.

rebase before landing

Nov 3 2023, 1:14 AM
atul closed D9676: [lib] Introduce `invertObjectToMap`.
Nov 3 2023, 1:10 AM
atul committed rCOMM7483cae752b2: [lib] Introduce `invertObjectToMap`.
Nov 3 2023, 1:10 AM
atul updated the diff for D9676: [lib] Introduce `invertObjectToMap`.

address feedback

Nov 3 2023, 1:08 AM

Nov 2 2023

atul published D9677: [lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })` for review.
Nov 2 2023, 7:16 PM
atul requested review of D9676: [lib] Introduce `invertObjectToMap`.
Nov 2 2023, 7:05 PM
atul accepted D9669: [native] Support avatar uploads to blob service.
Nov 2 2023, 3:31 AM
atul attached a referenced file: F848934: 605f64.png.
Nov 2 2023, 2:27 AM
atul added inline comments to D9668: [native] Support displaying encrypted avatars.
Nov 2 2023, 2:27 AM
atul accepted D9668: [native] Support displaying encrypted avatars.
Nov 2 2023, 2:25 AM
atul accepted D9624: [web] Display encrypted image avatars.
Nov 2 2023, 2:22 AM
atul accepted D9170: [web] Support avatar uploads to blob service.
Nov 2 2023, 2:19 AM
atul accepted D9169: [lib] Add blob service upload avatar type validators.

Looks good, thanks for adding the unit tests

Nov 2 2023, 2:16 AM
atul accepted D9168: [keyserver][lib] Support new avatar type for encrypted images.

Looks good!

Nov 2 2023, 2:15 AM
atul closed D9663: [lib] Introduce `decodeRolePermissionBitmask`.
Nov 2 2023, 2:12 AM
atul committed rCOMM445632bf1545: [lib] Introduce `decodeRolePermissionBitmask`.
Nov 2 2023, 2:12 AM
atul updated the diff for D9663: [lib] Introduce `decodeRolePermissionBitmask`.

rebase and land

Nov 2 2023, 1:51 AM
atul added inline comments to D9663: [lib] Introduce `decodeRolePermissionBitmask`.
Nov 2 2023, 1:50 AM
atul updated the diff for D9663: [lib] Introduce `decodeRolePermissionBitmask`.

resolve merge conflicts

Nov 2 2023, 1:40 AM
atul closed D9662: [lib] Introduce `rolePermissionToBitmaskHex`.
Nov 2 2023, 1:35 AM
atul committed rCOMM4846f866bfaa: [lib] Introduce `rolePermissionToBitmaskHex`.
Nov 2 2023, 1:35 AM
atul added inline comments to D9662: [lib] Introduce `rolePermissionToBitmaskHex`.
Nov 2 2023, 1:33 AM
atul updated the diff for D9662: [lib] Introduce `rolePermissionToBitmaskHex`.

address feedback + add comments

Nov 2 2023, 1:32 AM
atul added inline comments to D9662: [lib] Introduce `rolePermissionToBitmaskHex`.
Nov 2 2023, 1:17 AM
atul updated the diff for D9662: [lib] Introduce `rolePermissionToBitmaskHex`.

rebase and land

Nov 2 2023, 1:11 AM

Nov 1 2023

atul attached a referenced file: F848148: d3964e.png.
Nov 1 2023, 5:58 PM
atul added inline comments to D9663: [lib] Introduce `decodeRolePermissionBitmask`.
Nov 1 2023, 5:58 PM
atul updated the diff for D9663: [lib] Introduce `decodeRolePermissionBitmask`.

Add & BigInt(63)

Nov 1 2023, 5:46 PM
atul updated the diff for D9663: [lib] Introduce `decodeRolePermissionBitmask`.

fix invariant issue

Nov 1 2023, 5:39 PM
atul added inline comments to D9663: [lib] Introduce `decodeRolePermissionBitmask`.
Nov 1 2023, 5:32 PM

Oct 31 2023

atul updated the diff for D9663: [lib] Introduce `decodeRolePermissionBitmask`.

fix flow suppression label

Oct 31 2023, 11:01 PM
atul published D9663: [lib] Introduce `decodeRolePermissionBitmask` for review.
Oct 31 2023, 10:58 PM
atul published D9662: [lib] Introduce `rolePermissionToBitmaskHex` for review.
Oct 31 2023, 10:30 PM
atul abandoned D9637: [lib] Introduce `rolePermissionToBitmaskHex`.
Oct 31 2023, 6:03 PM
atul abandoned D9649: [DRAFT] Introduce `rolePermissionsToBitmaskHex`.
Oct 31 2023, 6:03 PM
atul abandoned D9651: [DRAFT] Introduce `bitmaskHexToRolePermissions`.
Oct 31 2023, 6:03 PM
atul requested review of D9651: [DRAFT] Introduce `bitmaskHexToRolePermissions`.
Oct 31 2023, 3:01 PM
atul updated the diff for D9649: [DRAFT] Introduce `rolePermissionsToBitmaskHex`.

remove console.log

Oct 31 2023, 1:35 PM
atul updated the diff for D9649: [DRAFT] Introduce `rolePermissionsToBitmaskHex`.

simplify

Oct 31 2023, 1:24 PM
atul added inline comments to D9649: [DRAFT] Introduce `rolePermissionsToBitmaskHex`.
Oct 31 2023, 1:01 PM
atul published D9649: [DRAFT] Introduce `rolePermissionsToBitmaskHex` for review.
Oct 31 2023, 12:54 PM
atul accepted D9647: [lib] Avoid unnecessary Set construction in RadixTree.getAllMatchingExactly.

Good catch

Oct 31 2023, 12:53 PM

Oct 30 2023

atul updated the diff for D9637: [lib] Introduce `rolePermissionToBitmaskHex`.

fixed test name

Oct 30 2023, 7:15 PM
atul published D9637: [lib] Introduce `rolePermissionToBitmaskHex` for review.
Oct 30 2023, 6:53 PM

Oct 26 2023

atul closed D9614: [Buildkite] Move `commtest` `retry` setting to upper level.
Oct 26 2023, 8:08 PM
atul committed rCOMMa56849ceb0c2: [Buildkite] Move `commtest` `retry` setting to upper level.
Oct 26 2023, 8:08 PM
atul published D9614: [Buildkite] Move `commtest` `retry` setting to upper level for review.
Oct 26 2023, 7:27 PM
atul added inline comments to D9569: [Buildkite] Add automatic retries to `CommTest` workflow.
Oct 26 2023, 7:27 PM
atul added inline comments to D9569: [Buildkite] Add automatic retries to `CommTest` workflow.
Oct 26 2023, 7:25 PM
atul accepted D9514: [lib/web/native] Show voiced_in_announcement_channels user-surfaced permission for all community types.
Oct 26 2023, 5:48 PM
atul accepted D9535: Initialize olm sessions for notifications on web and keyserver via socket requests.

Looks good, might be good to have someone with more knowledge about crypto system take another look

Oct 26 2023, 5:35 PM
atul accepted D9592: Merge all redux actions mutating cryptoStore into one..

Makes sense

Oct 26 2023, 5:30 PM
atul added a comment to D9599: [keyserver] Write MariaDB migration to remove incorrect permission from roles.
In D9599#281451, @rohan wrote:

Adding @ashoat as blocking per @atul's request

Oct 26 2023, 5:23 PM
atul added inline comments to D9608: [native] Redux persist migration to remove incorrect permissions from threads.
Oct 26 2023, 5:22 PM
atul accepted D9608: [native] Redux persist migration to remove incorrect permissions from threads.

Looks good, two points

Oct 26 2023, 5:15 PM
atul accepted D9599: [keyserver] Write MariaDB migration to remove incorrect permission from roles.

Thanks for including documentation in Test Plan to show that the migration works as expected. Adding @ashoat as blocking reviewer to take another look since DB migrations can be "risky."

Oct 26 2023, 5:10 PM
atul accepted D9604: [web] fix user profile long username bug.
Oct 26 2023, 4:54 PM
atul added a comment to D9602: [CI] fix iOS build issue following D9470.

Ah gotcha, looks good

Oct 26 2023, 4:42 PM
atul added a comment to D9602: [CI] fix iOS build issue following D9470.

don’t we need to cross compile macos for simulator? we should make sure that continues to work?

Oct 26 2023, 3:52 PM

Oct 25 2023

atul accepted D9601: [CI] Get rid of KEYCHAIN_PASSWORD GitHub secret.

Upon further research, it looks like this is only relevant for runners that are reused for multiple runs of workflows OR for machines that are being used for unrelated workflows that shouldn't have access to these certificates.

Oct 25 2023, 9:58 PM
atul closed D9589: [lib] Update `permissionsToBitmask` to `permissionsToBitmaskHex`.
Oct 25 2023, 5:06 PM
atul committed rCOMM5ea56c594766: [lib] Update `permissionsToBitmask` to `permissionsToBitmaskHex`.
Oct 25 2023, 5:06 PM
atul updated the diff for D9589: [lib] Update `permissionsToBitmask` to `permissionsToBitmaskHex`.

rebase and alnd

Oct 25 2023, 5:02 PM
atul added inline comments to D9589: [lib] Update `permissionsToBitmask` to `permissionsToBitmaskHex`.
Oct 25 2023, 4:39 PM
atul added inline comments to D9589: [lib] Update `permissionsToBitmask` to `permissionsToBitmaskHex`.
Oct 25 2023, 4:38 PM
atul accepted D9600: [native] Update iOS badge for rescinds.
Oct 25 2023, 4:35 PM
atul published D9589: [lib] Update `permissionsToBitmask` to `permissionsToBitmaskHex` for review.
Oct 25 2023, 12:02 AM

Oct 24 2023

atul closed D9549: [lib] Introduce basic `permissionsToBitmask` and `hasPermission`.
Oct 24 2023, 11:10 PM
atul committed rCOMM437c6a11fb52: [lib] Introduce basic `permissionsToBitmask` and `hasPermission`.
Oct 24 2023, 11:10 PM
atul accepted D9585: [native] Use recovery callServerEndpoint when fetching notif keys in resolveInvalidatedCookie.
Oct 24 2023, 11:09 PM
atul accepted D9579: [CI] run iOS Build CI on push to CI branch.

Instead of special casing a CI branch, let's do something like CI-* that includes any branch with a CI-* prefix. This will allow eg two people to diagnose separate CI issues at the same time

Oct 24 2023, 11:07 PM
atul accepted D9584: [native] Use object as param to getInitialNotificationsEncryptedMessage.
Oct 24 2023, 11:03 PM
atul accepted D9583: [web] introduce light mode to danger zone component.
Oct 24 2023, 11:03 PM
atul accepted D9582: [web] introduce light mode to the account settings screen.

Looks good, BUT let's fix spelling of Seperator => Separator before landing

Oct 24 2023, 10:24 PM