Thanks for clearing these
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Nov 5 2023
Misclick
Nov 3 2023
Looks good, didn't check the spreadsheet but trusting you've doubled checked that values are correct
Resigning since I don't have a ton of context and adding @ashoat as blocking.
rebase before landing
address feedback
Nov 2 2023
Looks good, thanks for adding the unit tests
Looks good!
rebase and land
resolve merge conflicts
address feedback + add comments
rebase and land
Nov 1 2023
Add & BigInt(63)
fix invariant issue
Oct 31 2023
fix flow suppression label
remove console.log
simplify
Good catch
Oct 30 2023
fixed test name
Oct 26 2023
Looks good, might be good to have someone with more knowledge about crypto system take another look
Makes sense
In D9599#281451, @rohan wrote:
Looks good, two points
Thanks for including documentation in Test Plan to show that the migration works as expected. Adding @ashoat as blocking reviewer to take another look since DB migrations can be "risky."
Ah gotcha, looks good
don’t we need to cross compile macos for simulator? we should make sure that continues to work?
Oct 25 2023
Upon further research, it looks like this is only relevant for runners that are reused for multiple runs of workflows OR for machines that are being used for unrelated workflows that shouldn't have access to these certificates.
rebase and alnd
Oct 24 2023
Instead of special casing a CI branch, let's do something like CI-* that includes any branch with a CI-* prefix. This will allow eg two people to diagnose separate CI issues at the same time
Looks good, BUT let's fix spelling of Seperator => Separator before landing