Looks good to me

Going with a different approach. Instead of modifying eg useDisconnectedBarVisibilityHandler, I think it makes sense to keep them around for updating ConnectionInfo for keyservers in the KeyserverStore. Will rename them accordingly and introduce separate hooks that consume state => state.connectivity.connected on native and useNetworkConnected on web for displaying DisconnectedBar.

Thanks for taking time to update and address both pieces of feedback!

rebase and land

@michal already addressed this with D10427

Thanks for comprehensive test plan

Seems like a straightforward refactor

Noticed that things look weird when the badge becomes wide (in 99+ scenario):

At a high level this seems correct to me, but I'm not super familiar with all of the tooltip math.

add hasMinCodeVersion check for web

re-open

In D10339#301040, @varun wrote:

sorry, to clarify, i understand why we need protobuf. but i didn’t understand why we need all the apt install stuff. guessing they’re all dependencies of the install script?

In D10339#301021, @varun wrote:

In D10339#301015, @atul wrote:

We need all the apt install and install_protobuf stuff

would you mind explaining why?

back to working and land

without apt install

In D10341#299535, @ashoat wrote:

Can you explain why you had to move away from git diff?

We need all the apt install and install_protobuf stuff