Page MenuHomePhorge
Feed Search

Feb 14 2024

tomek accepted D11046: Introduce MMKV to Android app.
Feb 14 2024, 4:44 PM
tomek accepted D11045: Introduce MMKV to iOS app and NSE.

Wondering if we can perform the init logic in C++ instead so that it can be shared between platforms.

Feb 14 2024, 4:20 PM
tomek closed D11076: [keyserver] Create invite link blobs in a migration.
Feb 14 2024, 3:58 PM
tomek closed D11051: [services] Move reserved_usernames to `shared`.
Feb 14 2024, 3:58 PM
tomek closed D11015: [blob] Block reserved and offensive links from being created.
Feb 14 2024, 3:58 PM
tomek committed rCOMMa8b3efff9b29: [keyserver] Create invite link blobs in a migration.
Feb 14 2024, 3:58 PM
tomek committed rCOMM6ca2c4c7d692: [blob] Block reserved and offensive links from being created.
Feb 14 2024, 3:58 PM
tomek closed D10992: [lib] Join a community on an overridden keyserver.
Feb 14 2024, 3:58 PM
tomek committed rCOMMa9789dfca6ae: [services] Move reserved_usernames to `shared`.
Feb 14 2024, 3:58 PM
tomek committed rCOMMac08dc316650: [lib] Join a community on an overridden keyserver.
Feb 14 2024, 3:58 PM
tomek closed D10991: [native][web][lib] Extract common invite link logic.
Feb 14 2024, 3:58 PM
tomek closed D10338: [web][native] Download invite link blob and use it as an override.
Feb 14 2024, 3:58 PM
tomek closed D10308: [keyserver] Modify link verification so that it works with users that aren't logged in to a keyserver.
Feb 14 2024, 3:58 PM
tomek committed rCOMMfd4b74535fd1: [web][native] Download invite link blob and use it as an override.
Feb 14 2024, 3:58 PM
tomek committed rCOMM097836906978: [native][web][lib] Extract common invite link logic.
Feb 14 2024, 3:58 PM
tomek closed D10307: [lib] Do not provide overrides when we already know a keyserver.
Feb 14 2024, 3:58 PM
tomek committed rCOMMf8c21d9c0755: [keyserver] Modify link verification so that it works with users that aren't….
Feb 14 2024, 3:58 PM
tomek committed rCOMM5b19e0d189b7: [lib] Do not provide overrides when we already know a keyserver.
Feb 14 2024, 3:58 PM
tomek closed D10290: [lib] Modify link verification to call the proper keyserver.
Feb 14 2024, 3:58 PM
tomek closed D10206: [keyserver] Set a job that synchronizes links with blobs.
Feb 14 2024, 3:58 PM
tomek closed D10205: [keyserver] Add a function that synchronizes keyserver's invite links with blobs.
Feb 14 2024, 3:58 PM
tomek committed rCOMM3437898f7c90: [lib] Modify link verification to call the proper keyserver.
Feb 14 2024, 3:58 PM
tomek committed rCOMM122195947a95: [keyserver] Set a job that synchronizes links with blobs.
Feb 14 2024, 3:58 PM
tomek committed rCOMM1131d2bb421a: [keyserver] Add a function that synchronizes keyserver's invite links with blobs.
Feb 14 2024, 3:58 PM
tomek closed D10150: [keyserver] Introduce a function that allows fetching all the primary links.
Feb 14 2024, 3:58 PM
tomek committed rCOMMe4890d882eee: [keyserver] Introduce a function that allows fetching all the primary links.
Feb 14 2024, 3:58 PM
tomek closed D10134: [keyserver] Create a blob while adding / editing an invite link.
Feb 14 2024, 3:58 PM
tomek committed rCOMM4d6183505a6d: [keyserver] Create a blob while adding / editing an invite link.
Feb 14 2024, 3:58 PM
tomek closed D10131: [keyserver] Change blob upload functions to return more usable results.
Feb 14 2024, 3:58 PM
tomek committed rCOMM48441ea35eca: [keyserver] Change blob upload functions to return more usable results.
Feb 14 2024, 3:58 PM
tomek closed D10099: [keyserver] Introduce a util function that generates invite link blob hash.
Feb 14 2024, 3:58 PM
tomek closed D10098: [keyserver] Modify blob functions so that they take params object where both hash and holder are provided.
Feb 14 2024, 3:58 PM
tomek committed rCOMM49dacaa80f96: [keyserver] Introduce a util function that generates invite link blob hash.
Feb 14 2024, 3:58 PM
tomek committed rCOMM619eea4efb61: [keyserver] Modify blob functions so that they take params object where both….
Feb 14 2024, 3:58 PM
tomek closed D9972: [keyserver] Delete a holder after deleting a blob.
Feb 14 2024, 3:58 PM
tomek closed D9968: [keyserver] Fetch invite link blob holder.
Feb 14 2024, 3:58 PM
tomek committed rCOMM80a608e1b045: [keyserver] Delete a holder after deleting a blob.
Feb 14 2024, 3:58 PM
tomek committed rCOMMf2fb42fd31c9: [keyserver] Fetch invite link blob holder.
Feb 14 2024, 3:58 PM
tomek closed D9966: [keyserver] Add a function that deletes a blob.
Feb 14 2024, 3:58 PM
tomek committed rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob.
Feb 14 2024, 3:58 PM
tomek closed D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.
Feb 14 2024, 3:58 PM
tomek committed rCOMM649591495a52: [keyserver] Block creating invite links for which an entry in Blob service….
Feb 14 2024, 3:58 PM
tomek requested review of D11076: [keyserver] Create invite link blobs in a migration.
Feb 14 2024, 3:21 PM
tomek added inline comments to D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().
Feb 14 2024, 2:51 PM
tomek updated the diff for D11051: [services] Move reserved_usernames to `shared`.

Use const

Feb 14 2024, 2:34 PM
tomek added a comment to D10992: [lib] Join a community on an overridden keyserver.
In D10992#318515, @inka wrote:

This code is quite complex in the case you were not able to test - when we connect to a different keyserver, and even mo so when we connect to a couple of keyservers. I can see that it would be hard to test now, but it would be great if you could create a linear task describing how this should be tested once it's possible, and set it as blocked by appropriate tasks.

Feb 14 2024, 12:12 PM
tomek updated the diff for D10131: [keyserver] Change blob upload functions to return more usable results.

Rebase

Feb 14 2024, 11:46 AM
tomek updated the test plan for D9972: [keyserver] Delete a holder after deleting a blob.
Feb 14 2024, 11:45 AM

Feb 13 2024

tomek requested review of D11051: [services] Move reserved_usernames to `shared`.
Feb 13 2024, 2:58 PM
tomek added inline comments to D11015: [blob] Block reserved and offensive links from being created.
Feb 13 2024, 2:54 PM

Feb 12 2024

tomek updated the diff for D11015: [blob] Block reserved and offensive links from being created.

Revert unnecessary changes

Feb 12 2024, 4:23 PM
tomek planned changes to D11015: [blob] Block reserved and offensive links from being created.
Feb 12 2024, 3:44 PM
tomek added inline comments to D11015: [blob] Block reserved and offensive links from being created.
Feb 12 2024, 2:59 PM
tomek updated the diff for D11015: [blob] Block reserved and offensive links from being created.

Check regexes and refactor

Feb 12 2024, 2:57 PM
tomek added inline comments to D10993: [lib][web][native] Add configurable authoritativeKeyserverID.
Feb 12 2024, 2:15 PM
tomek added inline comments to D11015: [blob] Block reserved and offensive links from being created.
Feb 12 2024, 1:29 PM
tomek updated the diff for D10992: [lib] Join a community on an overridden keyserver.

Use join data

Feb 12 2024, 1:12 PM
tomek updated the diff for D10992: [lib] Join a community on an overridden keyserver.

Clear the timeout on unmount

Feb 12 2024, 1:05 PM
tomek updated the diff for D10992: [lib] Join a community on an overridden keyserver.

Clear the timeout on unmount

Feb 12 2024, 1:03 PM
tomek updated the diff for D10992: [lib] Join a community on an overridden keyserver.

Fix a couple of bugs

Feb 12 2024, 11:59 AM
tomek accepted D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 12 2024, 11:17 AM
tomek requested changes to D11022: [web] dispatch setAccessTokenActionType after successful identity login on web.
Feb 12 2024, 9:33 AM
tomek added inline comments to D10992: [lib] Join a community on an overridden keyserver.
Feb 12 2024, 9:21 AM
tomek accepted D11011: [lib] Update genesis.id to use authoritativeKeyserverID.
Feb 12 2024, 9:19 AM
tomek accepted D11008: [web] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 12 2024, 9:18 AM
tomek accepted D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 12 2024, 9:13 AM
tomek requested changes to D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 12 2024, 9:12 AM
tomek accepted D10993: [lib][web][native] Add configurable authoritativeKeyserverID.
Feb 12 2024, 9:02 AM
tomek added inline comments to D11005: [native] use identity wallet login in fullscreen-siwe-panel.
Feb 12 2024, 8:36 AM

Feb 9 2024

tomek requested review of D11015: [blob] Block reserved and offensive links from being created.
Feb 9 2024, 5:47 PM
tomek added inline comments to D11005: [native] use identity wallet login in fullscreen-siwe-panel.
Feb 9 2024, 11:18 AM
tomek updated the diff for D10131: [keyserver] Change blob upload functions to return more usable results.

Fix Flow

Feb 9 2024, 10:48 AM

Feb 8 2024

tomek updated the diff for D10131: [keyserver] Change blob upload functions to return more usable results.

Rebase

Feb 8 2024, 2:34 PM
tomek updated the diff for D10098: [keyserver] Modify blob functions so that they take params object where both hash and holder are provided.

Rebase

Feb 8 2024, 2:33 PM
tomek added inline comments to D9966: [keyserver] Add a function that deletes a blob.
Feb 8 2024, 2:31 PM
tomek updated the diff for D9966: [keyserver] Add a function that deletes a blob.

Use auth headers

Feb 8 2024, 2:31 PM
tomek requested review of D10992: [lib] Join a community on an overridden keyserver.
Feb 8 2024, 2:27 PM
tomek requested review of D10991: [native][web][lib] Extract common invite link logic.
Feb 8 2024, 12:08 PM
tomek accepted D10990: [lib] Add `rolesWithoutSpecialRoleField` filter to `rawThreadInfoFromServerThreadInfo`.

We will patch the specialRole field back in to minimally encoded RawThreadInfos for future clients (where shouldMinimallyEncodePermissions AND includeSpecialRoleFieldInRoles are true).

Feb 8 2024, 10:27 AM
tomek accepted D10975: [lib] Add `shouldIncludeSpecialRoleFieldInRoles` to `RawThreadInfoOptions`.
Feb 8 2024, 10:24 AM
tomek accepted D10107: [keyserver] Update `fetchServerThreadInfos(filter?: FetchThreadInfosFilter)` to fetch special_role.
Feb 8 2024, 10:14 AM
tomek accepted D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.
Feb 8 2024, 10:06 AM
tomek accepted D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.
Feb 8 2024, 9:48 AM

Feb 7 2024

tomek accepted D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.
Feb 7 2024, 2:37 PM
tomek accepted D10964: [crypto] unify one-time keys usage.
Feb 7 2024, 2:36 PM
tomek accepted D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.
Feb 7 2024, 2:27 PM
tomek accepted D10961: [lib][native][web] useIdentityWalletLogIn() hook.
Feb 7 2024, 2:06 PM
tomek added inline comments to D10960: [web] factor out creation of DeviceKeyUpload.
Feb 7 2024, 11:41 AM

Feb 6 2024

tomek abandoned D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.

With the new approach we no longer need this

Feb 6 2024, 2:41 PM
tomek updated the diff for D10338: [web][native] Download invite link blob and use it as an override.

Simplify the approach

Feb 6 2024, 2:41 PM
tomek accepted D10952: [lib] Let keyserver session recovery code handle calling setNewSession.
Feb 6 2024, 12:47 PM
tomek accepted D10951: [lib] Disable keyserver session recovery when paramOverride is specified.
Feb 6 2024, 12:37 PM
tomek accepted D10949: [lib] Conclude sessionRecoveryInProgress when user cookie is received or session is invalidated.
Feb 6 2024, 11:28 AM
tomek accepted D10931: [lib][native] Pass CSAT to Reports endpoint.

I wonder if there's a more generic way we could handle this... I could imagine defining this similar to keyserver actions, where "Comm service actions" are defined as functions that take functions as input. The inner function would be something like callAuthenticatedCommService, and it would allow the "Comm service action" to abstract away the details of authentication. Then we would have a hook (eg. useCommServiceCall) that takes the "Comm service action" function as input, and binds in the callAuthenticatedCommService function.

Feb 6 2024, 9:44 AM
tomek accepted D10930: [lib] Add optional Authorization header to reports endpoint.
Feb 6 2024, 9:40 AM
tomek added inline comments to D10913: [native][web] Add AuthMetadata to Blob service upload actions.
Feb 6 2024, 9:39 AM
tomek accepted D10913: [native][web] Add AuthMetadata to Blob service upload actions.
Feb 6 2024, 9:37 AM
tomek accepted D10912: [web] Pass CSAT to Blob service when fetching multimedia.
Feb 6 2024, 9:28 AM
tomek accepted D10910: [native] Pass CSAT to Blob service when fetching multimedia.
Feb 6 2024, 9:23 AM
tomek requested changes to D10961: [lib][native][web] useIdentityWalletLogIn() hook.
Feb 6 2024, 9:10 AM