It seems like something is missing in this sentence
On the JavaScript side we types data that we receive as event, removed no-op if statement checking for rescind and subscribed to event in push-handler.js
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 18 2023
Jan 18 2023
tomek accepted D6274: Send broadcast from CommNotificationsHandler when foreground notification is received. Forward parsed notification to JavaScript.
tomek requested changes to D6231: Display background notification from Java, remove headless JS task.
Looks ok, but please make sure the types are correct.
Please make sure that the nullability is updated.
Requesting changes because there are a couple of small issues, but overall looks great!
Could you also include in the test plan a check if it updates the url correctly?
Jan 17 2023
Jan 17 2023
tomek requested changes to D6254: [keyserver] call identity service register RPC on account creation.
Jan 16 2023
Jan 16 2023
Jan 13 2023
Jan 13 2023
In D6182#185313, @przemek wrote:That's exactly the way we handle it on native. I thought that we would want to have some consistency between them. We also handle email-like, and not-alphanumeric usernames on submit (on web).
I like your idea, but I think we should go with this for now and create task to rewrite all those cases in the way that they block submit.
Jan 12 2023
Jan 12 2023
Looks great!
I'm really glad to see this logic written in a lot cleaner way!
tomek added inline comments to D6186: [keyserver] reaction messages only notifiy author of target message.
Jan 11 2023
Jan 11 2023
tomek added inline comments to D6226: Move CommNotificationsHandler to newly created notifications package.
tomek accepted D6053: [web] Keyboard support for typeahead [13/13] - Freeze users list when typeahead is visible..
Please don't forget to update the name (if you agree) before landing
tomek added a reviewer for D6070: Export minimal set of CommIOSNotifications RCT methods to use it in AppDelegate: ashoat.
Jan 10 2023
Jan 10 2023
tomek requested changes to D6186: [keyserver] reaction messages only notifiy author of target message.
Jan 9 2023
Jan 9 2023
Looks a lot better than the previous implementation!
tomek requested changes to D6053: [web] Keyboard support for typeahead [13/13] - Freeze users list when typeahead is visible..
We're really close!
Jan 5 2023
Jan 5 2023
rainbowkit and wagmi are a couple of months old - at some point we can consider updating them (maybe after the initial release?)
tomek accepted D6173: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies".
Have you followed this https://www.notion.so/commapp/How-to-revert-a-diff-dcdcd83a09b248b2a3e03372103786e9 guide? This should result in a summary that contains a hash of reverted commit, like e.g. in D6079.
tomek accepted D6052: [web] Keyboard support for typeahead [12/13] - Scrolling thourgh overlay as user interacts with it.
In D6052#185065, @przemek wrote:Used scrollTo.
Added tests and run them.
There were some problems that I solved locally using fixes from here: https://linear.app/comm/issue/ENG-2654/problems-with-jest
I haven't pushed those fixes anywhere as it is to be discussed yet, but I found it acceptable to
push tests even if they fail currently (due to lack of mocks as mentioned on linear).
Similar thing is happening to tooltip-utils.test.js tests and it was ignored in the past I guess.
tomek added inline comments to D4795: Implement encryption key migration to new accessibility options.
I don't think that handling this on submit is a good idea. We should do that earlier by disabling a login button.
Looks good to me! Added @ashoat as blocking to make sure that my idea about using this code version is ok.