Use string template

Fix deltaEntryInfosResultValidator

Use constants

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Rebase

Add subscriptionUpdateResponseValidator because I missed it, and move logOutResponseValidator higher because it will be used earlier (must be declared before it can be used).

I've just tried this code and during yarn cleaninstall I'm getting an error with node-gyp rebuild (which makes sense because it tries to use things from nuget dependencies which aren't downloaded on macOS). @atul are you also getting this error?

Updated test descriptions. Added validator to message spec in another diff.

Fixed test naming and long lines. Added flow types in the inline comments.

Could we add a test where avatar is not defined (RawThreadInfo doesn't have this field at all, not just it is set to null or undefined).

The existing thread example already doesn't have avatar defined.

Add a comment

Introduce changes from the diff in the gist

Fix formatting

Thanks, I should've caught these! Fixed the added type, removed any usage.

Changed mixed to generics, removed lodash _map. Tried to minimize usages of any by using a assertWithValidator function that's a no-op but changes the the data's type after validating it.

Improve typings for entry query validators

Looks good to me

Looks good!

Looks good to me

Fixed, thanks @inka

Init prevConnection to undefined

Rebase

Rebase

Rebase

Rebase

Fill in the objectID for getting the WNS channel (device_token)

Updated the payload type

Updated the payload conversion to string. I've finally figured out the event.payload object. It's an array wrapper created by NodeRT. It has only length property and {[number]: number} index accessor (but it's not an array).

• instead of implicitly failing the preinstall script on macOS/linux because there's no nuget installed, added a bash script that explicitly skips the package install on non-Windows platforms
• changed one of the paths in the bindings.gyp. For some reason the old one was working when I was building the notif package by itself but stopped working when I was building the whole monorepo. The new one is already used in some PRs having a similar problem of updating to a new Visual Studio version so it's probably better anyway (although I'm not sure what the difference is...)

Remove comment

Renamed

Renamed to @commapp/windowspush

Made bindings.gyp more general, renamed to @comapp/windowspush.

Correctly handle all strings. Tested by sending emojis and non-ascii letters.

Added types

Improved error handling and added checking the domain of the url.

Extended the duration of the token to 10s so we have more time to act. All of the tokens I had gotten from WNS previously, had 1h expiry time so it's still a small portion of the expiry time. Added better error explanation.

Update to node-fetch